search for: isor

? KLIBCCC usr/dash/eval.o usr/dash/eval.c: In function 'evaltree': usr/dash/eval.c:277:19: warning: logical not is only applied to the left hand side of comparison [-Wlogical-not-parentheses] ?? if (!exitstatus == isor) ?????????????????? ^ Not sure what the fix should be: ?? if (!(exitstatus == isor)) Or ?? if ((!exitstatus) == isor) Any idea ? Christophe

Hello forum. I''m in the process of re-organizing my server and ACL-settings. I''ve seen so many different ways of doing ACL, which makes me wonder how I should do it myself. This is obviously the easiest way, only describing the positive permissions: /usr/bin/chmod -R A=\ group:sa:full_set:fd:allow,\ group:vk:read_set:fd:allow \ However, I''ve seen people split each

...ntheses Gcc gives a warning about some missing parentheses: ----------------------------------------------------------------------- eval.c: In function ?evaltree?: eval.c:282:15: warning: logical not is only applied to the left hand side of comparison [-Wlogical-not-parentheses] if (!status == isor || evalskip) ^~ eval.c:282:7: note: add parentheses around left hand side expression to silence this warning if (!status == isor || evalskip) ^~~~~~~ ( ) ----------------------------------------------------------------------- Add the parentheses to silence the...

...6eddd ] Gcc gives a warning about some missing parentheses: ----------------------------------------------------------------------- eval.c: In function ?evaltree?: eval.c:282:15: warning: logical not is only applied to the left hand side of comparison [-Wlogical-not-parentheses] if (!status == isor || evalskip) ^~ eval.c:282:7: note: add parentheses around left hand side expression to silence this warning if (!status == isor || evalskip) ^~~~~~~ ( ) ----------------------------------------------------------------------- Add the parentheses to silence the...

New clangs emit some warnings. The code isn't wrong, but should be updated to prevent warning creep. Bill Wendling (3): [klibc] dash: shell: Fix clang warnings [klibc] dash: shell: Fix clang warnings about format string [klibc] Kbuild: use an enum to silence a clang warning usr/dash/eval.c | 6 +++--- usr/dash/jobs.c | 2 +- usr/kinit/nfsmount/dummypmap.c

- Convert the "old style" GNU field designator extension to the new style. - Use proper indexing into a string literal. - Use "%s" for the format string in "fmtstr". - Add or remove casts of the "void *" argument of ioctl. - Convert "if (!exitstatus == isor)" to "if ((!exitstatus) == isor)" which retains the current semantics, but may not be what the programmer intended. Signed-off-by: Bill Wendling <morbo at google.com> --- usr/dash/eval.c | 8 ++++---- usr/dash/jobs.c | 4 ++-- usr/dash/output.c...

.../klibc/zlib/inflate.c | 20 ++++++++++++++++++++ 3 files changed, 22 insertions(+), 2 deletions(-) diff --git a/usr/dash/eval.c b/usr/dash/eval.c index dd144948a9fa..6b2b01e19a47 100644 --- a/usr/dash/eval.c +++ b/usr/dash/eval.c @@ -274,7 +274,7 @@ checkexit: n->nbinary.ch1, (flags | ((isor >> 1) - 1)) & EV_TESTED ); - if (!exitstatus == isor) + if ((!exitstatus) == isor) break; if (!evalskip) { n = n->nbinary.ch2; diff --git a/usr/klibc/zlib/infback.c b/usr/klibc/zlib/infback.c index 455dbc9ee843..be5eace3ad1a 100644 --- a/usr/klibc/zlib/infback.c +++ b/u...

...kmark(&smark); + status = i; + if (evalskip) break; } @@ -192,13 +194,13 @@ evalstring(char *s, int flags) * exitstatus. */ -void +int evaltree(union node *n, int flags) { int checkexit = 0; - void (*evalfn)(union node *, int); + int (*evalfn)(union node *, int); unsigned isor; - int status; + int status = 0; if (n == NULL) { TRACE(("evaltree(NULL) called\n")); goto out; @@ -221,8 +223,7 @@ evaltree(union node *n, int flags) break; #endif case NNOT: - evaltree(n->nnot.com, EV_TESTED); - status = !exitstatus; + status = !evaltree(n->nnot.c...

...kmark(&smark); + status = i; + if (evalskip) break; } @@ -192,13 +194,13 @@ evalstring(char *s, int flags) * exitstatus. */ -void +int evaltree(union node *n, int flags) { int checkexit = 0; - void (*evalfn)(union node *, int); + int (*evalfn)(union node *, int); unsigned isor; - int status; + int status = 0; if (n == NULL) { TRACE(("evaltree(NULL) called\n")); goto out; @@ -221,8 +223,7 @@ evaltree(union node *n, int flags) break; #endif case NNOT: - evaltree(n->nnot.com, EV_TESTED); - status = !exitstatus; + status = !evaltree(n->nnot.c...

...2, 2019 at 04:53:05PM +0000, Christophe Leroy wrote: > ? KLIBCCC usr/dash/eval.o > usr/dash/eval.c: In function 'evaltree': > usr/dash/eval.c:277:19: warning: logical not is only applied to the > left hand side of comparison [-Wlogical-not-parentheses] > ?? if (!exitstatus == isor) > ?????????????????? ^ > > Not sure what the fix should be: > > ?? if (!(exitstatus == isor)) > > > Or > > > ?? if ((!exitstatus) == isor) > > > > Any idea ? Take a look at upstream dash where this is fixed https://git.kernel.org/pub/scm/utils...

This is a series of patches for clang compatibility: - Using flags needed flags and removing unsupported flags. - Adding support for clang's LLD linker. - Removing a variety of warnings. Bill Wendling (3): [klibc] Kbuild: use "libc.a" with clang [klibc] Kbuild: Add "-fcommon" for clang builds [klibc] Clean up clang warnings Michael Davidson (1): [klibc] Kbuild:

Hi! > Any idea ? I believe that: if (!exitstatus == isor) equals to, if ((!exitstatus) == isor) because the exclamation mark have bigger priority than "==". Nikita.

...tyle" GNU field designator extension to the new > style. > - Use proper indexing into a string literal. > - Use "%s" for the format string in "fmtstr". > - Add or remove casts of the "void *" argument of ioctl. > - Convert "if (!exitstatus == isor)" to "if ((!exitstatus) == isor)" > which retains the current semantics, but may not be what the > programmer intended. [...] This is all good, but I don't want to diverge from upstream dash more than necessary. I want to upgrade to the current version of dash, which...

...ns(+), 10 deletions(-) diff --git a/usr/dash/eval.c b/usr/dash/eval.c index 5074aa94..bba0e7f8 100644 --- a/usr/dash/eval.c +++ b/usr/dash/eval.c @@ -200,8 +200,12 @@ evaltree(union node *n, int flags) { int checkexit = 0; int (*evalfn)(union node *, int); + struct stackmark smark; unsigned isor; int status = 0; + + setstackmark(&smark); + if (n == NULL) { TRACE(("evaltree(NULL) called\n")); goto out; @@ -317,6 +321,8 @@ exexit: exraise(EXEXIT); } + popstackmark(&smark); + return exitstatus; } @@ -396,14 +402,12 @@ evalfor(union node *n, int flags)...