search for: ismachineconstantpoolentry

...it's not used. > The attached patch is quite small and shows where the address space > information is getting lost and it will correctly propagate it. It also > avoids existent back-ends to break because of an unimplemented hook in > MCAsmInfo. @@ -1046,7 +1046,8 @@ if (CPE.isMachineConstantPoolEntry()) EmitMachineConstantPoolValue(CPE.Val.MachineCPVal); else - EmitGlobalConstant(CPE.Val.ConstVal); + EmitGlobalConstant(CPE.Val.ConstVal, (isa<PointerType>(Ty)) ? + cast<PointerType>(Ty)->getAddressSpace() : 0); } } } This looks sus...

Hi Eli, On 07/05/2012 18:15, Eli Friedman wrote: > On Mon, May 7, 2012 at 5:15 AM, Ivan Llopard<ivanllopard at gmail.com> wrote: >> Hi all, >> >> Tuning my TargetAsmPrinter implementation in the back-end side, I >> discovered that the address space number is not passed down while >> emitting global variables with constant initializers. The information is

Hi everyone, vmkit requires to know the size of a jitted method before emitting the method. This allows to allocate the correct size for the method. The attached patch creates this functionality when the flag SizedMemoryCode is on. In order to implement this functionality, i had to virtualize some MachineCodeEmitter functions. Is it OK to commit the patch? Thanks, Nicolas --------------

...hineConstantPoolEntry> &Constants = MCP- >> >>> getConstants(); >>> >> + if (Constants.empty()) return; >> + >> + MachineConstantPoolEntry CPE = Constants.back(); >> + unsigned Size = CPE.Offset; >> + const Type *Ty = CPE.isMachineConstantPoolEntry() >> + ? CPE.Val.MachineCPVal->getType() : CPE.Val.ConstVal->getType(); >> + Size += Fn->getTarget().getTargetData()->getABITypeSize(Ty); >> + ConstantPoolBase = allocateSpace(Size, 1 << MCP- >> >>> getConstantPoolAlignment()); >>&...

...chineConstantPool *MCP) { > + const std::vector<MachineConstantPoolEntry> &Constants = MCP- > >getConstants(); > + if (Constants.empty()) return; > + > + MachineConstantPoolEntry CPE = Constants.back(); > + unsigned Size = CPE.Offset; > + const Type *Ty = CPE.isMachineConstantPoolEntry() > + ? CPE.Val.MachineCPVal->getType() : CPE.Val.ConstVal->getType(); > + Size += Fn->getTarget().getTargetData()->getABITypeSize(Ty); > + ConstantPoolBase = allocateSpace(Size, 1 << MCP- > >getConstantPoolAlignment()); > + ConstantPool = MCP; > +} &gt...

...ry> &Constants = MCP- >>> >>>> getConstants(); >>>> >>> + if (Constants.empty()) return; >>> + >>> + MachineConstantPoolEntry CPE = Constants.back(); >>> + unsigned Size = CPE.Offset; >>> + const Type *Ty = CPE.isMachineConstantPoolEntry() >>> + ? CPE.Val.MachineCPVal->getType() : CPE.Val.ConstVal- >>> >getType(); >>> + Size += Fn->getTarget().getTargetData()->getABITypeSize(Ty); >>> + ConstantPoolBase = allocateSpace(Size, 1 << MCP- >>> >>>> getConsta...

...t; The attached patch is quite small and shows where the address space >> information is getting lost and it will correctly propagate it. It also >> avoids existent back-ends to break because of an unimplemented hook in >> MCAsmInfo. > @@ -1046,7 +1046,8 @@ > if (CPE.isMachineConstantPoolEntry()) > EmitMachineConstantPoolValue(CPE.Val.MachineCPVal); > else > - EmitGlobalConstant(CPE.Val.ConstVal); > + EmitGlobalConstant(CPE.Val.ConstVal, (isa<PointerType>(Ty)) ? > + cast<PointerType>(Ty)->getAddressSpace() : 0); &gt...

...t; getConstants(); >>>>> >>>>> >>>> + if (Constants.empty()) return; >>>> + >>>> + MachineConstantPoolEntry CPE = Constants.back(); >>>> + unsigned Size = CPE.Offset; >>>> + const Type *Ty = CPE.isMachineConstantPoolEntry() >>>> + ? CPE.Val.MachineCPVal->getType() : CPE.Val.ConstVal- >>>> >>>>> getType(); >>>>> >>>> + Size += Fn->getTarget().getTargetData()->getABITypeSize(Ty); >>>> + ConstantPoolBase = a...

...>>>> >>>>>> + if (Constants.empty()) return; >>>>>> + >>>>>> + MachineConstantPoolEntry CPE = Constants.back(); >>>>>> + unsigned Size = CPE.Offset; >>>>>> + const Type *Ty = CPE.isMachineConstantPoolEntry() >>>>>> + ? CPE.Val.MachineCPVal->getType() : CPE.Val.ConstVal- >>>>>> >>>>>> >>>>>>> getType(); >>>>>>> >>>>>>> >>>>>> + Size +...

...gt;>> >>>>>>> + if (Constants.empty()) return; >>>>>>> + >>>>>>> + MachineConstantPoolEntry CPE = Constants.back(); >>>>>>> + unsigned Size = CPE.Offset; >>>>>>> + const Type *Ty = CPE.isMachineConstantPoolEntry() >>>>>>> + ? CPE.Val.MachineCPVal->getType() : CPE.Val.ConstVal- >>>>>>> >>>>>>> >>>>>>>> getType(); >>>>>>>> >>>>>>>> >>>>>>> + Size +...

...; >>>>>> >>>>>> >>>>> + if (Constants.empty()) return; >>>>> + >>>>> + MachineConstantPoolEntry CPE = Constants.back(); >>>>> + unsigned Size = CPE.Offset; >>>>> + const Type *Ty = CPE.isMachineConstantPoolEntry() >>>>> + ? CPE.Val.MachineCPVal->getType() : CPE.Val.ConstVal- >>>>> >>>>>> getType(); >>>>>> >>>>> + Size += Fn->getTarget().getTargetData()->getABITypeSize(Ty); >>>>> + ConstantPoolBase...

...>>>>>> + if (Constants.empty()) return; >>>>>>>> + >>>>>>>> + MachineConstantPoolEntry CPE = Constants.back(); >>>>>>>> + unsigned Size = CPE.Offset; >>>>>>>> + const Type *Ty = CPE.isMachineConstantPoolEntry() >>>>>>>> + ? CPE.Val.MachineCPVal->getType() : CPE.Val.ConstVal- >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>>> getType(); >>>>>>>>> &...

...>> + if (Constants.empty()) return; >>>>>>>>> + >>>>>>>>> + MachineConstantPoolEntry CPE = Constants.back(); >>>>>>>>> + unsigned Size = CPE.Offset; >>>>>>>>> + const Type *Ty = CPE.isMachineConstantPoolEntry() >>>>>>>>> + ? CPE.Val.MachineCPVal->getType() : CPE.Val.ConstVal- >>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>>> getType(); >>>>>>>>&gt...