search for: islastcalltailcall

...// a tailcall adjust the stack ... + } else if (RetOpcode == X86::TCRETURNri) { + MBBI = prior(MBB.end()); Seems like there are quite a bit of duplicate code between the 2 cases. Please refactor. 7. X86TargetLowering::X86TargetLowering(TargetMachine &TM) : TargetLowering(TM) { + IsLastCallTailCall = false; This is probably not a good idea. You are assuming nodes are lowered in certain order, that is dangerous. It's probably better to check whether the last call is a tail call on the fly as you are processing the return node. 8. - - SDOperand Chain = Op.getOperand(0); - SDOperan...

Hi Evan, first off thanks to you and Chris for taking time. On 6 Sep 2007, at 00:57, Evan Cheng wrote: > We'd like to see tail call optimization to be similar to the target > independent lowering of ISD::CALL nodes. These are auto-generated > from ???CallingConv.td files. Some target specific details such as > function address register (ECX in your example) should be coded in

...if (RetOpcode == X86::TCRETURNri) { > + MBBI = prior(MBB.end()); > > Seems like there are quite a bit of duplicate code between the 2 > cases. Please refactor. Okay dokey > 7. > X86TargetLowering::X86TargetLowering(TargetMachine &TM) > : TargetLowering(TM) { > + IsLastCallTailCall = false; > > This is probably not a good idea. You are assuming nodes are lowered > in certain order, that is dangerous. It's probably better to check > whether the last call is a tail call on the fly as you are processing > the return node. Will do so. > 8. > - > - SD...

...code Adds register arguments (EAX, EDX) as live in if they are used for arguments. Create a TAILCALL node (a pseudo instruction) holding the Callee (Register or TargetGlobalAddress/ExternalSymbol), the stack adjustment as a constant, and the live-in registers. The TargetLowering class has a IsLastCallTailCall state field which is set to true such that the LowerRET function nows it has to produce different code. The TAILCALL node is then returned. If it is not okay the code produces a function call like the std calling convention (callee pops arguments on return). There is one difference though: s...

...r arguments (EAX, EDX) as live in if they are used for > arguments. > Create a TAILCALL node (a pseudo instruction) holding the Callee > (Register or TargetGlobalAddress/ExternalSymbol), the stack > adjustment as a constant, and the live-in registers. The > TargetLowering class has a IsLastCallTailCall state field which is > set to true such that the LowerRET function nows it has to produce > different code. The TAILCALL node is then returned. > > If it is not okay the code produces a function call like the std > calling convention (callee pops arguments on return). > There is o...

Hello, Arnold. Only quick comments, I'll try to make a full review a little bit later. > 0.)a fast calling convention (maybe use the current > CallingConv::Fast, or create a CallingConv::TailCall) > 1.) lowering of formal arguments > like for example x86_LowerCCCArguments in stdcall mode > we need to make sure that later mentioned CALL_CLOBBERED_REG is >