search for: isinsidebundl

Is it safe or legal to call isInsideBundle even when I == E? MachineBasicBlock::iterator MachineBasicBlock::getFirstNonPHI() { instr_iterator I = instr_begin(), E = instr_end(); while (I != E && I->isPHI()) ++I; assert(!I->isInsideBundle() && "First non-phi MI cannot be inside a bundle!"); retur...

Please see the attached patch. There was one more line which was calling isInsideBundle without any check. On Thu, Oct 25, 2012 at 7:08 PM, Jakob Stoklund Olesen <stoklund at 2pi.dk>wrote: > > On Oct 25, 2012, at 7:01 PM, Akira Hatanaka <ahatanak at gmail.com> wrote: > > Is it safe or legal to call isInsideBundle even when I == E? > > > No, neither....

...ated to MachineBasicBlock::iterator. I don't have any test cases that reproduce on an X86 machine the problems that this patch fixes (these bugs were found when make check was run on a mips board). Please review. The first part just ensures that iterator I is not instr_end() before it invokes isInsideBundle(). The second part changes the signature of spillAll to avoid the conversion from MachineBasicBlock::iterator to MachineInstr* and back to MachineBasicBlock::iterator. Here is the backtrace: (gdb) bt #0 0x2ad46fb8 in raise () from /lib/libc.so.6 #1 0x2ad4c178 in abort () from /lib/libc.so.6 #2 0...

On Oct 25, 2012, at 7:01 PM, Akira Hatanaka <ahatanak at gmail.com> wrote: > Is it safe or legal to call isInsideBundle even when I == E? No, neither. -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20121025/cb0bdec9/attachment.html>

...during postRA passes only. > > VLIWPacketizer calls finalizeBundle explicitly because it's running after regalloc. > > We do not want to see any Bundle instructions prior to regalloc. So a preRA scheduler should not call finalizeBundles. It can create bundles simply by setting the isInsideBundle flag on MachineInstrs. If you allow internal register dependencies you would also need to set isInternalRead on those MachineOperands. > Thanks, this information is really helpful. One question, though: If preRA bundles can't have Bundle instructions, then how does the register allocator...

...we rely on for now during postRA passes only. VLIWPacketizer calls finalizeBundle explicitly because it's running after regalloc. We do not want to see any Bundle instructions prior to regalloc. So a preRA scheduler should not call finalizeBundles. It can create bundles simply by setting the isInsideBundle flag on MachineInstrs. If you allow internal register dependencies you would also need to set isInternalRead on those MachineOperands. -Andy

On Thu, Mar 29, 2012 at 02:57:27PM -0500, Sergei Larin wrote: > Tom, > > I do not have your call stack, but packetizer calls > ScheduleDAGInstrs::buildSchedGraph to create dependency model. If this is > the first time you use the new MI sched infrastructure (like your target has > not implemented misched yet) there might be some work needed to implement > couple target

...an instruction within a bundle by calling eraseFromParent(). It seems that in order to erase the MI, a bundle iterator is created but it's forbidden if the MI is not the bundle's header. The attached patch fix it. As a test case, call eraseFromParent() on a machine instruction with its isInsideBundle flag activated. Ivan -------------- next part -------------- A non-text attachment was scrubbed... Name: MIeraseFromParent.patch Type: text/x-patch Size: 334 bytes Desc: not available URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20120603/5fff692c/attachment.bin>

...n.cpp (revision 211103) +++ lib/CodeGen/TailDuplication.cpp (working copy) @@ -453,6 +453,11 @@ } } PredBB->insert(PredBB->instr_end(), NewMI); + + /// If there is bundled instruction in TailBB, + /// make bundled instruction in PredBB. + if (MI->isBundled() && MI->isInsideBundle()) + NewMI->bundleWithPred(); } /// UpdateSuccessorsPHIs - After FromBB is tail duplicated into its predecessor

...ort/ErrorHandling.h" > +#include "llvm/Support/Format.h" > +#include <algorithm> > > using namespace llvm; > > @@ -69,10 +74,7 @@ > MachineBasicBlock::const_instr_iterator I = MI; > ++I; > while (I != MBB->end() && I->isInsideBundle()) { > - MCInst MCBundleInst; > - const MachineInstr *BundledInst = I; > - MCInstLowering.lower(BundledInst, MCBundleInst); > - OutStreamer.EmitInstruction(MCBundleInst); > + EmitInstruction(I); > ++I; > } > } else { > @@ -79,5 +81...

Hi, This patch adds R600/SI disassembly text to compiled object files, when a code dump is requested, to assist debugging in Mesa clients. Here's an example of the output in a Mesa client with a corresponding patch and RADEON_DUMP_SHADERS set: Shader Disassembly: S_WQM_B64 EXEC, EXEC ; BEFE0A7E S_MOV_B32 M0, SGPR6 ; BEFC0306

My 2c... Even though I understand it might be way off in the future, but we are talking about long term plans here anyway. Also as a VLIW backend maintainer, I just have to say it :) - We do need to have a way to assign bundles much earlier than we do now. And it needs to be intertwined with scheduling (Bundler currently reuses a good chunk of scheduler infrastructure). It is also obvious

...nst MachineInstr*> BundleMIs; >> + >> + const MachineBasicBlock *MBB = MI->getParent(); >> + MachineBasicBlock::const_instr_iterator MII = MI; >> + ++MII; >> + unsigned int IgnoreCount = 0; >> + while (MII != MBB->end()&& MII->isInsideBundle()) { >> + const MachineInstr *MInst = MII; >> + if (MInst->getOpcode() == TargetOpcode::DBG_VALUE || >> + MInst->getOpcode() == TargetOpcode::IMPLICIT_DEF) { >> + IgnoreCount++; >> + ++MII; >> + continue; >&...