search for: iself_abi

...nd has the unfortunate habit of saying "if !darwin" "if > !cygwin" etc. Most of the changes you've made are actually ABI related > changes, not OS-specific changes. As such, I'd prefer it if you added > two methods to PPCSubtarget: isMachoABI() and isELF_ABI() (or whatever > is the right name of the ABI that linux uses) and use those instead. > Well all of the changes are ABI related. In fact, could you give me an example of what is os-specific and not abi-specific? I'm not sure. > 3. Please split up the patch into independent chunk...

.... The X86 backend has the unfortunate habit of saying "if !darwin" "if !cygwin" etc. Most of the changes you've made are actually ABI related changes, not OS-specific changes. As such, I'd prefer it if you added two methods to PPCSubtarget: isMachoABI() and isELF_ABI() (or whatever is the right name of the ABI that linux uses) and use those instead. 3. Please split up the patch into independent chunks for easier review. This will make it much more likely that your pieces will be applied in a timely fashion :). This will also let you get pieces in...

...nfortunate habit of saying "if !darwin" "if >> !cygwin" etc. Most of the changes you've made are actually ABI related >> changes, not OS-specific changes. As such, I'd prefer it if you added >> two methods to PPCSubtarget: isMachoABI() and isELF_ABI() (or whatever >> is the right name of the ABI that linux uses) and use those instead. >> > Well all of the changes are ABI related. In fact, could you give me an > example of what is os-specific and not abi-specific? I'm not sure. Most of the things you are doing are ABI...

Hi everyone, I have almost completed the implementation of a linux/ppc backend in llvm. There were a few things to modify in lib/Target/PowerPC with a lot of "if (!isDarwin)". There are some places where I need help before saying the port is complete. I attached the diff file as a reference 1) In order to generate a creqv instruction before a vararg call, I created a new