Displaying 6 results from an estimated 6 matches for "iscsi_sess_ida".
2015 Sep 17
2
DEFINE_IDA causing memory leaks? (was Re: [PATCH 1/2] virtio: fix memory leak of virtio ida cache layers)
...gistered.
>
> Fix this by invoking ida_destroy() in the virtio core module
> exit.
>
> Cc: "Michael S. Tsirkin" <mst at redhat.com>
> Signed-off-by: Suman Anna <s-anna at ti.com>
Interesting.
Will the same apply to e.g. sd_index_ida in drivers/scsi/sd.c
or iscsi_sess_ida in drivers/scsi/scsi_transport_iscsi.c?
If no, why not?
One doesn't generally expect to have to free global variables.
Maybe we should forbid DEFINE_IDA in modules?
James, could you comment on this please?
> ---
> drivers/virtio/virtio.c | 1 +
> 1 file changed, 1 insertion(+)
>...
2015 Sep 17
2
DEFINE_IDA causing memory leaks? (was Re: [PATCH 1/2] virtio: fix memory leak of virtio ida cache layers)
...gistered.
>
> Fix this by invoking ida_destroy() in the virtio core module
> exit.
>
> Cc: "Michael S. Tsirkin" <mst at redhat.com>
> Signed-off-by: Suman Anna <s-anna at ti.com>
Interesting.
Will the same apply to e.g. sd_index_ida in drivers/scsi/sd.c
or iscsi_sess_ida in drivers/scsi/scsi_transport_iscsi.c?
If no, why not?
One doesn't generally expect to have to free global variables.
Maybe we should forbid DEFINE_IDA in modules?
James, could you comment on this please?
> ---
> drivers/virtio/virtio.c | 1 +
> 1 file changed, 1 insertion(+)
>...
2015 Sep 17
7
[PATCH 0/2] Fix memory leaks in virtio & remoteproc cores
Hi,
The following patches fix couple of memory leaks in the virtio and
remoteproc cores when using these as modules, and going through a
cycle of insmod and rmmod with at least a device registered with
the corresponding cores in between. I ran into this on our downstream
product kernels on both 3.14 and 4.1 based kernels, and should apply
to the latest kernel as well.
Patches can be picked up
2015 Sep 17
7
[PATCH 0/2] Fix memory leaks in virtio & remoteproc cores
Hi,
The following patches fix couple of memory leaks in the virtio and
remoteproc cores when using these as modules, and going through a
cycle of insmod and rmmod with at least a device registered with
the corresponding cores in between. I ran into this on our downstream
product kernels on both 3.14 and 4.1 based kernels, and should apply
to the latest kernel as well.
Patches can be picked up
2015 Sep 17
0
DEFINE_IDA causing memory leaks? (was Re: [PATCH 1/2] virtio: fix memory leak of virtio ida cache layers)
...voking ida_destroy() in the virtio core module
>> exit.
>>
>> Cc: "Michael S. Tsirkin" <mst at redhat.com>
>> Signed-off-by: Suman Anna <s-anna at ti.com>
>
> Interesting.
> Will the same apply to e.g. sd_index_ida in drivers/scsi/sd.c
> or iscsi_sess_ida in drivers/scsi/scsi_transport_iscsi.c?
>
> If no, why not?
>
> One doesn't generally expect to have to free global variables.
> Maybe we should forbid DEFINE_IDA in modules?
>
> James, could you comment on this please?
>
Well, looking at the code 'ida_destroy...
2015 Sep 17
0
DEFINE_IDA causing memory leaks? (was Re: [PATCH 1/2] virtio: fix memory leak of virtio ida cache layers)
...e
> > > exit.
> > >
> > > Cc: "Michael S. Tsirkin" <mst at redhat.com>
> > > Signed-off-by: Suman Anna <s-anna at ti.com>
> >
> > Interesting.
> > Will the same apply to e.g. sd_index_ida in drivers/scsi/sd.c
> > or iscsi_sess_ida in drivers/scsi/scsi_transport_iscsi.c?
> >
> > If no, why not?
> >
> > One doesn't generally expect to have to free global variables.
> > Maybe we should forbid DEFINE_IDA in modules?
> >
> > James, could you comment on this please?
>
> ida i...