search for: isassoci

Hi Devs, I am looking at the bug https://bugs.llvm.org/show_bug.cgi?id=43953 and found that following piece of ir %arrayidx = getelementptr inbounds float, float* %Vec0, i64 %idxprom %0 = load float, float* %arrayidx, align 4, !tbaa !2 %arrayidx2 = getelementptr inbounds float, float* %Vec1, i64 %idxprom %1 = load float, float* %arrayidx2, align 4, !tbaa !2 %sub = fsub fast float %0, %1

...Inst>(this); >>> } >>> >>> +bool Instruction::mayReturn() const { >>> + if (const CallInst *CI = dyn_cast<CallInst>(this)) >>> + return !CI->doesNotReturn(); >>> + return true; >>> +} >>> + >>> /// isAssociative - Return true if the instruction is associative: >>> /// >>> /// Associative operators satisfy: x op (y op z) === (x op y) op z >>> >>> Added: llvm/trunk/test/Transforms/FunctionAttrs/noreturn.ll >>> URL: http://llvm.org/viewvc/llvm-project/l...

Hi Sanjay, Thanks, I saw this flag and it's definitely should be considered, but it appeared to me to be static characteristic of target platform. I'm not sure how appropriate it would be to change its value from a front-end. It says "Has", while optional flag would rather say "Uses" meaning that implementation cares about floating point exceptions. Regards, Sergey

...HonorFPExceptions)); } return ConstantVector::get(Result); @@ -1174,15 +1192,17 @@ Constant *llvm::ConstantFoldBinaryInstruction(unsigned Opcode, // Given ((a + b) + c), if (b + c) folds to something interesting, return // (a + (b + c)). if (Instruction::isAssociative(Opcode) && CE1->getOpcode() == Opcode) { - Constant *T = ConstantExpr::get(Opcode, CE1->getOperand(1), C2); + Constant *T = ConstantExpr::get(Opcode, CE1->getOperand(1), C2, 0, + nullptr, HonorFPExceptions); if (!isa<Con...