search for: isa_and_nonnull

Hi All: Just wanted to wind this up and summarize the results. Although there were a few no votes, it looks like there's a consensus for adding a `isa_and_nonnull` type operator. While there were some who preferred `isa_nonnull`, it wasn't overwhelming, and since `isa_and_nonnull` is already committed, I'm going to leave it as `isa_and_nonnull` for the time being. Thanks for all the comments. don On Thu, Apr 11, 2019 at 7:49 PM Don Hinton <hi...

On Mon, Apr 29, 2019, 02:37 David Chisnall via llvm-dev < llvm-dev at lists.llvm.org> wrote: > On 22/04/2019 15:15, Don Hinton via llvm-dev wrote: > > Although there were a few no votes, it looks like there's a consensus > > for adding a `isa_and_nonnull` type operator. While there were some who > > preferred `isa_nonnull`, it wasn't overwhelming, and since > > `isa_and_nonnull` is already committed, I'm going to leave it as > > `isa_and_nonnull` for the time being. > > Maybe I missed something, but it looked to me...

...implementation could be a simple wrapper around isa<>, and while the IR produced is only slightly more efficient, the elimination of an extra > call could be worthwhile. > > > > I’d love to see this, I agree with downstream comments though that this name will be confusing. isa_and_nonnull<>. ? > > tbh, I don't think the proposed name will be all that confusing -- > > I am with David on this, this sounds like misleading naming to me, I would expect true on null value when reading : if (isa_or_null<T>(var)) > > we're used to _or_null() returnin...

...r 29, 2019, 02:37 David Chisnall via llvm-dev < > llvm-dev at lists.llvm.org> wrote: > >> > >> On 22/04/2019 15:15, Don Hinton via llvm-dev wrote: > >> > Although there were a few no votes, it looks like there's a consensus > >> > for adding a `isa_and_nonnull` type operator. While there were some > who > >> > preferred `isa_nonnull`, it wasn't overwhelming, and since > >> > `isa_and_nonnull` is already committed, I'm going to leave it as > >> > `isa_and_nonnull` for the time being. > >> > >&...

...> > > The implementation could be a simple wrapper around isa<>, and while the IR produced is only slightly more efficient, the elimination of an extra call could be worthwhile. > > I’d love to see this, I agree with downstream comments though that this name will be confusing. isa_and_nonnull<>. ? tbh, I don't think the proposed name will be all that confusing -- we're used to _or_null() returning "the right thing" when given null. isa_and_nonnull<> is a bit of a weird name for me, but I could probably live with it. We could spell it nonnull_and_isa<&gt...

...simple wrapper around isa<>, and while >> the IR produced is only slightly more efficient, the elimination of an >> extra call could be worthwhile. >> > >> > I’d love to see this, I agree with downstream comments though that this >> name will be confusing. isa_and_nonnull<>. ? >> >> tbh, I don't think the proposed name will be all that confusing -- >> > > I am with David on this, this sounds like misleading naming to me, I would > expect true on null value when reading : if (isa_or_null<T>(var)) > > we're used to...

...gt;>>> while the IR produced is only slightly more efficient, the elimination of >>>> an extra call could be worthwhile. >>>> > >>>> > I’d love to see this, I agree with downstream comments though that >>>> this name will be confusing. isa_and_nonnull<>. ? >>>> >>>> tbh, I don't think the proposed name will be all that confusing -- >>>> >>> >>> I am with David on this, this sounds like misleading naming to me, I >>> would expect true on null value when reading : if (isa_or_...

...> > > The implementation could be a simple wrapper around isa<>, and while the IR produced is only slightly more efficient, the elimination of an extra call could be worthwhile. > > I’d love to see this, I agree with downstream comments though that this name will be confusing. isa_and_nonnull<>. ? tbh, I don't think the proposed name will be all that confusing -- I am with David on this, this sounds like misleading naming to me, I would expect true on null value when reading : if (isa_or_null<T>(var)) we're used to _or_null() returning "the right thing"...

I'd like to propose adding `isa_or_null<>` to replace the following usage pattern that's relatively common in conditionals: var && isa<T>(var) =>> isa_or_null<T>(var) And in particular when `var` is a method call which might be expensive, e.g.: X->foo() && isa<T>(X->foo()) =>> isa_or_null<T>(X->foo()) The

...> > > The implementation could be a simple wrapper around isa<>, and while the IR produced is only slightly more efficient, the elimination of an extra call could be worthwhile. > > I’d love to see this, I agree with downstream comments though that this name will be confusing. isa_and_nonnull<>. ? tbh, I don't think the proposed name will be all that confusing -- we're used to _or_null() returning "the right thing" when given null. isa_and_nonnull<> is a bit of a weird name for me, but I could probably live with it. We could spell it nonnull_and_isa<&gt...