search for: is_whole_device

...stfs: trace: umount_all = 0 libguestfs: trace: vfs_type "/dev/sda2" libguestfs: trace: vfs_type = "ntfs" libguestfs: trace: internal_parse_mountable "/dev/sda2" libguestfs: trace: internal_parse_mountable = <struct guestfs_internal_mountable *> libguestfs: trace: is_whole_device "/dev/sda2" libguestfs: trace: is_whole_device = 0 libguestfs: trace: mount_ro "/dev/sda2" "/" libguestfs: trace: mount_ro = -1 (error) libguestfs: trace: vfs_type "/dev/sda3" libguestfs: trace: vfs_type = "" libguestfs: trace: internal_parse_mounta...

...++++++++++++ src/MAX_PROC_NR | 2 +- 3 files changed, 45 insertions(+), 1 deletion(-) diff --git a/daemon/devsparts.c b/daemon/devsparts.c index 9a2ce9a..1939f2a 100644 --- a/daemon/devsparts.c +++ b/daemon/devsparts.c @@ -245,6 +245,33 @@ do_part_to_partnum (const char *part) } int +do_is_whole_device (const char *device) +{ + #define PREFIX "/dev/" + + /* Shouldn't be possible because we already sanity checked our input */ + if (!STRPREFIX (device, PREFIX)) return 0; + + CLEANUP_FREE char *devpath = NULL; + if (asprintf (&devpath, "/sys/block/%s/device", +...

...0 > libguestfs: trace: vfs_type "/dev/sda2" > libguestfs: trace: vfs_type = "ntfs" > libguestfs: trace: internal_parse_mountable "/dev/sda2" > libguestfs: trace: internal_parse_mountable = <struct guestfs_internal_mountable *> > libguestfs: trace: is_whole_device "/dev/sda2" > libguestfs: trace: is_whole_device = 0 > libguestfs: trace: mount_ro "/dev/sda2" "/" > libguestfs: trace: mount_ro = -1 (error) > libguestfs: trace: vfs_type "/dev/sda3" > libguestfs: trace: vfs_type = "" > libguestfs...

...t; libguestfs: trace: vfs_type "/dev/sda2" > libguestfs: trace: vfs_type = "ntfs" > libguestfs: trace: internal_parse_mountable "/dev/sda2" > libguestfs: trace: internal_parse_mountable = <struct > guestfs_internal_mountable *> > libguestfs: trace: is_whole_device "/dev/sda2" > libguestfs: trace: is_whole_device = 0 > libguestfs: trace: mount_ro "/dev/sda2" "/" > libguestfs: trace: mount_ro = -1 (error) > libguestfs: trace: vfs_type "/dev/sda3" > libguestfs: trace: vfs_type = "" > libguestfs...

Hi, Thank you Richard for your work, but I have also like Jeff Forbes a new issue : libguestfs: trace: hivex_node_set_value = 0 libguestfs: trace: upload "/usr/share/virtio-win/drivers/amd64/Win2008/viostor.sys" "/Windows/Drivers/VirtIO" libguestfs: trace: upload = -1 (error) libguestfs: trace: hivex_close libguestfs: trace: hivex_close = 0 virt-v2v: error: libguestfs error:

The reimplemented APIs are: * list_devices * list_partitions * part_to_dev * part_to_partnum * is_whole_device --- daemon/Makefile.am | 2 + daemon/daemon.h | 3 - daemon/devsparts.c | 257 ---------------------------------------------- daemon/devsparts.ml | 109 ++++++++++++++++++++ daemon/devsparts.mli | 25 +++++ daemon/guestfsd.c | 75 -------------- dae...

...ype "/dev/sda1" libguestfs: trace: vfs_type = "ext4" libguestfs: trace: internal_parse_mountable "/dev/sda1" libguestfs: trace: internal_parse_mountable = <struct guestfs_internal_mountable = im_type: 0, im_device: /dev/sda1, im_volume: , > libguestfs: trace: is_whole_device "/dev/sda1" libguestfs: trace: is_whole_device = 0 libguestfs: trace: mount_ro "/dev/sda1" "/" libguestfs: trace: mount_ro = 0 libguestfs: trace: part_to_dev "/dev/sda1" libguestfs: trace: part_to_dev = "/dev/sda" libguestfs: trace: device_ind...

...quot; > libguestfs: trace: vfs_type = "ext4" > libguestfs: trace: internal_parse_mountable "/dev/sda1" > libguestfs: trace: internal_parse_mountable = <struct guestfs_internal_mountable = im_type: 0, im_device: /dev/sda1, im_volume: , > > libguestfs: trace: is_whole_device "/dev/sda1" > libguestfs: trace: is_whole_device = 0 > libguestfs: trace: mount_ro "/dev/sda1" "/" > libguestfs: trace: mount_ro = 0 > libguestfs: trace: part_to_dev "/dev/sda1" > libguestfs: trace: part_to_dev = "/dev/sda" >...

...l be skipping over holes. You might want to attach strace to qemu-img and see if it is making system calls. > If the backend is set to libvirt > It hangs inspecting the overlay ... > libguestfs: trace: v2v: mount_ro "/dev/sda1" "/" > guestfsd: main_loop: proc 395 (is_whole_device) took 0.09 seconds > guestfsd: main_loop: new request, len 0x40 > commandrvf: stdout=n stderr=y flags=0x0 > commandrvf: udevadm --debug settle -E /dev/sda1 > calling: settle > commandrvf: stdout=n stderr=y flags=0x0 > commandrvf: mount -o ro /dev/sda1 /sysroot/ It's pretty un...

...rtitions in diff --git a/daemon/devsparts.mli b/daemon/devsparts.mli index 7b669c2..d3224a1 100644 --- a/daemon/devsparts.mli +++ b/daemon/devsparts.mli @@ -21,5 +21,6 @@ val list_partitions : unit -> string list val part_to_dev : string -> string val part_to_partnum : string -> int val is_whole_device : string -> bool +val is_partitioned_device : string -> bool val nr_devices : unit -> int val device_index : string -> int -- 2.9.5

...t; libguestfs: trace: vfs_type = "ext4" >> libguestfs: trace: internal_parse_mountable "/dev/sda1" >> libguestfs: trace: internal_parse_mountable = <struct guestfs_internal_mountable = im_type: 0, im_device: /dev/sda1, im_volume: , > >> libguestfs: trace: is_whole_device "/dev/sda1" >> libguestfs: trace: is_whole_device = 0 >> libguestfs: trace: mount_ro "/dev/sda1" "/" >> libguestfs: trace: mount_ro = 0 >> libguestfs: trace: part_to_dev "/dev/sda1" >> libguestfs: trace: part_to_dev = "/dev/...

Although the commit message ties this to https://bugzilla.redhat.com/1804207, in fact I believe this commit could be applied independently. It's a simple optimization. Rich.

...rtitions in diff --git a/daemon/devsparts.mli b/daemon/devsparts.mli index 7b669c2..d3224a1 100644 --- a/daemon/devsparts.mli +++ b/daemon/devsparts.mli @@ -21,5 +21,6 @@ val list_partitions : unit -> string list val part_to_dev : string -> string val part_to_partnum : string -> int val is_whole_device : string -> bool +val is_partitioned_device : string -> bool val nr_devices : unit -> int val device_index : string -> int diff --git a/daemon/listfs.ml b/daemon/listfs.ml index 370ffb4..1349ae0 100644 --- a/daemon/listfs.ml +++ b/daemon/listfs.ml @@ -25,39 +25,18 @@ let rec list_file...

...ev/sda1" guestfsd: main_loop: proc 198 (vfs_type) took 0.01 seconds guestfsd: main_loop: new request, len 0x38 guestfsd: main_loop: proc 396 (internal_parse_mountable) took 0.00 seconds libguestfs: trace: internal_parse_mountable = <struct guestfs_internal_mountable *> libguestfs: trace: is_whole_device "/dev/sda1" guestfsd: main_loop: new request, len 0x38 guestfsd: main_loop: proc 395 (is_whole_device) tolibguestfs: trace: is_whole_device = 0 libguestfs: trace: mount_ro "/dev/sda1" "/" ok 0.00 seconds guestfsd: main_loop: new request, len 0x40 mount -o ro /dev/sda1...

...tfsd: main_loop: new request, len 0x38 commandrvf: stdout=n stderr=y flags=0x0 commandrvf: udevadm --debug settle -E /dev/sda1 calling: settle libguestfs: trace: internal_parse_mountable = <struct guestfs_internal_mountable = im_type: 0, im_device: /dev/sda1, im_volume: , > libguestfs: trace: is_whole_device "/dev/sda1" guestfsd: main_loop: proc 396 (internal_parse_mountable) took 0.01 seconds guestfsd: main_loop: new request, len 0x38 commandrvf: stdout=n stderr=y flags=0x0 commandrvf: udevadm --debug settle -E /dev/sda1 calling: settle guestfsd: main_loop: proc 395 (is_whole_device) took 0....

Greetings, I am suffering of several weird errors which show randomly and make me suspect some concurrency issue. Libguestfs version is 1.28.1, linux kernel 3.16, libvirt 1.2.9 and qemu 2.1. What I'm trying to do is comparing the disk state at two different point of a guest execution. Disk snapshots are taken through libvirt in different moments (I am aware of caching issue), from such

This is the (incomplete) patch which reimplements inspection APIs in the daemon. All ‘XXX’s in this patch indicate areas which are not yet implemented or need further work. Rich.

Initial discussion is here: https://www.redhat.com/archives/libguestfs/2018-January/msg00188.html. v2 was posted here: https://www.redhat.com/archives/libguestfs/2018-January/msg00246.html. v3 comparing to v2 is just a rebase with slightly changed commits comments.

...(ext4) libguestfs: trace: internal_parse_mountable "/dev/vda1" guestfsd: main_loop: new request, len 0x38 guestfsd: main_loop: proc 396 (internal_parse_mountable) took 0.00 seconds libguestfs: trace: internal_parse_mountable = <struct guestfs_internal_mountable *> libguestfs: trace: is_whole_device "/dev/vda1" guestfsd: main_loop: new request, len 0x38 guestfsd: main_loop: proc 395 (is_whole_device) took 0.00 seconds libguestfs: trace: is_whole_device = 0 libguestfs: trace: mount_ro "/dev/vda1" "/" guestfsd: main_loop: new request, len 0x40 mount -o ro /dev/vda1...

Instead of parsing 'parted' output OCaml implementation relies on the following facts: 1. The function is applicable for MBR partitions only (as noted in documentation and as function name suggests). 2. An attempt to call the function for non-MBR partition fails with "part_get_mbr_part_type can only be used on MBR Partitions" error and NULL is returned. 3. MBR partition table