Displaying 5 results from an estimated 5 matches for "is_transform_applicable".
2020 Jun 22
7
Codifying our Brace rules-
...le-line* statement. I count comments, that are on their
> own line as statement(s).
+1 for this. I think braces around single-line statements can be
allowed, but they really shouldn't be mandated, and that's been my
personal policy for reviews. In particular,
if (!is_transform_applicable) {
return {};
}
is very aggravating clutter.
Braces should be required around multi-line statements. Note:
BAD:
for (...)
for (...)
single_line_statement;
GOOD:
for (...) {
for (...)
single_line_statement;
}...
2020 Jun 16
3
Codifying our Brace rules-
My 2 pennies is braces add unnecessary clutter and impair readability when
used on a *single-line* statement. I count comments, that are on their
own line as statement(s).
For example:
BAD:
if (cond)
// Comment
foo();
GOOD:
if (cond) {
// Comment
foo();
}
BAD:
if (cond) {
foo(); // Comment
}
GOOD:
if (cond)
foo(); // Comment
BAD:
if (cond)
for(;;)
foo()
GOOD:
if (cond)
2020 Jun 23
2
Codifying our Brace rules-
...on their
>>> own line as statement(s).
>> +1 for this. I think braces around single-line statements can be
>> allowed, but they really shouldn't be mandated, and that's been my
>> personal policy for reviews. In particular,
>>
>> if (!is_transform_applicable) {
>> return {};
>> }
>>
>> is very aggravating clutter.
>>
>> Braces should be required around multi-line statements. Note:
>>
>> BAD:
>> for (...)
>> for (...)
>> single_line_statem...
2020 Jun 22
4
Codifying our Brace rules-
...eir
>> own line as statement(s).
>
> +1 for this. I think braces around single-line statements can be
> allowed, but they really shouldn't be mandated, and that's been my
> personal policy for reviews. In particular,
>
> if (!is_transform_applicable) {
> return {};
> }
>
> is very aggravating clutter.
>
> Braces should be required around multi-line statements. Note:
>
> BAD:
> for (...)
> for (...)
> single_line_statement;...
2020 Jun 24
4
Codifying our Brace rules-
...nt(s).
> >>> +1 for this. I think braces around single-line statements can be
> >>> allowed, but they really shouldn't be mandated, and that's been my
> >>> personal policy for reviews. In particular,
> >>>
> >>> if (!is_transform_applicable) {
> >>> return {};
> >>> }
> >>>
> >>> is very aggravating clutter.
> >>>
> >>> Braces should be required around multi-line statements. Note:
> >>>
> >>> BAD:
> >>>...