Displaying 6 results from an estimated 6 matches for "is_seeking".
2014 Dec 11
2
Two new CVEs against FLAC
Erik de Castro Lopo wrote:
> I think I have an alternative fix for the CVE which should not break
> seeking. I'm working on getting an copy of the file with which to test.
Patch applied and pushed.
commit b4b2910bdca010808ccf2799f55562fa91f4347b
Author: Erik de Castro Lopo <erikd at mega-nerd.com>
Date: Wed Dec 10 18:54:16 2014 +1100
2014 Dec 11
4
Two new CVEs against FLAC
...t. The bogus header
might trigger the sanity checks that were made to fail by the
CVEs, thereby the seek fails.
A fix for this might be not decoding a frame fully, (by making
the /*do_full_decode=*/true in
FLAC__stream_decoder_process_single conditionally dependent on
decoder->private_->is_seeking) but instead implement more sanity
checks. For example, it could be checked whether the sample
rate, blocksize, number of channels and sample size in the frame
header match with those in the stream info, and whether the
sample or framenumber is in a sane range. This gives less
security than fu...
2006 Oct 28
3
better seeking
...if(decoder->private_->seek_callback(decoder, (FLAC__uint64)pos, decoder->private_->client_data) != FLAC__STREAM_DECODER_SEEK_STATUS_OK) {
decoder->protected_->state = FLAC__STREAM_DECODER_SEEK_ERROR;
return false;
@@ -3113,45 +3049,43 @@
if(!decoder->private_->is_seeking) {
break;
}
- else { /* we need to narrow the search */
- const FLAC__uint64 this_frame_sample = decoder->private_->last_frame.header.number.sample_number;
- FLAC__ASSERT(decoder->private_->last_frame.header.number_type == FLAC__FRAME_NUMBER_TYPE_SAMPLE_NUMBER);
- if(this_...
2006 Nov 03
2
better seeking
...if(decoder->private_->seek_callback(decoder, (FLAC__uint64)pos, decoder->private_->client_data) != FLAC__STREAM_DECODER_SEEK_STATUS_OK) {
decoder->protected_->state = FLAC__STREAM_DECODER_SEEK_ERROR;
return false;
@@ -3113,44 +3048,50 @@
if(!decoder->private_->is_seeking) {
break;
}
- else { /* we need to narrow the search */
- const FLAC__uint64 this_frame_sample = decoder->private_->last_frame.header.number.sample_number;
- FLAC__ASSERT(decoder->private_->last_frame.header.number_type == FLAC__FRAME_NUMBER_TYPE_SAMPLE_NUMBER);
- if(this_...
2012 May 05
5
[PATCH] Optionally, allow distros to use openssl for MD5 verification
...d..f8029dd 100644
--- a/src/libFLAC/stream_decoder.c
+++ b/src/libFLAC/stream_decoder.c
@@ -185,7 +185,7 @@ typedef struct FLAC__StreamDecoderPrivate {
FLAC__bool internal_reset_hack; /* used only during init() so we can call reset to set up the decoder without rewinding the input */
FLAC__bool is_seeking;
FLAC__MD5Context md5context;
- FLAC__byte computed_md5sum[16]; /* this is the sum we computed from the decoded data */
+ FLAC__byte computed_md5sum[EVP_MAX_MD_SIZE]; /* this is the sum we computed from the decoded data */
/* (the rest of these are only used for seeking) */
FLAC__Frame last_f...
2004 Sep 10
2
better seeking
When I was trying to find yesterday's xmms-plugin bug, i have noticed
that seeking in stream without seek-table isn't very good. With
attached patch it is much better.
--
Miroslav Lichvar
-------------- next part --------------
--- src/libFLAC/seekable_stream_decoder.c.orig 2003-02-26 19:41:51.000000000 +0100
+++ src/libFLAC/seekable_stream_decoder.c 2003-07-09 23:49:35.000000000 +0200