search for: is_rpm_lt_4_11

...| _ -> None + ) inspect.i_apps in + match String.nsplit "." ver with + | [major] -> int_of_string major, 0 + | major :: minor :: _ -> int_of_string major, int_of_string minor + | _ -> error (f_"unrecognized RPM version: %s") ver in + let is_rpm_lt_4_11 = + rpm_major < 4 || (rpm_major = 4 && rpm_minor < 11) in let pkg_name = - sprintf "%s-%s-%s" app.G.app2_name - app.G.app2_version app.G.app2_release in - let pkg_name = - if app.G.app2_epoch > 0_l then ( - (* RHEL 3/4 'rpm' do...

...not work. + * + * For example: + * RHEL 6 (rpm 4.8.0): + * $ rpm -q tar-2:1.23-11.el6.x86_64 + * package tar-2:1.23-11.el6.x86_64 is not installed + * Fedora 20 (rpm 4.11.2): + * $ rpm -q tar-2:1.26-30.fc20.x86_64 + * tar-1.26-30.fc20.x86_64 *) + let is_rpm_lt_4_11 () = + let ver = + try + let ver = List.find_map ( + function + | { G.app2_name = name; G.app2_version = version } + when name = "rpm" -> Some version + | _ -> None + ) inspect.i_apps in + if PCRE...

...istro = "rhel" | "centos" | "scientificlinux" | - "oraclelinux" | "redhat-based"; - i_major_version = v } when v < 5 -> true - | _ -> false in - if is_rhel_lt_5 then - pkg_name + let is_rpm_lt_4_11 () = + let ver = List.find_map ( + function + | { G.app2_name = name; G.app2_version = version } + when name = "rpm" -> Some version + | _ -> None + ) inspect.i_apps in + let ver = + if PCRE.matches re_version ver then +...

...e didn't error out in the last case. Something like this seems better to me: let re_rpm_version = PCRE.compile "(\\d+)\\.(\\d+)" ... let ver = if PCRE.matches re_rpm_version ver then (int_of_string (PCRE.sub 1), int_of_string (PCRE.sub 2)) else (0, 0) in let is_rpm_lt_4_11 = ver < (4, 11) in (We already have this sort of code in daemon/inspect_utils.ml, but we can't reuse it). Rich. > + let is_rpm_lt_4_11 = > + rpm_major < 4 || (rpm_major = 4 && rpm_minor < 11) in > let pkg_name = > - sprintf "%s-%s-%s"...

When detecting kernels we have to list the files in the package to find the right /boot/vmlinuz file. In virt-v2v 1.28 we ran: rpm -ql kernel Because multiple kernels can be installed this gave incorrect results, which was reported in RHBZ#1161250 and initially fixed in commit 377bc302f11db3da4263f894c76a7d280fb25dbd. This changed the command to: rpm -ql [epoch:]kernel-version.release

This patch series fixes the way supermin sorts the list of installed packages when resolving a name, picking the right package for the host architecture. Pino Toscano (5): rpm: do not unpack parameters rpm: fix version comparison rpm: query the RPM architecture rpm: fix package sorting (RHBZ#1696822) utils: remove unused 'compare_architecture' function src/librpm-c.c | 10

Hi, this work makes supermin use the rpm library instead of invoking rpm directly. This, together with a needed refactoring of the dependency resolution, should help in make supermin faster on rpm-based systems. Surely the patches will still need polishing, especially for behaviours of newly added stuff, but at least it's a good starting point. Noting that you need rpm-devel on most of rpm