search for: is_ogg

...patch for this is you are interested. Second problem is that I get a compile error when FLAC__HAS_OGG is 0 in src/flac/decode.c: decode.c:393: error: 'options' undeclared (first use in this function) The code in question is this: #if FLAC__HAS_OGG if(decoder_session->is_ogg) { /* Some code here. */ } else #else (void)decode_options; #endif { /* More code. */ } The problem here is that conditional compiles can hide bugs. The code above re-written to turn a conditional compile into an always compi...

...free(newbuf); } else free(tobuf); diff --git a/src/test_libFLAC++/encoders.cpp b/src/test_libFLAC++/encoders.cpp index 277e129..e328a53 100644 --- a/src/test_libFLAC++/encoders.cpp +++ b/src/test_libFLAC++/encoders.cpp @@ -438,7 +438,7 @@ static bool test_stream_encoder(Layer layer, bool is_ogg) printf("testing get_max_lpc_order()... "); if(encoder->get_max_lpc_order() != 0) { - printf("FAILED, expected %u, got %u\n", 0, encoder->get_max_lpc_order()); + printf("FAILED, expected %d, got %u\n", 0, encoder->get_max_lpc_order()); return false;...

...B already reduces the problem tremendously. -------------- next part -------------- diff --git a/src/flac/decode.c b/src/flac/decode.c index 5e5e17a..9e9405c 100644 --- a/src/flac/decode.c +++ b/src/flac/decode.c @@ -251,6 +251,7 @@ FLAC__bool DecoderSession_construct(DecoderSession *d, FLAC__bool is_ogg, FLAC__ DecoderSession_destroy(d, /*error_occurred=*/true); return false; } + setvbuf(d->fout, NULL, _IOFBF, 10*1024*1024); /* 10MB output buffer to help reduce disk fragmentation */ } }

...d problem is that I get a compile error when FLAC__HAS_OGG is 0 > in src/flac/decode.c: > > decode.c:393: error: 'options' undeclared (first use in this > function) > > The code in question is this: > > #if FLAC__HAS_OGG > if(decoder_session->is_ogg) { > /* Some code here. */ > } > else > #else > (void)decode_options; > #endif > { > /* More code. */ > } yes, this is fixed in cvs. actually I'll probably be doing a release soon and I'd be...

...------------ next part -------------- diff --git a/src/flac/decode.c b/src/flac/decode.c index 5e5e17a..90e0b1a 100644 --- a/src/flac/decode.c +++ b/src/flac/decode.c @@ -101,7 +101,7 @@ static FLAC__bool is_big_endian_host_; static FLAC__bool DecoderSession_construct(DecoderSession *d, FLAC__bool is_ogg, FLAC__bool use_first_serial_number, long serial_number, FileFormat format, FLAC__bool treat_warnings_as_errors, FLAC__bool continue_through_decode_errors, FLAC__bool channel_map_none, replaygain_synthesis_spec_t replaygain_synthesis_spec, FLAC__bool analysis_mode, analysis_options aopts, utils__Sk...

...------------ next part -------------- diff --git a/src/flac/decode.c b/src/flac/decode.c index 5e5e17a..7705107 100644 --- a/src/flac/decode.c +++ b/src/flac/decode.c @@ -101,7 +101,7 @@ static FLAC__bool is_big_endian_host_; static FLAC__bool DecoderSession_construct(DecoderSession *d, FLAC__bool is_ogg, FLAC__bool use_first_serial_number, long serial_number, FileFormat format, FLAC__bool treat_warnings_as_errors, FLAC__bool continue_through_decode_errors, FLAC__bool channel_map_none, replaygain_synthesis_spec_t replaygain_synthesis_spec, FLAC__bool analysis_mode, analysis_options aopts, utils__Sk...

..., outfilename=0x0, analysis_mode=0, aopts= {do_residual_text = 0, do_residual_gnuplot = 1}, options= {common = {continue_through_decode_errors = 0, replaygain_synthesis_spec = {apply = 0, use_album_gain = 1, limiter = RGSS_LIMIT__HARD, noise_shaping = NOISE_SHAPING_LOW, preamp = 0}, is_ogg = 0, use_first_serial_number = 1, serial_number = 0, skip_specification = {is_relative = 0, value_is_samples = 1, value = {seconds = 0, samples = 0}}, until_specification = {is_relative = 0, value_is_samples = 1, value = {seconds = 0, samples = 0}}, has_cue_specification = 0, cue_specification = {...

...Attached is a fixed and improved version. -------------- next part -------------- diff --git a/src/flac/decode.c b/src/flac/decode.c index 5e5e17a..ed7eff8 100644 --- a/src/flac/decode.c +++ b/src/flac/decode.c @@ -263,6 +263,23 @@ FLAC__bool DecoderSession_construct(DecoderSession *d, FLAC__bool is_ogg, FLAC__ void DecoderSession_destroy(DecoderSession *d, FLAC__bool error_occurred) { if(0 != d->fout && d->fout != stdout) { +#ifdef _WIN32 + if(!error_occurred) { + FLAC__off_t written_size = ftello(d->fout); + if(written_size > 0) { + HANDLE fh = CreateFile_utf8(d-&...

...FLAC__HAS_OGG is 0 > > in src/flac/decode.c: > > > > decode.c:393: error: 'options' undeclared (first use in this > > function) > > > > The code in question is this: > > > > #if FLAC__HAS_OGG > > if(decoder_session->is_ogg) { > > /* Some code here. */ > > } > > else > > #else > > (void)decode_options; > > #endif > > { > > /* More code. */ > > } > > yes, this is fixed in cvs. actually I...

Can you please wrap the setvbuf in _WIN32 IFDEFs too? Currently memory usage of FLAC decoding is about 1MB, so this patch is increasing memory usage tenfold, also for platforms that do not need this. It is a non-problem on my system anyway. Op 26-09-14 om 10:36 schreef Janne Hyv?rinen: > I made some changes to the previous patch. I don't know why I > originally didn't put the

doing "make check" on flac-1.1.2, I get a segmentation fault ././test_metaflac.sh: line 51: 17370 Segmentation fault flac $* when running this portion of the test/test_metaflac.sh script: (set -x && run_metaflac --preserve-modtime --add-padding=12345 $flacfile) check_exit check_flac <---------------- where the segfault happens All other tests in