search for: is_lv

...t -------------- >From 6280ac9b987c14f89749b4b4fdfec5a647567432 Mon Sep 17 00:00:00 2001 From: Richard Jones <rjones at redhat.com> Date: Fri, 30 Jul 2010 16:32:35 +0100 Subject: [PATCH] New API: is-lv: check if a block device is a logical volume (RHBZ#619793) This adds a new API, guestfs_is_lv (g, device), which returns true iff the named device is an LVM2 logical volume. A sample guestfish session: ><fs> lvs /dev/vg_f13x64/lv_root /dev/vg_f13x64/lv_swap ><fs> list-devices /dev/vda ><fs> list-partitions /dev/vda1 /dev/vda2 ><fs> is-lv /dev/vg_f13x64/...

This patcheset fixes errors in virt-sysprep and virt-sparsify. Here we have a common functionality: is_btrfs_subvolume. Doesn't it make sense to turn it into guestfs API? Also I found an issue. In 'virt-sysprep fs-uuids', the uuids for ALL filesystems are regenerated as many times as many roots are in guest. Is it done intentionally? Maxim Perevedentsev (3): mllib: add checking

Calling guestfs_is_lv on btrfs subvolume throws an error. Here we workaround it by returning 'false' for subvolumes. --- sparsify/utils.ml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/sparsify/utils.ml b/sparsify/utils.ml index 9a49504..8d99db1 100644 --- a/sparsify/utils.ml +++ b/spars...

Calling guestfs_is_lv on btrfs subvolume throws an error. Here we workaround it by taking Mountable instead of Device and returning 'false' for non-device mountables. --- daemon/lvm.c | 6 ++++-- generator/actions.ml | 6 +++--- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/daemon/lvm.c...

...by > RESOLVE_DEVICE macro in stubs.c. That means we will get an error > trying to call blockdev - oriented functions at these devices. > > ========================= > > After grepping "list_filesystems" issues were found in: > - virt-sparsify (in-place and copying): is_lv > - virt-filesystems: blockdev_getsize64 > - virt-cat (inspect_os) treats this as multiboot system and refuses > to proceed > - virt-rescue --suggest suggests all snapshots (maybe this is correct) > - virt-sysprep --operation fs-uuids goes into infinite loop > > [ 144.2] Perfo...

...al variable in mkinitrd, and is therefore extremely nasty + # and applicable only to a particular version of mkinitrd. + if ($desc->{distro} eq 'rhel' && $desc->{major_version} eq '4') { + push(@env, 'root_lvm=1') if ($g->is_lv($desc->{root_device})); + } + + $g->sh(join(' ', @env).' /sbin/mkinitrd '.join(' ', @module_args). + " $initrd $version"); } else { -- 1.7.2

sparsify case: modified guestfs_is_lv mllib: fixed is_btrfs_subvolume Maxim Perevedentsev (3): mllib: add checking for btrfs subvolume lvm: modify guestfs_is_lv to take mountable sysprep: fix btrfs subvolume processing in fs-uuids daemon/lvm.c | 6 ++++-- generator/actions.ml | 6 ++...

virt-sparsify shouldn't die if sparsifying a filesystem that contains read-only LVs. https://bugzilla.redhat.com/show_bug.cgi?id=1185561 I thought about trying to make the LV writable temporarily, but I suspect that if the sysadmin has made the LV read-only, then they probably did it for a reason, so we shouldn't touch it. Rich.

...he filesystem is a read-only LV (RHBZ#1185561). *) +let is_read_only_lv (g : G.guestfs) = + let lvs = Array.to_list (g#lvs_full ()) in + let romap = List.map ( + fun { G.lv_uuid = lv_uuid; lv_attr = lv_attr } -> + lv_uuid, lv_attr.[1] = 'r' + ) lvs in + fun fs -> + if g#is_lv fs then ( + let uuid = g#lvuuid fs in + assoc ~cmp:compare_lvm2_uuids ~default:false uuid romap + ) + else false -- 2.1.0

...85561). *) > +let is_read_only_lv (g : G.guestfs) = > + let lvs = Array.to_list (g#lvs_full ()) in > + let romap = List.map ( > + fun { G.lv_uuid = lv_uuid; lv_attr = lv_attr } -> > + lv_uuid, lv_attr.[1] = 'r' > + ) lvs in > + fun fs -> > + if g#is_lv fs then ( > + let uuid = g#lvuuid fs in > + assoc ~cmp:compare_lvm2_uuids ~default:false uuid romap > + ) > + else false This looks to me that it would go through all the LVs, even RW ones, when is_read_only_lv is invoked, right? Considering that we get a list of all t...

...al variable in mkinitrd, and is therefore extremely nasty # and applicable only to a particular version of mkinitrd. if ($desc->{distro} eq 'rhel' && $desc->{major_version} eq '4') { - push(@env, 'root_lvm=1') if ($g->is_lv($desc->{root_device})); + push(@env, 'root_lvm=1') if ($g->is_lv($root)); } $g->sh(join(' ', @env).' /sbin/mkinitrd '.join(' ', @module_args). diff --git a/lib/Sys/VirtConvert/Converter/Windows.pm b/lib/Sys/VirtConv...

I'm currently working on gobject bindings for libguestfs. I haven't got as far as compiling anything yet, but I've attached the C header for initial review. Matt -- Matthew Booth, RHCA, RHCSS Red Hat Engineering, Virtualisation Team GPG ID: D33C3490 GPG FPR: 3733 612D 2D05 5458 8A8A 1600 3441 EA19 D33C 3490 -------------- next part -------------- An embedded and

This is a follow-up to the other generator changes in: https://www.redhat.com/archives/libguestfs/2017-February/msg00217.html Rich.

...mkinitrd, and is therefore extremely nasty + # and applicable only to a particular version of mkinitrd. + if (_is_rhel_family($g, $root) && + $g->inspect_get_major_version($root) eq '4') + { + push(@env, 'root_lvm=1') if ($g->is_lv($root)); + } + + $g->sh(join(' ', @env).' /sbin/mkinitrd '.join(' ', @module_args). + " $grub_initrd $version"); + } + + else { + v2vdie __('Didn\'t find mkinitrd or dracut. Unable to update initrd.'); + }...

...vice"); String (Key, "key"); Int "keyslot"], []; optional = Some "luks"; shortdesc = "remove a key from a LUKS encrypted device"; longdesc = "\ @@ -5941,7 +5941,7 @@ I<other> keys." }; { defaults with name = "is_lv"; added = (1, 5, 3); - style = RBool "lvflag", [Mountable "mountable"], []; + style = RBool "lvflag", [String (Mountable, "mountable")], []; tests = [ InitBasicFSonLVM, Always, TestResultTrue ( [["is_lv"; "/dev/V...

Very large but mechanical change to the generator. Rich.

Split up the huge generator/actions.ml into several smaller files. Rich.

The existing mechanism was clunky, slow and used ~ 10 MB of local disk. Rich.