search for: is_ignor

virt-sparsify shouldn't die if sparsifying a filesystem that contains read-only LVs. https://bugzilla.redhat.com/show_bug.cgi?id=1185561 I thought about trying to make the LV writable temporarily, but I suspect that if the sysadmin has made the LV read-only, then they probably did it for a reason, so we shouldn't touch it. Rich.

...+ b/sparsify/copying.ml @@ -216,9 +216,11 @@ You can ignore this warning or change it to a hard failure using the List.exists (fun fs' -> fs = g#canonical_device_name fs') ignores in + let is_read_only_lv = is_read_only_lv g in + List.iter ( fun fs -> - if not (is_ignored fs) then ( + if not (is_ignored fs) && not (is_read_only_lv fs) then ( if List.mem fs zeroes then ( if not quiet then printf (f_"Zeroing %s ...\n%!") fs; diff --git a/sparsify/in_place.ml b/sparsify/in_place.ml index 751129e..268784c 100644...

...1 @@ You can ignore this warning or change it to a hard failure using the > List.exists (fun fs' -> fs = g#canonical_device_name fs') ignores > in > > + let is_read_only_lv = is_read_only_lv g in > + > List.iter ( > fun fs -> > - if not (is_ignored fs) then ( > + if not (is_ignored fs) && not (is_read_only_lv fs) then ( > if List.mem fs zeroes then ( > if not quiet then > printf (f_"Zeroing %s ...\n%!") fs; > diff --git a/sparsify/in_place.ml b/sparsify/in_place.ml >...

...+ try + let vol_info = g#btrfs_subvolume_show mp in + string_find (List.assoc "Flags" vol_info) "readonly" <> -1 + with _ -> false + ) else false + with Not_found -> false + in + List.iter ( fun fs -> if not (is_ignored fs) then ( @@ -230,10 +247,15 @@ You can ignore this warning or change it to a hard failure using the with _ -> false in if mounted then ( - if not quiet then - printf (f_"Fill free space in %s with zero ...\n%!") fs; + if...

This patch is easier to read if you use the 'git show -w' option. Also observe that: fun a -> ( fun () -> (* code *) ) (ie. returning a closure) is identical to: fun a () -> (* code *) Rich.

...-> false in + let is_readonly_device mp = + let statvfs = g#statvfs mp in + let flags = statvfs.G.flag in + (* 0x01 is ST_RDONLY in Linux' GNU libc. *) + flags <> -1_L && (flags &^ 0x1_L) <> 0_L + in + List.iter ( fun fs -> if not (is_ignored fs) then ( @@ -250,6 +257,9 @@ You can ignore this warning or change it to a hard failure using the if is_readonly_btrfs_snapshot fs "/" then ( if not quiet then printf (f_"Skipping %s, as it is a read-only btrfs snapshot.\n%!") fs;...

This still isn't working at the moment. See: http://marc.info/?t=139457409300003&r=1&w=2 This set of patches: - Adds new APIs to support discard in libguestfs. - Adds discard support to virt-format. - Adds discard support to virt-sysprep. - Implements virt-sparsify --in-place. Rich.

This set of patches: - Adds new APIs to support discard in libguestfs. - Adds discard support to virt-format. - Adds discard support to virt-sysprep. - Implements virt-sparsify --in-place. This is now working, after fixing the rather stupid bug in fstrim. I've pushed the ones which were ACKed previously + the fstrim fix. Rich.

Version 1 of the patch, for discussion, but not to be applied. It does work, but needs a lot more testing. This removes all the psychopathic gettextify cruft, and replaces it with a 99 line Makefile.am. A large win, I think. The third patch implements gettext support in the OCaml tools. The fourth patch is just for illustration. It shows the consequent changes to libguestfs.pot and the po