search for: is_hdmi2_sink

From: Ville Syrjälä <ville.syrjala at linux.intel.com> Make life easier for drivers by simply passing the connector to drm_hdmi_avi_infoframe_from_display_mode() and drm_hdmi_avi_infoframe_quant_range(). That way drivers don't need to worry about is_hdmi2_sink mess. v2: Make is_hdmi2_sink() return true for sil-sii8620 Adapt to omap/vc4 changes Cc: Alex Deucher <alexander.deucher at amd.com> Cc: "Christian König" <christian.koenig at amd.com> Cc: "David (ChunMing) Zhou" <David1.Zhou at amd.com> Cc: Archit Taneja...

...m> wrote: > From: Ville Syrjälä <ville.syrjala at linux.intel.com> > > Make life easier for drivers by simply passing the connector > to drm_hdmi_avi_infoframe_from_display_mode() and > drm_hdmi_avi_infoframe_quant_range(). That way drivers don't > need to worry about is_hdmi2_sink mess. Overall looks about right and nice, Reviewed-by: Jani Nikula <jani.nikula at intel.com> But please do take that with a grain of salt for everything outside of i915 and drm core. Please also find a few comments inline below. > Cc: Alex Deucher <alexander.deucher at amd.com>...

From: Ville Syrjälä <ville.syrjala at linux.intel.com> Make life easier for drivers by simply passing the connector to drm_hdmi_avi_infoframe_from_display_mode() and drm_hdmi_avi_infoframe_quant_range(). That way drivers don't need to worry about is_hdmi2_sink mess. Cc: Alex Deucher <alexander.deucher at amd.com> Cc: "Christian König" <christian.koenig at amd.com> Cc: "David (ChunMing) Zhou" <David1.Zhou at amd.com> Cc: Archit Taneja <architt at codeaurora.org> Cc: Andrzej Hajda <a.hajda at samsung.com>...

.../drm/drm_edid.c > >>> +++ b/drivers/gpu/drm/drm_edid.c > >>> @@ -4830,19 +4830,32 @@ void drm_set_preferred_mode(struct drm_connector *connector, > >>> } > >>> EXPORT_SYMBOL(drm_set_preferred_mode); > >>> > >>> +static bool is_hdmi2_sink(struct drm_connector *connector) > >> You're usually known for adding const all around, why not const pointer > >> here and in all the other drm_* functions that call this? > > My current approach is to constify states/fbs/etc. but not so much > > crtcs/connectors/...

...ille Syrjälä <ville.syrjala at linux.intel.com> > > > > Make life easier for drivers by simply passing the connector > > to drm_hdmi_avi_infoframe_from_display_mode() and > > drm_hdmi_avi_infoframe_quant_range(). That way drivers don't > > need to worry about is_hdmi2_sink mess. > > Overall looks about right and nice, > > Reviewed-by: Jani Nikula <jani.nikula at intel.com> > > But please do take that with a grain of salt for everything outside of > i915 and drm core. > > Please also find a few comments inline below. > > &gt...

...drivers/gpu/drm/drm_edid.c > >>>>> @@ -4830,19 +4830,32 @@ void drm_set_preferred_mode(struct drm_connector *connector, > >>>>> } > >>>>> EXPORT_SYMBOL(drm_set_preferred_mode); > >>>>> > >>>>> +static bool is_hdmi2_sink(struct drm_connector *connector) > >>>> You're usually known for adding const all around, why not const pointer > >>>> here and in all the other drm_* functions that call this? > >>> My current approach is to constify states/fbs/etc. but not so much &gt...

...>>> --- a/drivers/gpu/drm/drm_edid.c >>> +++ b/drivers/gpu/drm/drm_edid.c >>> @@ -4830,19 +4830,32 @@ void drm_set_preferred_mode(struct drm_connector *connector, >>> } >>> EXPORT_SYMBOL(drm_set_preferred_mode); >>> >>> +static bool is_hdmi2_sink(struct drm_connector *connector) >> You're usually known for adding const all around, why not const pointer >> here and in all the other drm_* functions that call this? > My current approach is to constify states/fbs/etc. but not so much > crtcs/connectors/etc. Too much const...

...t;>>>> +++ b/drivers/gpu/drm/drm_edid.c >>>>> @@ -4830,19 +4830,32 @@ void drm_set_preferred_mode(struct drm_connector *connector, >>>>> } >>>>> EXPORT_SYMBOL(drm_set_preferred_mode); >>>>> >>>>> +static bool is_hdmi2_sink(struct drm_connector *connector) >>>> You're usually known for adding const all around, why not const pointer >>>> here and in all the other drm_* functions that call this? >>> My current approach is to constify states/fbs/etc. but not so much >>> crtcs...

.../drm_edid.c >>>>>>> @@ -4830,19 +4830,32 @@ void drm_set_preferred_mode(struct drm_connector *connector, >>>>>>> } >>>>>>> EXPORT_SYMBOL(drm_set_preferred_mode); >>>>>>> >>>>>>> +static bool is_hdmi2_sink(struct drm_connector *connector) >>>>>> You're usually known for adding const all around, why not const pointer >>>>>> here and in all the other drm_* functions that call this? >>>>> My current approach is to constify states/fbs/etc. but not so...

...>>>>> @@ -4830,19 +4830,32 @@ void drm_set_preferred_mode(struct drm_connector *connector, > >>>>>>> } > >>>>>>> EXPORT_SYMBOL(drm_set_preferred_mode); > >>>>>>> > >>>>>>> +static bool is_hdmi2_sink(struct drm_connector *connector) > >>>>>> You're usually known for adding const all around, why not const pointer > >>>>>> here and in all the other drm_* functions that call this? > >>>>> My current approach is to constify states/fbs/...

...om: Ville Syrjälä <ville.syrjala at linux.intel.com> >> >> Make life easier for drivers by simply passing the connector >> to drm_hdmi_avi_infoframe_from_display_mode() and >> drm_hdmi_avi_infoframe_quant_range(). That way drivers don't >> need to worry about is_hdmi2_sink mess. > While this is good for display controller drivers, the change isn't great for > bridge drivers. Down the road we're looking at moving connector support out of > the bridge drivers. Adding an additional dependency to connectors in the > bridges will make that more diff...

...inux.intel.com> >>>> >>>> Make life easier for drivers by simply passing the connector >>>> to drm_hdmi_avi_infoframe_from_display_mode() and >>>> drm_hdmi_avi_infoframe_quant_range(). That way drivers don't >>>> need to worry about is_hdmi2_sink mess. >>> While this is good for display controller drivers, the change isn't great for >>> bridge drivers. Down the road we're looking at moving connector support out of >>> the bridge drivers. Adding an additional dependency to connectors in the >>>...

...>>>> Make life easier for drivers by simply passing the connector >>>>>>> to drm_hdmi_avi_infoframe_from_display_mode() and >>>>>>> drm_hdmi_avi_infoframe_quant_range(). That way drivers don't >>>>>>> need to worry about is_hdmi2_sink mess. >>>>>> While this is good for display controller drivers, the change isn't >>>>>> great for bridge drivers. Down the road we're looking at moving >>>>>> connector support out of the bridge drivers. Adding an additional >>>...

...gt;>>> > >>>> Make life easier for drivers by simply passing the connector > >>>> to drm_hdmi_avi_infoframe_from_display_mode() and > >>>> drm_hdmi_avi_infoframe_quant_range(). That way drivers don't > >>>> need to worry about is_hdmi2_sink mess. > >>> While this is good for display controller drivers, the change isn't great for > >>> bridge drivers. Down the road we're looking at moving connector support out of > >>> the bridge drivers. Adding an additional dependency to connectors in the...

...jala wrote: > From: Ville Syrjälä <ville.syrjala at linux.intel.com> > > Make life easier for drivers by simply passing the connector > to drm_hdmi_avi_infoframe_from_display_mode() and > drm_hdmi_avi_infoframe_quant_range(). That way drivers don't > need to worry about is_hdmi2_sink mess. > > Cc: Alex Deucher <alexander.deucher at amd.com> > Cc: "Christian König" <christian.koenig at amd.com> > Cc: "David (ChunMing) Zhou" <David1.Zhou at amd.com> > Cc: Archit Taneja <architt at codeaurora.org> > Cc: Andrzej Hajda &...

...jala wrote: > From: Ville Syrjälä <ville.syrjala at linux.intel.com> > > Make life easier for drivers by simply passing the connector > to drm_hdmi_avi_infoframe_from_display_mode() and > drm_hdmi_avi_infoframe_quant_range(). That way drivers don't > need to worry about is_hdmi2_sink mess. While this is good for display controller drivers, the change isn't great for bridge drivers. Down the road we're looking at moving connector support out of the bridge drivers. Adding an additional dependency to connectors in the bridges will make that more difficult. Ideally brid...

...le.syrjala at linux.intel.com> > >> > >> Make life easier for drivers by simply passing the connector > >> to drm_hdmi_avi_infoframe_from_display_mode() and > >> drm_hdmi_avi_infoframe_quant_range(). That way drivers don't > >> need to worry about is_hdmi2_sink mess. > > While this is good for display controller drivers, the change isn't great for > > bridge drivers. Down the road we're looking at moving connector support out of > > the bridge drivers. Adding an additional dependency to connectors in the > > bridges will...

...> >>>>> Make life easier for drivers by simply passing the connector > >>>>> to drm_hdmi_avi_infoframe_from_display_mode() and > >>>>> drm_hdmi_avi_infoframe_quant_range(). That way drivers don't > >>>>> need to worry about is_hdmi2_sink mess. > >>>> > >>>> While this is good for display controller drivers, the change isn't > >>>> great for bridge drivers. Down the road we're looking at moving > >>>> connector support out of the bridge drivers. Adding an additiona...