search for: is_directory

The first patch is just some simple refactoring. See the second patch for a description of the new virt-sparsify --tmp option. I tested this using a loopback device as my temporary block device, and it seems to work fine for me. Federico .. this needs a BZ :-) Rich.

When trying to install files from virtio-win as directory, check for directory existance using absolute paths. Otherwise, is_directory is called on relative paths such as "linux/el7" which obviously do not exist. Fixes commit 1c85b64c1c3a4d5267b952102375cb78f18a85c4. --- v2v/windows_virtio.ml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/v2v/windows_virtio.ml b/v2v/windows_virtio.ml index 92bf3ec6...

...indows_virtio.ml > index 92bf3ec60..94c4774b7 100644 > --- a/v2v/windows_virtio.ml > +++ b/v2v/windows_virtio.ml > @@ -308,10 +308,10 @@ and copy_drivers g inspect driverdir = > and copy_from_virtio_win g inspect srcdir destdir filter missing = > let ret = ref [] in > if is_directory virtio_win then ( > - let dir = virtio_win // srcdir in > - debug "windows: copy_from_virtio_win: guest tools source directory %s" dir; > + debug "windows: copy_from_virtio_win: guest tools source directory %s" virtio_win; Be good to put "virtio_win"...

First patch just fixes installing guest tools from directory that was broken. Second patch revamps how virt-v2v chooses from which directory install guest tools on Linux. Details in commit message. Tomáš Golembiovský (2): v2v: fix path to source when copying files from guest tools directory v2v: allow alternative directories for distributions v2v/windows_virtio.ml | 67

...git a/v2v/windows_virtio.ml b/v2v/windows_virtio.ml index 92bf3ec60..94c4774b7 100644 --- a/v2v/windows_virtio.ml +++ b/v2v/windows_virtio.ml @@ -308,10 +308,10 @@ and copy_drivers g inspect driverdir = and copy_from_virtio_win g inspect srcdir destdir filter missing = let ret = ref [] in if is_directory virtio_win then ( - let dir = virtio_win // srcdir in - debug "windows: copy_from_virtio_win: guest tools source directory %s" dir; + debug "windows: copy_from_virtio_win: guest tools source directory %s" virtio_win; - if not (is_directory srcdir) then missing () +...

...git a/v2v/windows_virtio.ml b/v2v/windows_virtio.ml index 92bf3ec60..a2b59d1ec 100644 --- a/v2v/windows_virtio.ml +++ b/v2v/windows_virtio.ml @@ -308,10 +308,11 @@ and copy_drivers g inspect driverdir = and copy_from_virtio_win g inspect srcdir destdir filter missing = let ret = ref [] in if is_directory virtio_win then ( - let dir = virtio_win // srcdir in - debug "windows: copy_from_virtio_win: guest tools source directory %s" dir; + debug "windows: copy_from_virtio_win: guest tools source directory %s" + virtio_win; - if not (is_directory srcdir) then missi...

On Wed, Mar 20, 2019 at 07:08:45PM +0100, Pino Toscano wrote: > When trying to install files from virtio-win as directory, check for > directory existance using absolute paths. Otherwise, is_directory is > called on relative paths such as "linux/el7" which obviously do not > exist. > > Fixes commit 1c85b64c1c3a4d5267b952102375cb78f18a85c4. > --- > v2v/windows_virtio.ml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/v2v/windows_vir...

...tten by the main * code. @@ -98,13 +97,12 @@ object eprintf "VDSM: image directory: %s\n%!" image_dir; (* Note that VDSM has to create this directory too. *) - ovf_dir <- dd_mp // dd_uuid // "master" // "vms" // vdsm_params.vm_uuid; - if not (is_directory ovf_dir) then + if not (is_directory vdsm_params.ovf_output) then error (f_"OVF (metadata) directory (%s) does not exist or is not a directory") - ovf_dir; + vdsm_params.ovf_output; if verbose then - eprintf "VDSM: OVF (metadata) directory: %s\n%!&...

...Find files in [dir] ending with [ext]. *) +let find_files dir ext = + let rec loop = function + | [] -> [] + | dir :: rest -> + let files = Array.to_list (Sys.readdir dir) in + let files = List.map (Filename.concat dir) files in + let dirs, files = List.partition Sys.is_directory files in + let files = + List.filter (fun x -> Filename.check_suffix x ext) files in + files @ loop (rest @ dirs) + in + loop [dir] + +(* Uncompress the first few bytes of [file] and return it as + * [(bytes, len)]. [zcat] is the command to use (eg. zcat or xzcat). + *) +l...

...exists but is empty or when [filter] + * function is too strict to allow any of the files. + * * Returns list of copied files. *) -and copy_from_virtio_win g inspect srcdir destdir filter missing = +and copy_from_virtio_win g inspect srcdirs destdir filter missing = let ret = ref [] in if is_directory virtio_win then ( debug "windows: copy_from_virtio_win: guest tools source directory %s" virtio_win; - let dir = virtio_win // srcdir in - if not (is_directory dir) then missing () - else ( + try + let srcdirs = List.map ((//) virtio_win) srcdirs in + let dir...

...ist of copied files. *) -and copy_from_virtio_win g inspect srcdir destdir filter missing = +and copy_from_virtio_win g inspect srcdirs destdir filter missing = + if srcdirs == [] then + invalid_arg "windows: copy_from_virtio_win: no source directories"; let ret = ref [] in if is_directory virtio_win then ( debug "windows: copy_from_virtio_win: guest tools source directory %s" virtio_win; - let dir = virtio_win // srcdir in - if not (is_directory dir) then missing () - else ( + try + let srcdirs = List.map ((//) virtio_win) srcdirs in + l...

First patch just fixes installing guest tools from directory that was broken. Second patch revamps how virt-v2v chooses from which directory install guest tools on Linux. Details in commit message. v2: - included comments from Pino and Rich - added test Tomáš Golembiovský (3): v2v: fix path to source when copying files from guest tools directory v2v: allow alternative directories for

...e . pinging it again. Dear samba team, please help me in understanding these. 1) in samba posix_acls.c why samba always setting the READ access for the file and READ and WRITE access for directory ? ---------- case S_IRUSR: /* Ensure owner has read access. */ pace->perms |= S_IRUSR; if (is_directory) pace->perms |= (S_IWUSR|S_IXUSR); and_bits = unix_perms_to_acl_perms(and_bits, S_IRUSR, S_IWUSR, S_IXUSR); or_bits = unix_perms_to_acl_perms(or_bits, S_IRUSR, S_IWUSR, S_IXUSR); ----------- 2) I have connected a samba share from the device onto my windows xp machine.. when I tried modif...

Small function to create in OCaml-based code a directory and its parents, much like `mkdir -p`. --- mllib/common_utils.ml | 11 +++++++++++ mllib/common_utils.mli | 3 +++ 2 files changed, 14 insertions(+) diff --git a/mllib/common_utils.ml b/mllib/common_utils.ml index 898be17..76d8b79 100644 --- a/mllib/common_utils.ml +++ b/mllib/common_utils.ml @@ -673,3 +673,14 @@ let qemu_input_filename

...> status = make_default_filesystem_acl(mem_ctx, > smb_fname->base_name, > psbuf, > - &psd); > + &psd_blob); > if (!NT_STATUS_IS_OK(status)) { > TALLOC_FREE(frame); > return status; > } > } else { > if (is_directory && > - !sd_has_inheritable_components(psd, > + !sd_has_inheritable_components(psd_blob, > true)) { > status = add_directory_inheritable_components( > handle, > smb_fname->base_name, > psbuf, > - psd); > + p...

On Fri, Aug 26, 2016 at 04:03:49PM -0700, Jeremy Allison wrote: > On Fri, Aug 26, 2016 at 02:46:19PM -0700, Jeremy Allison via samba wrote: > > On Fri, Aug 26, 2016 at 06:44:05PM +0200, Ralph Böhme wrote: > > > > > > Cheerio! > > > -slow > > > > Still reviewing this - but a few things that will need changing: > > > > When adding the

...te_on_close) { DEBUG(10,("set_delete_on_close: %s delete on close flag for " "fnum = %d, file %s\n", delete_on_close ? "Adding" : "Removing", fsp->fnum, fsp->fsp_name )); if (fsp->is_directory || fsp->is_stat) return NT_STATUS_OK; if (lock_share_entry_fsp(fsp) == False) return NT_STATUS_ACCESS_DENIED; -- Axel.Thimm at ATrpms.net -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: applicatio...

...target files that eventually get written by the main * code. @@ -98,13 +97,12 @@ object ) vdsm_params.image_uuids; (* Note that VDSM has to create this directory too. *) - ovf_dir <- dd_mp // dd_uuid // "master" // "vms" // vdsm_params.vm_uuid; - if not (is_directory ovf_dir) then + if not (is_directory vdsm_params.ovf_output) then error (f_"OVF (metadata) directory (%s) does not exist or is not a directory") - ovf_dir; + vdsm_params.ovf_output; if verbose then - eprintf "VDSM: OVF (metadata) directory: %s\n%!&...

...tten by the main * code. @@ -98,13 +97,12 @@ object eprintf "VDSM: image directory: %s\n%!" image_dir; (* Note that VDSM has to create this directory too. *) - ovf_dir <- dd_mp // dd_uuid // "master" // "vms" // vdsm_params.vm_uuid; - if not (is_directory ovf_dir) then + if not (is_directory vdsm_params.ovf_output) then error (f_"OVF (metadata) directory (%s) does not exist or is not a directory") - ovf_dir; + vdsm_params.ovf_output; if verbose then - eprintf "VDSM: OVF (metadata) directory: %s\n%!&...

...; + * function is too strict to allow any of the files. > + * > * Returns list of copied files. > *) > -and copy_from_virtio_win g inspect srcdir destdir filter missing = > +and copy_from_virtio_win g inspect srcdirs destdir filter missing = > let ret = ref [] in > if is_directory virtio_win then ( > debug "windows: copy_from_virtio_win: guest tools source directory > %s" virtio_win; > > - let dir = virtio_win // srcdir in > - if not (is_directory dir) then missing () > - else ( > + try > + let srcdirs = List.map ((//)...