search for: iput

Hi, oops in iput - Kernel 2.2.19/i386 + ide-udma patches + ext3 patches (0.0.7a) Intel BX chipset, SCSI Disks Symbios chipset - The crashing process is the master process of "postfix" an MTA. Just before the crash all processes on that machine started to segfault in nameserver resolution (remote dns ser...

In ocfs2_dentry_attach_lock(), if unable to get the dentry lock(), we need to call iput(inode) because a failure here means no d_instantiate(), which means the normally matching iput() will not be called during dput(dentry). This patch fixes the oops that accompanies the following message: (3996,1):dlm_empty_lockres:2708 ERROR: lockres W00000000000000000a1046b06a4382 still has local...

Mainline commit a5a0a630922a2f6a774b6dac19f70cb5abd86bb0 In ocfs2_dentry_attach_lock(), if unable to get the dentry lock, we need to call iput(inode) because a failure here means no d_instantiate(), which means the normally matching iput() will not be called during dput(dentry). This patch fixes the oops that accompanies the following message: (3996,1):dlm_empty_lockres:2708 ERROR: lockres W00000000000000000a1046b06a4382 still has local...

From: Markus Elfring <elfring at users.sourceforge.net> Date: Mon, 18 Jul 2016 21:17:18 +0200 The iput() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring <elfring at users.sourceforge.net> --- drivers/virtio/virtio_balloon.c | 3 +-- 1...

From: Markus Elfring <elfring at users.sourceforge.net> Date: Mon, 18 Jul 2016 21:17:18 +0200 The iput() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring <elfring at users.sourceforge.net> --- drivers/virtio/virtio_balloon.c | 3 +-- 1...

..._remote_dentry_delete() ocfs2_dentry_convert_worker() finishes ocfs2_unlink() eventually enters ocfs2_delete_inode() ocfs2_inode_lock() ocfs2_query_inode_wipe() -> fail ocfs2_inode_unlock() ocfs2_dentry_post_unlock() ocfs2_drop_dentry_lock() iput() ocfs2_delete_inode() ocfs2_inode_lock() ocfs2_query_inode_wipe() -> fail ocfs2_inode_unlock() clear_inode() clear_inode() The question is how to avoid this. It seems to me that we have to really do open_lock() and not just trylock to avoid the race. Is...

...; + goto out; } ret = link_to_fixup_dir(trans, root, path, location.objectid); - BUG_ON(ret); + if (ret) + goto out; ret = btrfs_unlink_inode(trans, root, dir, inode, name, name_len); - BUG_ON(ret); + if (ret) + goto out; + btrfs_run_delayed_items(trans, root); +out: kfree(name); - iput(inode); - - btrfs_run_delayed_items(trans, root); return ret; } @@ -883,7 +890,8 @@ again: victim_name_len = btrfs_inode_ref_name_len(leaf, victim_ref); victim_name = kmalloc(victim_name_len, GFP_NOFS); - BUG_ON(!victim_name); + if (!victim_name) + return -ENOMEM;...

Suppose I have a Master.Rnw file that looks something like this: \documentclass[12pt]{mypaper} \usepackage[margin=1in]{geometry} \usepackage{setspace} \usepackage{url} \usepackage{indentfirst} \usepackage{fancyhdr} \usepackage{Sweave} \pagestyle{fancy} \lhead{sonographic rectal diameter and ADHD} \rhead{ } \usepackage{abbrevs} %\usepackage{natbib} %\usepackage{apacite}

The WARN_ON() in start_transaction() was triggered while balancing. The cause is btrfs_relocate_chunk() started a transaction and then called iput() on the inode that stores free space cache, and iput() called btrfs_start_transaction() again. Reported-by: Tsutomu Itoh <t-itoh@jp.fujitsu.com> Signed-off-by: Li Zefan <lizf@cn.fujitsu.com> --- fs/btrfs/inode.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git...

...ertion(+), 1 deletion(-) diff --git a/drivers/virtio/virtio_balloon.c b/drivers/virtio/virtio_balloon.c index 7bfe365d9372..b6ed5f8bccb1 100644 --- a/drivers/virtio/virtio_balloon.c +++ b/drivers/virtio/virtio_balloon.c @@ -959,9 +959,9 @@ static int virtballoon_probe(struct virtio_device *vdev) iput(vb->vb_dev_info.inode); out_kern_unmount: kern_unmount(balloon_mnt); -#endif out_del_vqs: vdev->config->del_vqs(vdev); +#endif out_free_vb: kfree(vb); out: -- 2.21.0

...ertion(+), 1 deletion(-) diff --git a/drivers/virtio/virtio_balloon.c b/drivers/virtio/virtio_balloon.c index 7bfe365d9372..b6ed5f8bccb1 100644 --- a/drivers/virtio/virtio_balloon.c +++ b/drivers/virtio/virtio_balloon.c @@ -959,9 +959,9 @@ static int virtballoon_probe(struct virtio_device *vdev) iput(vb->vb_dev_info.inode); out_kern_unmount: kern_unmount(balloon_mnt); -#endif out_del_vqs: vdev->config->del_vqs(vdev); +#endif out_free_vb: kfree(vb); out: -- 2.21.0

...git://git.kernel.org/pub/scm/linux/kernel/jlbec/ocfs2.git upstream-linus Joel Becker (3): ocfs2: Fix some printk() warnings. ocfs2: Fix a missing credit when deleting from indexed directories. ocfs2: Change repository in MAINTAINERS. Sunil Mushran (1): ocfs2: Add missing iput() during error handling in ocfs2_dentry_attach_lock() Tao Ma (3): ocfs2: Reserve 1 more cluster in expanding_inline_dir for indexed dir. ocfs2: Fix 2 warning during ocfs2 make. ocfs2/trivial: Remove unused variable in ocfs2_rename. MAINTAINERS | 2 +- fs/ocfs2/dcache...

...h inode cache, snap/subvol can only be added into dead roots list during freeing roots stage in umount, so that we can ONLY get space back after another remount(we cleanup dead roots on mount). But the real thing is we''ll no more use the snap/subvol if we mark it deleted, so we can safely iput its cache inode when we delete snap/subvol. Another thing is that we need to change the rules of droping inode, we don''t keep snap/subvol''s cache inode in memory till end so that we can add snap/subvol into dead roots list in time. Reported-by: Mitch Harder <mitch.harder@saba...

...node *ocfs2_iget(struct ocfs2_su * afterwards. */ if (inode && inode->i_state & I_NEW) { mlog(0, "Inode was not in inode cache, reading it.\n"); - ocfs2_read_locked_inode(inode, &args); + status = ocfs2_read_locked_inode(inode, &args); + if (status) { + iput(inode); + inode = ERR_PTR(status); + goto bail; + } unlock_new_inode(inode); } if (inode == NULL) {

This is yet-another reason to _partition_ your disks. Of course hard links do not work accross filesystems. Even thought it is a pain in the neck to do when installing your operating system, think about separating critical system files from non-critical and non-system files from system files. I would say that the following layout is a good place to start: / /usr (nosuid,nodev,ro) /usr/local

...list_add(&BTRFS_I(inode)->i_orphan, &root->orphan_list); - spin_unlock(&root->orphan_lock); /* - * if this is a bad inode, means we actually succeeded in - * removing the inode, but not the orphan record, which means - * we need to manually delete the orphan since iput will just - * do a destroy_inode + * Inode is already gone but the orphan item is still there, + * kill the orphan item. */ - if (is_bad_inode(inode)) { - trans = btrfs_start_transaction(root, 0); + if (ret == -ESTALE) { + trans = btrfs_start_transaction(root, 1); if (IS_ERR(tra...

When adding orphans to an inode''s root, we start a transaction for that root that when ended in several places such as for example extent-tree.c:btrfs_remove_block_group(), inode.c:btrfs_unlink() and inode.c:btrfs_evict_node(), doesn''t result in a commit, that is, inode.c:btrfs_orphan_commit_root() doesn''t get called (via transaction.c:commit_fs_roots()). The respective

Resending after implementing review comments.

...b [ext3] <f0865bcb> ext3_free_inode+0x92/0x2c7 [ext3] <f08666ee> ext3_mark_inode_dirty+0x20/0x27 [ext3] <f08687dd> ext3_delete_inode+0xa3/0xba [ext3] <f086873a> ext3_delete_inode+0x0/0xba [ext3] <b016809c> generic_delete_inode+0x9e/0x101 <b0167b87> iput+0x5e/0x60 <b0166d66> dput+0xfe/0x116 <b0160a4f> sys_renameat+0x15f/0x1b9 <b01b04d2> _atomic_dec_and_lock+0x2a/0x44 <b0160aba> sys_rename+0x11/0x15 <b0102af3> sysenter_past_esp+0x54/0x75 BUG: warning at kernel/softirq.c:141/local_bh_enable() <b0120e27...

I noticed while running xfstests 83 that if we didn''t have enough space to delete our inode the orphan cleanup would just loop. This is because it keeps finding the same orphan item and keeps trying to kill it but can''t because we don''t get an error back from iput for deleting the inode. So keep track of the last guy we tried to kill, if it''s the same as the one we''re trying to kill currently we know we are having problems and can just error out. I don''t have a way to test this so look hard and make sure it''s right. Tha...