search for: ipinfo

.../ udata.StationPort = socket->net.efi.localport; - udata.UseDefaultAddress = TRUE; + /** + * Determine if this is remote or local subnet to set + * UseDefaultAddress. If ip (TFTP/MTFTP server or + * RemoteAddress) is on same subnet as client, + * which is stored in IPInfo.myip, this is local subnet. + */ + if (0 == IPInfo.myip || 0 == ip) { + /* if either address is NULL, enable default addresses */ + udata.UseDefaultAddress = TRUE; + } else { + if ((IPInfo.myip & IPInfo.netmask) == (ip & IPInfo.netmask)) { + /* On...

...er/024341.html > This report has led to Gene's patch: > > https://github.com/geneC/syslinux/commit/9e0926bb338deb5c634ccb4ee29eb4577158cfdc > it was reported working but I think "it cannot work" if it has these lines > > + memcpy(&udata.StationAddress, &IPInfo.myip, sizeof(IPInfo.myip)); > + memcpy(&udata.StationAddress, &IPInfo.netmask, sizeof(IPInfo.netmask)); > > the StationAddress gets overwritten by a netmask... Thanks for noticing. I've corrected this and I'm reviewing the patch itself. -- -Gene

...12:11:01.000000000 +0200 @@ -151,11 +151,11 @@ ip_packet_match(const struct iphdr *ip, } /* Look for ifname matches; this should unroll nicely. */ - for (i = 0, ret = 0; i < IFNAMSIZ/sizeof(unsigned long); i++) { - ret |= (((const unsigned long *)indev)[i] - ^ ((const unsigned long *)ipinfo->iniface)[i]) - & ((const unsigned long *)ipinfo->iniface_mask)[i]; - } + for (i = 0, ret = 0; i < IFNAMSIZ; i++) { + ret |= (indev[i] + ^ ipinfo->iniface[i]) + & ipinfo->iniface_mask[i]; + } if (FWINV(ret != 0, IPT_INV_VIA_IN)) { dprintf("VIA in mismatch...

...p so populate server from ProxyOffer packet. The information is loaded into pkt_v4 and then parsed. In efi/udp.c: Both updates are in core_udp_connect and core_udp_sendto functions. 1. Disable UseDefaultAddress, which is not complete. 2. Set StationAddress and SubnetMask to correct values from IPInfo struct because both fields are not necessarily populated. Signed-off-by: Jeff Sloan <jeff_sloan at selinc.com> --- diffstat results: pxe.c | 16 +++++++++++++++- udp.c | 12 ++++++++++-- 2 files changed, 25 insertions(+), 3 deletions(-) Common subdirectories: orig_repo/syslinux-master...

...nsertion(+), 1 deletion(-) diff --git a/efi/udp.c b/efi/udp.c index 1088f47..b0f13ad 100644 --- a/efi/udp.c +++ b/efi/udp.c @@ -163,7 +163,7 @@ void core_udp_connect(struct pxe_pvt_inode *socket, uint32_t ip, } else { udata.UseDefaultAddress = FALSE; memcpy(&udata.StationAddress, &IPInfo.myip, sizeof(IPInfo.myip)); - memcpy(&udata.StationAddress, &IPInfo.netmask, sizeof(IPInfo.netmask)); + memcpy(&udata.SubnetMask, &IPInfo.netmask, sizeof(IPInfo.netmask)); } memcpy(&udata.RemoteAddress, &ip, sizeof(ip)); udata.RemotePort = port; -- 2.9.3

...the existing local port number */ udata.StationPort = socket->net.efi.localport; - udata.UseDefaultAddress = TRUE; + if (efi_net_def_addr) { + udata.UseDefaultAddress = TRUE; + } else { + udata.UseDefaultAddress = FALSE; + memcpy(&udata.StationAddress, &IPInfo.myip, sizeof(IPInfo.myip)); + memcpy(&udata.StationAddress, &IPInfo.netmask, sizeof(IPInfo.netmask)); + } memcpy(&udata.RemoteAddress, &ip, sizeof(ip)); udata.RemotePort = port; udata.TimeToLive = 64; So don't worry about "manual" :-) > _...

...aram:socket, the open socket > + * @param:ip, the ip address > + * @param:port, the port number, host-byte order > + */ > +void core_udp_connect(struct pxe_pvt_inode *socket, uint32_t ip, > + uint16_t port) > +{ > + memcpy(&udata.StationAddress, &IPInfo.myip, sizeof(IPInfo.myip)); > + memcpy(&udata.SubnetMask, &IPInfo.netmask, sizeof(IPInfo.netmask)); > + memcpy(&udata.RemoteAddress, &ip, sizeof(ip)); > + udata.RemotePort = port; > + udata.AcceptPromiscuous = TRUE; > + Looking at UEFI Spec v2.5 (same wor...

...w.syslinux.org/archives/2015-October/024341.html This report has led to Gene's patch: https://github.com/geneC/syslinux/commit/9e0926bb338deb5c634ccb4ee29eb4577158cfdc it was reported working but I think "it cannot work" if it has these lines + memcpy(&udata.StationAddress, &IPInfo.myip, sizeof(IPInfo.myip)); + memcpy(&udata.StationAddress, &IPInfo.netmask, sizeof(IPInfo.netmask)); the StationAddress gets overwritten by a netmask... There's a picture attached comparing performance between the old and new udp.c code. Testing reports are welcome. Best, Patric...

...9;t work with same subnet) makes me wonder if > some of my libraries are bad or something. > > At any rate, thanks for all the help. I think I've learned more trying to > figure out what's going on with this than I have in the past year. Try txdata->GatewayAddress = &IPInfo.gateway; not txdata->GatewayAddress = IPInfo.gateway; -- -Gene > On Fri, Nov 8, 2013 at 2:57 PM, H. Peter Anvin <hpa at zytor.com> wrote: >> Here is a completely untested patch if someone wants to try and take it >> for a spin?

The variable 'ok' is never used and generates a warning. Remove it. Also ntfssect.c is designed to be compiled in non Unicode mode when using MSVC compilers, so remove all ambiguity about it (LPCTSTR -> LPCSTR, use of 'A' API calls) so that it doesn't break when compiled in Unicode mode, which is what Rufus uses with MSVC. -------------- next part --------------

...> In efi/udp.c: Both updates are in core_udp_connect and core_udp_sendto > functions. > > 1. Disable UseDefaultAddress, which is not complete. Were you able to do a packet capture? Why is it incomplete on your systems? > 2. Set StationAddress and SubnetMask to correct values from IPInfo struct > because both fields are not necessarily populated. > > Signed-off-by: Jeff Sloan <jeff_sloan at selinc.com> > --- > diffstat results: > pxe.c | 16 +++++++++++++++- > udp.c | 12 ++++++++++-- > 2 files changed, 25 insertions(+), 3 deletions(-) > > C...

...t used in a proxyDHCP environment. The real DHCP Offer/Ack contains the client ip. The proxy Offer contains the server ip. We also have to grab the gateway and subnet mask. There is no single packet or location where all the addresses are contained. The most complete struct that I found is the IPInfo but even there the server ip is incorrect. So we need to either build and populate a complete struct for proxy or pull from several different packets when needed. Failing scenario/behavior for problem 2: After syslinux.efi is downloaded and execution begins, no further Ethernet communication o...

...; udata.StationPort = socket->net.efi.localport; > > - udata.UseDefaultAddress = TRUE; > + if (efi_net_def_addr) { > + udata.UseDefaultAddress = TRUE; > + } else { > + udata.UseDefaultAddress = FALSE; > + memcpy(&udata.StationAddress, &IPInfo.myip, sizeof(IPInfo.myip)); > + memcpy(&udata.StationAddress, &IPInfo.netmask, sizeof(IPInfo.netmask)); > + } > memcpy(&udata.RemoteAddress, &ip, sizeof(ip)); > udata.RemotePort = port; > udata.TimeToLive = 64; > > So don't worry abou...

...* @param:ip, the ip address > > + * @param:port, the port number, host-byte order > > + */ > > +void core_udp_connect(struct pxe_pvt_inode *socket, uint32_t ip, > > + uint16_t port) > > +{ > > > + memcpy(&udata.StationAddress, &IPInfo.myip, sizeof(IPInfo.myip)); > > + memcpy(&udata.SubnetMask, &IPInfo.netmask, sizeof(IPInfo.netmask)); > > + memcpy(&udata.RemoteAddress, &ip, sizeof(ip)); > > + udata.RemotePort = port; > > + udata.AcceptPromiscuous = TRUE; > > + > >...

...some of my libraries are bad or something. >>> >>> At any rate, thanks for all the help. I think I've learned more trying to >>> figure out what's going on with this than I have in the past year. >> >> Try >> txdata->GatewayAddress = &IPInfo.gateway; >> not >> txdata->GatewayAddress = IPInfo.gateway; > > And with this forced, it does send the requests but it may not route > properly, depending on the gateway. > > The gateway must be NULL if local or the address of the gateway if not local. > > --...

.../udp.c @@ -336,6 +336,9 @@ void core_udp_sendto(struct pxe_pvt_inode *socket, const void *data, memset(&udata, 0, sizeof(udata)); + /* Re-use the existing local port number if any */ + udata.StationPort = socket->net.efi.localport; + memcpy(&udata.StationAddress, &IPInfo.myip, sizeof(IPInfo.myip)); memcpy(&udata.SubnetMask, &IPInfo.netmask, sizeof(IPInfo.netmask)); memcpy(&udata.RemoteAddress, &ip, sizeof(ip)); @@ -373,6 +376,21 @@ void core_udp_sendto(struct pxe_pvt_inode *socket, const void *data, /* Reset */ cb_status = -1;...

I have a patch that I think may help your situation of syslinux.efi being unable to load ldlinux.e64/ldlinux.e32 (though I don't know if any of you are using an EFI ia32 platform). The basics are that we try to enable UseDefaultAddress as it helps certain clients with routing and works on numerous other clients. If we timeout on receiving a packet and have never received any packets, disable

...uite of planned providers for the network stack. B. DESCRIPTION This will introduce the following probes for the ''ip'' provider: ip:::send ip:::receive The arguments to these probes are: args[0] pktinfo_t * packet info args[1] csinfo_t * connection state info args[2] ipinfo_t * generic IP info args[3] illinfo_t * interface info args[4] ipv4info_t * IPv4 header args[5] ipv6info_t * IPv6 header The order and content has been chosen for consistency with other planned network providers, and to also leave room to accommodate future enhancements to the network st...

...es me wonder if >> some of my libraries are bad or something. >> >> At any rate, thanks for all the help. I think I've learned more trying to >> figure out what's going on with this than I have in the past year. > > Try > txdata->GatewayAddress = &IPInfo.gateway; > not > txdata->GatewayAddress = IPInfo.gateway; And with this forced, it does send the requests but it may not route properly, depending on the gateway. The gateway must be NULL if local or the address of the gateway if not local. -- -Gene >> On Fri, Nov 8, 2013 at...

...e bad or something. >>>> >>>> At any rate, thanks for all the help. I think I've learned more trying to >>>> figure out what's going on with this than I have in the past year. >>> >>> Try >>> txdata->GatewayAddress = &IPInfo.gateway; >>> not >>> txdata->GatewayAddress = IPInfo.gateway; >> >> And with this forced, it does send the requests but it may not route >> properly, depending on the gateway. >> >> The gateway must be NULL if local or the address of the gatewa...