search for: iov_len

...kernel: [<ffffffff811e3e4e>] SyS_newfstatat+0xe/0x10 Dec 25 05:35:56 machine-hostname kernel: [<ffffffff81645909>] system_call_fastpath+0x16/0x1b (5) enable "cifsFYI", observed cifs.ko keeps printing the logs below: [ 3058.820504] fs/cifs/file.c: 7: iov_base=ffff8800129e6000 iov_len=4096 [ 3058.820506] fs/cifs/file.c: 8: iov_base=ffff88003d4e3000 iov_len=4096 [ 3058.820508] fs/cifs/file.c: 9: iov_base=ffff8800109cb000 iov_len=4096 [ 3058.820510] fs/cifs/file.c: 10: iov_base=ffff88003b56b000 iov_len=4096 [ 3058.820512] fs/cifs/file.c: 11: iov_base=ffff880013bd6000 iov_len=4096...

...] dyn[yes:34] at ../source3/smbd/smb2_getinfo.c:200 [2014/03/28 15:41:16.619192, 10, pid=4038, effective(3000019, 100), real(3000019, 0)] ../source3/smbd/smb2_server.c:2467(smbd_smb2_request_dispatch_immediate) smbd_smb2_request_dispatch_immediate: idx[5] of 9 vectors req->in.vector[0].iov_len = 0 req->in.vector[1].iov_len = 0 req->in.vector[2].iov_len = 64 req->in.vector[3].iov_len = 40 req->in.vector[4].iov_len = 8 req->in.vector[5].iov_len = 0 req->in.vector[6].iov_len = 64 req->in.vector[7].iov_len = 40...

...= r->next; } else { r = qemu_malloc(sizeof(SCSIRequest)); - r->iov.iov_base = qemu_memalign(512, SCSI_DMA_BUF_SIZE); + r->iov = NULL; } r->bus = scsi_bus_from_device(d); r->dev = s; r->tag = tag; r->sector_count = 0; - r->iov.iov_len = 0; r->aiocb = NULL; r->status = 0; @@ -126,6 +126,17 @@ static void scsi_remove_request(SCSIRequest *r) free_requests = r; } +static void *scsi_allocate_iovec(SCSIRequest *r) { + if (!r->iov) { + r->iov = qemu_malloc(sizeof(struct iovec)); + if (!r->iov) +...

...= r->next; } else { r = qemu_malloc(sizeof(SCSIRequest)); - r->iov.iov_base = qemu_memalign(512, SCSI_DMA_BUF_SIZE); + r->iov = NULL; } r->bus = scsi_bus_from_device(d); r->dev = s; r->tag = tag; r->sector_count = 0; - r->iov.iov_len = 0; r->aiocb = NULL; r->status = 0; @@ -126,6 +126,17 @@ static void scsi_remove_request(SCSIRequest *r) free_requests = r; } +static void *scsi_allocate_iovec(SCSIRequest *r) { + if (!r->iov) { + r->iov = qemu_malloc(sizeof(struct iovec)); + if (!r->iov) +...

...e = (void *)vhost_get_vq_desc(&net->dev, vq, @@ -148,25 +146,45 @@ "out %d, int %d\n", out, in); break; } + if (vq->guest_hlen > vq->sock_hlen) { + if (msg.msg_iov[0].iov_len == vq->guest_hlen) + msg.msg_iov[0].iov_len = vq->sock_hlen; + else if (out == ARRAY_SIZE(vq->iov)) + vq_err(vq, "handle_tx iov overflow!"); + else { +...

...e = (void *)vhost_get_vq_desc(&net->dev, vq, @@ -148,25 +146,45 @@ "out %d, int %d\n", out, in); break; } + if (vq->guest_hlen > vq->sock_hlen) { + if (msg.msg_iov[0].iov_len == vq->guest_hlen) + msg.msg_iov[0].iov_len = vq->sock_hlen; + else if (out == ARRAY_SIZE(vq->iov)) + vq_err(vq, "handle_tx iov overflow!"); + else { +...

Hello, I have a question because POSIX ACL with SMB2 max protocol does not work properly.Did you test VFS xattr acls with SMB2 max protocol? Is it working corectly? Best regards/Adrian Berlin --

...vhost/vsock.c b/drivers/vhost/vsock.c index bb5fc0e9fbc2..9951b7e661f6 100644 --- a/drivers/vhost/vsock.c +++ b/drivers/vhost/vsock.c @@ -94,7 +94,7 @@ vhost_transport_do_send_pkt(struct vhost_vsock *vsock, struct iov_iter iov_iter; unsigned out, in; size_t nbytes; - size_t len; + size_t iov_len, payload_len; int head; spin_lock_bh(&vsock->send_pkt_list_lock); @@ -139,8 +139,18 @@ vhost_transport_do_send_pkt(struct vhost_vsock *vsock, break; } - len = iov_length(&vq->iov[out], in); - iov_iter_init(&iov_iter, READ, &vq->iov[out], in, len); + payl...

...gt;len, &iov_iter); - if (nbytes != pkt->len) { - virtio_transport_free_pkt(pkt); - vq_err(vq, "Faulted on copying pkt buf\n"); - break; + remain_len = pkt->len; + for (i = 0; i < pkt->nr_vecs; i++) { + int tmp_len; + + tmp_len = min(remain_len, pkt->vec[i].iov_len); + nbytes = copy_to_iter(pkt->vec[i].iov_base, tmp_len, &iov_iter); + if (nbytes != tmp_len) { + virtio_transport_free_pkt(pkt); + vq_err(vq, "Faulted on copying pkt buf\n"); + break; + } + + remain_len -= tmp_len; } vhost_add_used_n(vq, vq->heads, headc...

...gt;len, &iov_iter); - if (nbytes != pkt->len) { - virtio_transport_free_pkt(pkt); - vq_err(vq, "Faulted on copying pkt buf\n"); - break; + remain_len = pkt->len; + for (i = 0; i < pkt->nr_vecs; i++) { + int tmp_len; + + tmp_len = min(remain_len, pkt->vec[i].iov_len); + nbytes = copy_to_iter(pkt->vec[i].iov_base, tmp_len, &iov_iter); + if (nbytes != tmp_len) { + virtio_transport_free_pkt(pkt); + vq_err(vq, "Faulted on copying pkt buf\n"); + break; + } + + remain_len -= tmp_len; } vhost_add_used_n(vq, vq->heads, headc...

...tio_transport_free_pkt(pkt); >> - vq_err(vq, "Faulted on copying pkt buf\n"); >> - break; >> + remain_len = pkt->len; >> + for (i = 0; i < pkt->nr_vecs; i++) { >> + int tmp_len; >> + >> + tmp_len = min(remain_len, pkt->vec[i].iov_len); >> + nbytes = copy_to_iter(pkt->vec[i].iov_base, tmp_len, &iov_iter); >> + if (nbytes != tmp_len) { >> + virtio_transport_free_pkt(pkt); >> + vq_err(vq, "Faulted on copying pkt buf\n"); >> + break; >> + } >> + >> +...

...tio_transport_free_pkt(pkt); >> - vq_err(vq, "Faulted on copying pkt buf\n"); >> - break; >> + remain_len = pkt->len; >> + for (i = 0; i < pkt->nr_vecs; i++) { >> + int tmp_len; >> + >> + tmp_len = min(remain_len, pkt->vec[i].iov_len); >> + nbytes = copy_to_iter(pkt->vec[i].iov_base, tmp_len, &iov_iter); >> + if (nbytes != tmp_len) { >> + virtio_transport_free_pkt(pkt); >> + vq_err(vq, "Faulted on copying pkt buf\n"); >> + break; >> + } >> + >> +...

...t;sk, SOCK_ZEROCOPY); } -/* Pop first len bytes from iovec. Return number of segments used. */ -static int move_iovec_hdr(struct iovec *from, struct iovec *to, - size_t len, int iov_count) -{ - int seg = 0; - size_t size; - - while (len && seg < iov_count) { - size = min(from->iov_len, len); - to->iov_base = from->iov_base; - to->iov_len = size; - from->iov_len -= size; - from->iov_base += size; - len -= size; - ++from; - ++to; - ++seg; - } - return seg; -} -/* Copy iovec entries for len bytes from iovec. */ -static void copy_iovec_hdr(const struct iovec *...

...t;sk, SOCK_ZEROCOPY); } -/* Pop first len bytes from iovec. Return number of segments used. */ -static int move_iovec_hdr(struct iovec *from, struct iovec *to, - size_t len, int iov_count) -{ - int seg = 0; - size_t size; - - while (len && seg < iov_count) { - size = min(from->iov_len, len); - to->iov_base = from->iov_base; - to->iov_len = size; - from->iov_len -= size; - from->iov_base += size; - len -= size; - ++from; - ++to; - ++seg; - } - return seg; -} -/* Copy iovec entries for len bytes from iovec. */ -static void copy_iovec_hdr(const struct iovec *...

On 06/11/2024 08:04, Michael Tokarev wrote: > Take a closer look at strace.? You've already noticed > the recv() call takes a noticeable time, - find all of > them. > > BTW, in your strace output you omitted some important > pieces, for example, it isn't visible what FD#5 corresponds > to, since you omitted its creation/open. > > The prob might not be the (host)

...Here's the output of "strace --relative-timestamps -o strace.smbclient.log smbclient -NL 127.0.0.1" : > > https://pastebin.com/raw/v3hFY5DB So, as you can see yourself, there are 2 interesting places (adding some context): 0.000442 writev(4, [{iov_base="\0\0\0\204", iov_len=4}, {iov_base="\376SMB@\0\1\0\0\0\0\0\5\0\1\0\20\0\0\0\0\0\0\0\4\0\0\0\0\0\0\0"..., iov_len=64}, {iov_base="9\0\0\0\2\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\237\1\2\0\0\0\0\0"..., iov_len=56}, {iov_base="s\0r\0v\0s\0v\0c\0", iov_len=12}], 4) = 136 8.996581 recv(4, &quo...

...pkt->len) { > - virtio_transport_free_pkt(pkt); > - vq_err(vq, "Faulted on copying pkt buf\n"); > - break; > + remain_len = pkt->len; > + for (i = 0; i < pkt->nr_vecs; i++) { > + int tmp_len; > + > + tmp_len = min(remain_len, pkt->vec[i].iov_len); > + nbytes = copy_to_iter(pkt->vec[i].iov_base, tmp_len, &iov_iter); > + if (nbytes != tmp_len) { > + virtio_transport_free_pkt(pkt); > + vq_err(vq, "Faulted on copying pkt buf\n"); > + break; > + } > + > + remain_len -= tmp_len; > }...

...gt;> - vq_err(vq, "Faulted on copying pkt buf\n"); > >> - break; > >> + remain_len = pkt->len; > >> + for (i = 0; i < pkt->nr_vecs; i++) { > >> + int tmp_len; > >> + > >> + tmp_len = min(remain_len, pkt->vec[i].iov_len); > >> + nbytes = copy_to_iter(pkt->vec[i].iov_base, tmp_len, &iov_iter); > >> + if (nbytes != tmp_len) { > >> + virtio_transport_free_pkt(pkt); > >> + vq_err(vq, "Faulted on copying pkt buf\n"); > >> + break; > >>...

...tv_sec=1730806466, tv_nsec=500839090}) = 0 0.000555 clock_gettime64(CLOCK_REALTIME, {tv_sec=1730806466, tv_nsec=501842685}) = 0 0.000997 epoll_ctl(3, EPOLL_CTL_ADD, 5, {events=EPOLLIN|EPOLLERR|EPOLLHUP, data={u32=37735016, u64=37735016}}) = 0 0.000889 writev(5, [{iov_base="\0\0\0\204", iov_len=4}, {iov_base="\376SMB@\0\1\0\0\0\0\0\5\0\1\0\20\0\0\0\0\0\0\0\4\0\0\0\0\0\0\0"..., iov_len=64}, {iov_base="9\0\0\0\2\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\237\1\2\0\0\0\0\0"..., iov_len=56}, {iov_base="s\0r\0v\0s\0v\0c\0", iov_len=12}], 4) = 136 0.005154 clock_get...

Currently virtio-net code relys on the layout of descriptor, this patchset removed the assumptions and introduced a control command to set mac address. Last patch is a trivial renaming. V2: check guest's iov_len V3: fix of migration compatibility make mac field in config space read-only when new feature is acked V4: add fix of descriptor layout assumptions, trivial rename V5: fix endianness after iov_to_buf copy Amos Kong (2): virtio-net: introduce a new macaddr control virtio-net: rename ctrl rx...