search for: iord

...ars. On investigating cluster:::plot.silhouette, I came across this part: if (do.col.sort && (lc <- length(col)) > 1) { if (lc == k) col <- col[cli] else if (lc != n) col <- rep(col, length = n) col <- rev(col[attr(x, "iOrd")]) } Since attr(x, "iOrd") was NULL, I would end up with an empty col vector which explained why I didn't get any bars. When I removed [attr(x, "iOrd")], the plot worked how I think it's meant to. The silhouette object I used was created from one obtained fr...

Hi Xiantao, I general I think the code in this patch is fine. I have a couple of nit-picking comments: > + if (target_mask&0x1) { The formatting here isn't quite what most of the kernel does. It would be better if you added spaces so it's a little easier to read, ie: if (target_mask & 0x1) { > + p = &__per_cpu_idtrs[cpu][0][0]; > + for (i = IA64_TR_ALLOC_BASE;

Hi Xiantao, I general I think the code in this patch is fine. I have a couple of nit-picking comments: > + if (target_mask&0x1) { The formatting here isn't quite what most of the kernel does. It would be better if you added spaces so it's a little easier to read, ie: if (target_mask & 0x1) { > + p = &__per_cpu_idtrs[cpu][0][0]; > + for (i = IA64_TR_ALLOC_BASE;