search for: iommu_device

...ould be in the probe_device() call-back, no? > I tried to move all the initialization from xlate() to device_probe(), > but such approach doesn't work. device_probe() is exynos_sysmmu_probe(), then yes, this is called before any of the xlate() calls are made. Would it work to keep the iommu_device structures in the sysmmus and also create them for the owners? This isn't really a nice solution but should work the the IOMMU driver until there is a better way to fix this. Regards, Joerg

...e umem > > > > 5) generate diffs of memory table and using IOMMU API to setup the dma > > > > mapping in this method > > > > > > > > For 1), I'm not sure parent is sufficient for to doing this or need to > > > > introduce new API like iommu_device in mdev. > > > Agree. We may also need to introduce something like the iommu_device. > > > > > Would it be better for the map/umnap logic to happen inside each device ? > > Devices that needs the IOMMU will call iommu APIs from inside the driver callback. > >...

...3..6cfe7799dc8c 100644 --- a/drivers/iommu/iommu.c +++ b/drivers/iommu/iommu.c @@ -174,6 +174,36 @@ static void dev_iommu_free(struct device *dev) dev->iommu = NULL; } +static int __iommu_probe_device(struct device *dev) +{ + const struct iommu_ops *ops = dev->bus->iommu_ops; + struct iommu_device *iommu_dev; + struct iommu_group *group; + int ret; + + iommu_dev = ops->probe_device(dev); + if (IS_ERR(iommu_dev)) + return PTR_ERR(iommu_dev); + + dev->iommu->iommu_dev = iommu_dev; + + group = iommu_group_get_for_dev(dev); + if (!IS_ERR(group)) { + ret = PTR_ERR(group); + goto out_r...

...n And then: 3) pin pages through GUP and do proper accounting 4) store GPA->HPA mapping in the umem 5) generate diffs of memory table and using IOMMU API to setup the dma mapping in this method For 1), I'm not sure parent is sufficient for to doing this or need to introduce new API like iommu_device in mdev. > + return -ENOTSUPP; > +} > + > +static int vhost_vdpa_open(struct inode *inode, struct file *filep) > +{ > + struct vhost_vdpa *v; > + struct vhost_dev *dev; > + struct vhost_virtqueue **vqs; > + int nvqs, i, r, opened; > + > + v = vhost_vdpa_get_from_m...

...n And then: 3) pin pages through GUP and do proper accounting 4) store GPA->HPA mapping in the umem 5) generate diffs of memory table and using IOMMU API to setup the dma mapping in this method For 1), I'm not sure parent is sufficient for to doing this or need to introduce new API like iommu_device in mdev. > + return -ENOTSUPP; > +} > + > +static int vhost_vdpa_open(struct inode *inode, struct file *filep) > +{ > + struct vhost_vdpa *v; > + struct vhost_dev *dev; > + struct vhost_virtqueue **vqs; > + int nvqs, i, r, opened; > + > + v = vhost_vdpa_get_from_m...

...the code (during bus probing) first adds all devices to their respective IOMMU group before it determines the default domain type and then allocates it for the group. It turned out that this required to remove the calls of iommu_group_get_for_dev() from the IOMMU drivers. While at it, the calls to iommu_device_link()/unlink() where also moved out of the drivers, which required a different interface than add_device()/remove_device(). The result is the new probe_device()/release_device() interface, where the driver just does its own setup and then returns the iommu_device which belongs to the device being...

...the code (during bus probing) first adds all devices to their respective IOMMU group before it determines the default domain type and then allocates it for the group. It turned out that this required to remove the calls of iommu_group_get_for_dev() from the IOMMU drivers. While at it, the calls to iommu_device_link()/unlink() where also moved out of the drivers, which required a different interface than add_device()/remove_device(). The result is the new probe_device()/release_device() interface, where the driver just does its own setup and then returns the iommu_device which belongs to the device being...

...y >>): In file included from include/linux/vfio_mdev.h:10:0, from <command-line>:0: >> include/linux/mdev.h:25:34: warning: 'struct device' declared inside parameter list will not be visible outside of this definition or declaration int mdev_set_iommu_device(struct device *dev, struct device *iommu_device); ^~~~~~ >> include/linux/mdev.h:62:27: warning: 'struct kobject' declared inside parameter list will not be visible outside of this definition or declaration int (*create)(struct kobject *ko...

...y >>): In file included from include/linux/vfio_mdev.h:10:0, from <command-line>:0: >> include/linux/mdev.h:25:34: warning: 'struct device' declared inside parameter list will not be visible outside of this definition or declaration int mdev_set_iommu_device(struct device *dev, struct device *iommu_device); ^~~~~~ >> include/linux/mdev.h:62:27: warning: 'struct kobject' declared inside parameter list will not be visible outside of this definition or declaration int (*create)(struct kobject *ko...

Hi, here is the second version of this patch-set. The first version with some more introductory text can be found here: https://lore.kernel.org/lkml/20200407183742.4344-1-joro at 8bytes.org/ Changes v1->v2: * Rebased to v5.7-rc1 * Re-wrote the arm-smmu changes as suggested by Robin Murphy * Re-worked the Exynos patches to hopefully not break the driver anymore * Fixed a missing

Hi, here is the second version of this patch-set. The first version with some more introductory text can be found here: https://lore.kernel.org/lkml/20200407183742.4344-1-joro at 8bytes.org/ Changes v1->v2: * Rebased to v5.7-rc1 * Re-wrote the arm-smmu changes as suggested by Robin Murphy * Re-worked the Exynos patches to hopefully not break the driver anymore * Fixed a missing

Hi, here is the third version of this patch-set. Older versions can be found here: v1: https://lore.kernel.org/lkml/20200407183742.4344-1-joro at 8bytes.org/ (Has some more introductory text) v2: https://lore.kernel.org/lkml/20200414131542.25608-1-joro at 8bytes.org/ Changes v2 -> v3: * Rebased v5.7-rc3 * Added a missing iommu_group_put() as reported by Lu Baolu. * Added a

...; 4) store GPA->HPA mapping in the umem >>> 5) generate diffs of memory table and using IOMMU API to setup the dma >>> mapping in this method >>> >>> For 1), I'm not sure parent is sufficient for to doing this or need to >>> introduce new API like iommu_device in mdev. >> Agree. We may also need to introduce something like the iommu_device. >> > Would it be better for the map/umnap logic to happen inside each device ? > Devices that needs the IOMMU will call iommu APIs from inside the driver callback. Technically, this can work. But i...

...t; >>> 5) generate diffs of memory table and using IOMMU API to setup the > > >>> dma mapping in this method > > >>> > > >>> For 1), I'm not sure parent is sufficient for to doing this or need > > >>> to introduce new API like iommu_device in mdev. > > >> Agree. We may also need to introduce something like the iommu_device. > > >> > > > Would it be better for the map/umnap logic to happen inside each device ? > > > Devices that needs the IOMMU will call iommu APIs from inside the driver >...

...em >>>>> 5) generate diffs of memory table and using IOMMU API to setup the >>>>> dma mapping in this method >>>>> >>>>> For 1), I'm not sure parent is sufficient for to doing this or need >>>>> to introduce new API like iommu_device in mdev. >>>> Agree. We may also need to introduce something like the iommu_device. >>>> >>> Would it be better for the map/umnap logic to happen inside each device ? >>> Devices that needs the IOMMU will call iommu APIs from inside the driver >> call...

...u_init_device(struct device *dev) if (devid < 0) return devid; - iommu = amd_iommu_rlookup_table[devid]; - dev_data = find_dev_data(devid); if (!dev_data) return -ENOMEM; @@ -391,8 +377,6 @@ static int iommu_init_device(struct device *dev) dev->archdata.iommu = dev_data; - iommu_device_link(&iommu->iommu, dev); - return 0; } @@ -410,7 +394,7 @@ static void iommu_ignore_device(struct device *dev) setup_aliases(dev); } -static void iommu_uninit_device(struct device *dev) +static void amd_iommu_uninit_device(struct device *dev) { struct iommu_dev_data *dev_data;...

...In file included from include/linux/vfio_mdev.h:10:0, > from <command-line>:0: > >> include/linux/mdev.h:25:34: warning: 'struct device' declared inside parameter list will not be visible outside of this definition or declaration > int mdev_set_iommu_device(struct device *dev, struct device *iommu_device); > ^~~~~~ > >> include/linux/mdev.h:62:27: warning: 'struct kobject' declared inside parameter list will not be visible outside of this definition or declaration > int (*create)(str...

...eb7..42e1ee7e5197 100644 --- a/drivers/iommu/arm-smmu-v3.c +++ b/drivers/iommu/arm-smmu-v3.c @@ -2914,27 +2914,26 @@ static bool arm_smmu_sid_in_range(struct arm_smmu_device *smmu, u32 sid) static struct iommu_ops arm_smmu_ops; -static int arm_smmu_add_device(struct device *dev) +static struct iommu_device *arm_smmu_probe_device(struct device *dev) { int i, ret; struct arm_smmu_device *smmu; struct arm_smmu_master *master; struct iommu_fwspec *fwspec = dev_iommu_fwspec_get(dev); - struct iommu_group *group; if (!fwspec || fwspec->ops != &arm_smmu_ops) - return -ENODEV; + return...

...for looking into this. > > On Wed, Apr 08, 2020 at 01:09:40PM +0100, Robin Murphy wrote: >> For a hot-pluggable bus where logical devices may share Stream IDs (like >> fsl-mc), this could happen: >> >> create device A >> iommu_probe_device(A) >> iommu_device_group(A) -> alloc group X >> create device B >> iommu_probe_device(B) >> iommu_device_group(A) -> lookup returns group X >> ... >> iommu_remove_device(A) >> delete device A >> create device C >> iommu_probe_device(C) &g...

...Subject: [PATCH] iommu/exynos: Get rid of 'struct exynos_iommu_owner' Remove 'struct exynos_iommu_owner' and replace it with a single-linked list of 'struct sysmmu_drvdata'. The first item in the list acts as a replacement for the previous exynos_iommu_owner structure. The iommu_device member of the first list item is reported to the IOMMU core code for the master device. Signed-off-by: Joerg Roedel <jroedel at suse.de> --- drivers/iommu/exynos-iommu.c | 155 ++++++++++++++++++++--------------- 1 file changed, 88 insertions(+), 67 deletions(-) diff --git a/drivers/iommu/...