search for: ioloop_tim

...of these in 2.1.1): 1) src/lib-index/mail-cache-fields.c (comparison between two last_used fields) mail-cache-fields.c: In function 'mail_cache_header_fields_read': mail-cache-fields.c:406: warning: comparison between signed and unsigned 2) src/director/user-directory.c (comparison with ioloop_time) user-directory.c: In function 'user_directory_user_is_recently_updated': user-directory.c:147: warning: comparison between signed and unsigned 3) src/replication/replicator/replicator-brain.c (comparison with ioloop_time) replicator-brain.c: In function 'doveadm_replicate': repl...

My base concern may be illustrated with the help of that simple telnet session: # telnet 127.0.0.1 imap Trying 127.0.0.1... Connected to localhost. Escape character is '^]'. * OK [CAPABILITY IMAP4rev1 LITERAL+ SASL-IR LOGIN-REFERRALS ID ENABLE AUTH=PLAIN] Dovecot ready. a1 login testuser ****** a1 OK [CAPABILITY IMAP4rev1 LITERAL+ SASL-IR LOGIN-REFERRALS ID ENABLE SORT

...e. Can you figure out how big the window should be? Thanks, Anders. --- ./src/lib/ioloop.c-orig 2008-06-20 10:45:54.000000000 +0200 +++ ./src/lib/ioloop.c 2008-06-20 10:47:36.000000000 +0200 @@ -230,8 +230,13 @@ struct timeval tv, tv_call; unsigned int t_id; - if (gettimeofday(&ioloop_timeval, &ioloop_timezone) < 0) - i_fatal("gettimeofday(): %m"); + /* The Linux gettimeofday() will sometimes jump forward + * by approximately 4398 seconds. Ignore that reading. */ + do { + if (gettimeofday(&ioloop_timeval, &ioloop_timezone) < 0) + i_fatal("gettim...

I hacked some command line options into imaptest. I dont think I broke it.. Place into dovecot-source root as usual and compile with: gcc imaptest.c -o imaptest -Wall -W -I. -Isrc/lib -DHAVE_CONFIG_H src/lib/liblib.a As per Timo's instructions. # imaptest -h imaptest [USER at IP:PORTNO] [pass=PASSWORD] [mbox=MBOX] [clients=CC] [msgs=NMSG] [use_authenticate] [PORTNO] USER = template for

...0) + if (link(tmp_path, new_path) == 0) { ret = 0; - else { + if (ctx->received_date != (time_t)-1) { + struct utimbuf buf; + /* set the received_date by modifying mtime */ + buf.actime = ioloop_time; + buf.modtime = ctx->received_date; + if (utime(new_path, &buf) < 0) { + ctx->failed = TRUE; + mail_storage_set_critical(STORAGE(ctx->mbox->storage), +...

As promised, here it is finally. v1.0 is getting nearer and I want people to start looking at Dovecot's sources. Getting some more help with development would be nice, but I'd also like to hear if there are any hidden bugs in the code. So, one week from now I'll start offering 1000 EUR for the first person to point out a remotely exploitable security hole in Dovecot. See

I went from a nightly of about 20051117 or so (about alpha4 generation) to 1.0beta1 yesterday, and dovecot is now spinning the CPU furiously apparently every ~10 minutes per: Jan 18 13:04:36 server dovecot: SSL parameters regeneration completed Jan 18 13:14:14 server dovecot: SSL parameters regeneration completed Jan 18 13:24:00 server dovecot: SSL parameters regeneration completed Jan 18

...n from the same ip is considered secured. I'd rebuild Dovecot with the following patch: --- dovecot-1.0.10/src/pop3-login/client.c.orig 2008-01-05 00:44:14.000000000 -0500 +++ dovecot-1.0.10/src/pop3-login/client.c 2008-01-05 00:44:30.000000000 -0500 @@ -331,7 +331,7 @@ client->created = ioloop_time; client->refcount = 1; client->common.tls = ssl; - client->common.secured = ssl || net_ip_compare(ip, local_ip); + client->common.secured = ssl; client->common.local_ip = *local_ip; client->common.ip = *ip; --- but still not able to make it not accept AUTH PLAIN authen...

...e_dict = TRUE; - } else if (strcmp(value, "0") == 0) { + } else if (ret > 0 && strcmp(value, "0") == 0) { /* we're saving the first mail to this mailbox. ioloop_time may not be exactly the first message's save time, but a few seconds -- Michal Grzedzicki -------------- next part -------------- A non-text attachment was scrubbed... Name: dovecot-2.1.5-expire.diff Type: application/octet-stream Size: 693 bytes Desc: not...

Hi there, I was having lots of trouble with the normal expire plugin so I decided to try and come up with a plugin that handles the trash directory in the same way as Courier (when the user logs out it should clean messages from the trash that have been there for more than X days.) I used the expire and trash plugins as a guide but there are probably a number of things done wrong here

...tion-log-file.c 2009-10-15 21:26:13.000000000 -0500 +++ b/src/lib-index/mail-transaction-log-file.c 2009-10-27 10:35:58.000000000 -0500 @@ -189,7 +189,7 @@ hdr->hdr_size = sizeof(struct mail_transaction_log_header); hdr->indexid = log->index->indexid; hdr->create_stamp = ioloop_time; -#ifndef WORDS_BIGENDIAN +#if !WORDS_BIGENDIAN hdr->compat_flags |= MAIL_INDEX_COMPAT_LITTLE_ENDIAN; #endif @@ -404,7 +404,7 @@ /* we have compatibility flags */ enum mail_index_header_compat_flags compat_flags = 0; -#ifndef WORDS_BIGENDIAN +#if !WORDS_BIGENDIAN compat_flags...

...ax. input buffer size. @@ -392,7 +407,7 @@ client->input_pending = TRUE; if (client->output->closed) - client_destroy(client); + client_destroy(client, "Disconnected (output closed)"); } int _client_output(void *context) @@ -404,7 +419,7 @@ client->last_output = ioloop_time; if ((ret = o_stream_flush(client->output)) < 0) { - client_destroy(client); + client_destroy(client, "Disconnect (output)"); return 1; } @@ -449,14 +464,14 @@ o_stream_get_buffer_used_size(my_client->output) > 0 && idle_time >= CLIENT_OUTP...

...trcmp(cmd, "QUIT") == 0) @@ -228,6 +232,15 @@ static void client_destroy_oldest(void) } } +static char *get_apop_challenge(void) +{ + if (auth_client_find_mech(auth_client, "APOP")) { + hostpid_init(); + return i_strdup_printf("<%s.%s@%s>", my_pid, dec2str(ioloop_time), my_hostname); + } else + return NULL; +} + struct client *client_create(int fd, int ssl, const struct ip_addr *local_ip, const struct ip_addr *ip) { @@ -265,7 +278,8 @@ struct client *client_create(int fd, int main_ref(); - client_send_line(client, "+OK " PACKAGE &quo...

The attached patch makes the local IP address to which the client connected available to the authentication modules; i.e., the local IP address is available for substitution as %i for the mysql and pgsql modules. We needed this feature to support thousands of our legacy accounts which are authenticated by username/local_part (not the full email address) and IP address (one per domain). Timo,

...TYPE(mailbox_cache_field) local_sorted, remote_sorted, changes; @@ -630,7 +647,8 @@ local_fields = array_get(&local_sorted, &local_count); remote_fields = array_get(&remote_sorted, &remote_count); t_array_init(&changes, local_count + remote_count); - drop_older_timestamp = ioloop_time - MAIL_CACHE_FIELD_DROP_SECS; + drop_older_timestamp = ioloop_time - + box->index->optimization_set.cache.unaccessed_field_drop_secs; diff -Nru dovecot-2.2.33.2/src/doveadm/dsync/dsync-mailbox.c dovecot-2.2.34/src/doveadm/dsync/dsync-mailbox.c --- dovecot-2.2.33.2/src/doveadm/dsync/ds...

...&timezone_offset)) { + client_send_tagline(cmd, "BAD Invalid internal date."); + if (keywords != NULL) + mailbox_keywords_free(ctx->box, &keywords); + return catenate_cancel(ctx, nonsync); + } + + if (internal_date != (time_t)-1 && + internal_date > ioloop_time + INTERNALDATE_MAX_FUTURE_SECS) { + internal_date = (time_t)-1; + timezone_offset = 0; + } + } + + if (args->type != IMAP_ARG_ATOM || + strcasecmp(args->_data.str, "CATENATE") != 0 || + args[1].type != IMAP_ARG_LIST) { + // do not use client_send_command_error() + cl...