search for: io_ur

Heming reported a BUG when using io_uring doing link-cp on ocfs2. [1] Do the following steps can reproduce this BUG: mount -t ocfs2 /dev/vdc /mnt/ocfs2 cp testfile /mnt/ocfs2/ ./link-cp /mnt/ocfs2/testfile /mnt/ocfs2/testfile.1 umount /mnt/ocfs2 Then umount will fail, and it outputs: umount: /mnt/ocfs2: target is busy. While tracing...

On Fri, Sep 08, 2023 at 08:44:45AM -0600, Jens Axboe wrote: > On 9/8/23 8:34 AM, Ming Lei wrote: > > On Fri, Sep 08, 2023 at 07:49:53AM -0600, Jens Axboe wrote: > >> On 9/8/23 3:30 AM, Ming Lei wrote: > >>> diff --git a/io_uring/io_uring.c b/io_uring/io_uring.c > >>> index ad636954abae..95a3d31a1ef1 100644 > >>> --- a/io_uring/io_uring.c > >>> +++ b/io_uring/io_uring.c > >>> @@ -1930,6 +1930,10 @@ void io_wq_submit_work(struct io_wq_work *work) > >>> } >...

On Fri, Sep 08, 2023 at 08:44:45AM -0600, Jens Axboe wrote: > On 9/8/23 8:34 AM, Ming Lei wrote: > > On Fri, Sep 08, 2023 at 07:49:53AM -0600, Jens Axboe wrote: > >> On 9/8/23 3:30 AM, Ming Lei wrote: > >>> diff --git a/io_uring/io_uring.c b/io_uring/io_uring.c > >>> index ad636954abae..95a3d31a1ef1 100644 > >>> --- a/io_uring/io_uring.c > >>> +++ b/io_uring/io_uring.c > >>> @@ -1930,6 +1930,10 @@ void io_wq_submit_work(struct io_wq_work *work) > >>> } >...

On Fri, May 01, 2020 at 09:27:58PM +0200, A L via samba wrote: > > Jeremy. > I did not use a command line, but rather File Explorer > 1) In File explorer, go to \\SAMBA\share_io_uring\ > 2) Select folder "test2-ro" and choose copy > 3) Paste to a local drive > > The amount of files not working seems to vary, but usually within the 10 > first copied files. You can download a copy of the source test files from > https://mirrors.tnonline.net/?dir=sam...

On 01/05/2020 14:35, A L via samba wrote: > True.. I just copied from another share. Would that have a impact on > the current problem with io_uring? I do not know, I'll leave that up to Jeremy, but it has to be worth trying without the lines. Rowland

On 2020-05-01 22:04, Jeremy Allison via samba wrote: > On Fri, May 01, 2020 at 09:27:58PM +0200, A L via samba wrote: >>> Jeremy. >> I did not use a command line, but rather File Explorer >> 1) In File explorer, go to \\SAMBA\share_io_uring\ >> 2) Select folder "test2-ro" and choose copy >> 3) Paste to a local drive >> >> The amount of files not working seems to vary, but usually within the 10 >> first copied files. You can download a copy of the source test files from >> https://mirror...

On Sat, May 02, 2020 at 11:34:41AM +0200, A L wrote: > ######## > I also tried various combinations of io_uring settings. > > io_uring:sqpoll = true/false > io_uring:num_entries = 2, 4, 8, 64, 128 (default), 256 > > Between each test i do "echo 3 > /proc/sys/vm/drop_caches" and restart the > samba service. > > One difference I noticed is that there is now only one [...

Hello, Using Samba 4.12.1 with kernel 5.6.7 on Gentoo Linux, I wanted to test the new vfs_io_uring module. * Stand-alone Samba server acting as NAS for home setup. * /media/usb-backup is a mounted read-only btrfs filesystem. * Samba share exported as: ===== smb.conf ===== [global] ??? log level = 1 ??? workgroup = WORKGROUP ??? netbios name = NAS ??? server string = Samba Server ??? se...

...ocol = SMB3_11 #?? max protocol = SMB2 # Windows 10 clients do not want to connect to SMB2 ??? log file = /var/log/samba/%I.log ??? max log size = 10240 ??? security = user ??? passdb backend = tdbsam #?? username map = /etc/samba/users.map ??? wins support = yes ??? dns proxy = yes [share_io_uring] ??? comment = USB Backup - Media files ??? path = /media/usb-backup ??? writeable = no ??? browseable = yes ??? read only = yes ??? create mask = 0664 ??? directory mask = 0775 ??? guest only = Yes ??? guest ok = Yes ??? force user = nasuser ??? force group = nas ??? inherit owner =...

...m *.bin > sha256sum.txt > 4) Windows 10, file explorer, copy the 10 files to a local disk D:\test\ > 5) Verify local files in D:\test with sha256sum > 6) sha256sum was correct. > 7) redid step 4 and 5. Now sha256sum was wrong, but all 10 files had the > same (but wrong) csum! The io_uring module has a vfs_io_uring:num_entries parameter which by default is set to 128. The readv/writev requests are queued inside smbd, but the number of outstanding io_uring requests are set by io_uring_queue_init(vfs_io_uring:num_entries,...). Can you try changing that value to see if the corruption...

On 01/05/2020 13:59, A L via samba wrote: > Hi again, > > It is not always the same area. The "blank" areas seems to be early in > the files, bot not at the same offsets. > I will leave Jeremy to comment on your main problem, but you have two read only shares, which are guest only access because of these lines: ??? guest only = Yes ??? guest ok = Yes So why do you

...May 01, 2020 at 05:07:17PM +0200, A L via samba wrote: >> On 2020-05-01 15:59, Rowland penny via samba wrote: >>> On 01/05/2020 14:35, A L via samba wrote: >>>> True.. I just copied from another share. Would that have a impact on >>>> the current problem with io_uring? >>> I do not know, I'll leave that up to Jeremy, but it has to be worth >>> trying without the lines. >>> >>> Rowland >>> >> I removed the unnecessary entries and also removed the btrfs vfs module. >> Also tested to move the file from...

...Fri, May 01, 2020 at 05:07:17PM +0200, A L via samba wrote: > > On 2020-05-01 15:59, Rowland penny via samba wrote: > > On 01/05/2020 14:35, A L via samba wrote: > > > True.. I just copied from another share. Would that have a impact on > > > the current problem with io_uring? > > > > I do not know, I'll leave that up to Jeremy, but it has to be worth > > trying without the lines. > > > > Rowland > > > I removed the unnecessary entries and also removed the btrfs vfs module. > Also tested to move the file from the USB d...

On Thu, Apr 30, 2020 at 10:25:49AM +0200, A L wrote: > So I did some more tests. smbclient mget does not copy in the same way > Windows Explorer does. When copying in Windows Explorer, there are many > multiple concurrent threads used to transfer the files. With smbclient mget > there are no corruptions, both locally and over the network from another > Linux machine. > > I

...` >>> #include <linux/mount.h> >>> #include <linux/string.h> >>> #include <linux/dcache.h> >>> #include <linux/path.h> >>> #include <linux/fs_struct.h> >>> #include <linux/fs.h> >>> #include <linux/io_uring_types.h> >>> >>> k:fput >>> { >>> $f = (struct file *)arg0; >>> $cnt = $f->f_count; >>> >>> if (!strncmp(comm, "link-cp", 7)) { >>> printf("\n [link-cp] fput() name:%s f_count:%lld <%p> mnt:%p...

...155c38b825def06e269fae3543395f7273104aff8eb7c8b488419d09fe *331.bin 7bff13155c38b825def06e269fae3543395f7273104aff8eb7c8b488419d09fe *332.bin ... continued with the same (wrong) csums till the end. RESULT: 23 out of 1001 files had correct csum. ================================= Test 3) 1) Remove io_uring from vfs objects in smb.confand restart Samba. 2) Copy all original files from Test 2 3) All 1001 files' csums are now correct. ================================= smb.conf: ########################### [global] ??? log level = 1 ??? workgroup = WORKGROUP ??? netbios name = SAMBA ??? ser...

...uire USER_DS to be set for kernel threads to access user address space, which is the whole purpose of kthread_use_mm, but other like x86 don't. That has lead to a huge mess where some callers are fixed up once they are tested on said architectures, while others linger around and yet other like io_uring try to do "clever" optimizations for what usually is just a trivial asignment to a member in the thread_struct for most architectures. Make kthread_use_mm set USER_DS, and kthread_unuse_mm restore to the previous value instead. Signed-off-by: Christoph Hellwig <hch at lst.de> -...

...uire USER_DS to be set for kernel threads to access user address space, which is the whole purpose of kthread_use_mm, but other like x86 don't. That has lead to a huge mess where some callers are fixed up once they are tested on said architectures, while others linger around and yet other like io_uring try to do "clever" optimizations for what usually is just a trivial asignment to a member in the thread_struct for most architectures. Make kthread_use_mm set USER_DS, and kthread_unuse_mm restore to the previous value instead. Signed-off-by: Christoph Hellwig <hch at lst.de> A...

On Mon, Apr 27, 2020 at 10:27:17AM +0200, A L via samba wrote: > > On 2020-04-26 19:46, Jeremy Allison via samba wrote: > > On Sun, Apr 26, 2020 at 11:51:42AM +0200, A L via samba wrote: > > > * Connected from a Windows 10 computer over 1G ethernet. * Copy data > > > using Windows Explorer and FastCopy(1) from the Samba share to a > > > local disk. * Verify

On Mon, Apr 27, 2020 at 11:21:35PM +0200, A L wrote: > > I set up the following test case: > * Linux 5.7-rc3 (with the patch from previous mail) > * samba-4.12.1 > * gcc-9.3.0 > * liburing-0.6 > * glibc-2.30-r8 > > ================================= > Test 1) > Copy 10 10GB files. > 1) ddrescue -s 10G -v -f /dev/urandom 0.bin > 2) for((i=1;i<=10;i+=1));