Displaying 6 results from an estimated 6 matches for "invalid_selector".
2019 Nov 26
0
[PATCH common v2 1/3] options: Simplify selector parsing for --key options.
...ector)
- error (EXIT_FAILURE, errno, "strdup");
+ if (!fields)
+ error (EXIT_FAILURE, errno, "guestfs_int_split_string");
- /* 1: device */
- elem = strtok_r (selector, ":", &saveptr);
- if (!elem) {
+ if (guestfs_int_count_strings (fields) != 3) {
invalid_selector:
- error (EXIT_FAILURE, 0, "invalid selector for --key: %s", selector_orig);
+ error (EXIT_FAILURE, 0, "invalid selector for --key: %s", selector);
}
- key.device = strdup (elem);
+
+ /* 1: device */
+ key.device = strdup (fields[0]);
if (!key.device)
error (...
2019 Nov 12
0
[PATCH 2/2] options: Allow multiple --key parameters and default keys.
...ector)
- error (EXIT_FAILURE, errno, "strdup");
+ if (!fields)
+ error (EXIT_FAILURE, errno, "guestfs_int_split_string");
- /* 1: device */
- elem = strtok_r (selector, ":", &saveptr);
- if (!elem) {
+ if (guestfs_int_count_strings (fields) != 3) {
invalid_selector:
- error (EXIT_FAILURE, 0, "invalid selector for --key: %s", selector_orig);
+ error (EXIT_FAILURE, 0, "invalid selector for --key: %s", selector);
}
- key.device = strdup (elem);
+
+ /* 1: device */
+ key.device = strdup (fields[0]);
if (!key.device)
error (...
2019 Nov 12
4
[PATCH 1/2] options: Fixes and enhancements to --key parsing.
The first patch fixes a rather serious bug, the second patch allows
multiple --key parameters and default parameters.
There is a third patch to libguestfs which adds a test, coming up.
I did not yet review and fix the documentation. I think we need to
centralize it in one place because at the moment the same
documentation for --key is copy/pasted all over the tools.
Rich.
2019 Nov 26
6
[PATCH options v2 0/3] options: Allow multiple and default --key parameters.
v1:
https://www.redhat.com/archives/libguestfs/2019-November/msg00036.html
2018 Sep 19
0
[PATCH 2/2] Introduce a --key option in tools that accept keys
...+ CLEANUP_FREE char *selector = strdup (selector_orig);
+ const char *elem;
+ char *saveptr;
+ struct key_store_key key;
+
+ if (!selector)
+ error (EXIT_FAILURE, errno, "strdup");
+
+ /* 1: device */
+ elem = strtok_r (selector, ":", &saveptr);
+ if (!elem) {
+ invalid_selector:
+ error (EXIT_FAILURE, 0, "invalid selector for --key: %s", selector_orig);
+ }
+ key.device = strdup (elem);
+ if (!key.device)
+ error (EXIT_FAILURE, errno, "strdup");
+
+ /* 2: key type */
+ elem = strtok_r (NULL, ":", &saveptr);
+ if (!elem)
+ g...
2018 Sep 19
5
[PATCH 0/2] RFC: --key option for tools
Hi,
the following series adds a --key option in the majority of tools: this
makes it possible to pass LUKS credentials programmatically, avoid the
need to manually input them, or unsafely pass them via stdin.
Thanks,
Pino Toscano (2):
mltools: create a cmdline_options struct
Introduce a --key option in tools that accept keys
builder/cmdline.ml | 2 +-