search for: intrprofwrit

...ee anywhere that seeks within 'Out' to ensure that the loop there doesn't affect the ordering of the bytes written within it. > If you do see case of non-determinism, then we have a bug there which > should be fixed, but there is no need to change the iteration order of the > IntrProfWriter. > > > >> >> Generally it's important that the compiler (& I believe related tools) >> have deterministic output. Is there a reason that wouldn't be the case for >> llvm-profdata? Or have I misunderstood how the output is determined? >> >>...

I haven't tested it, but it looks to me like llvm-profdata merge (well, InstrProfWriter specifically) would not have deterministic output. Certainly the textual output iterates over FunctionData which is a StringMap of SmallDenseMaps, neither of which has deterministic iteration. The binary writing looks like it'd have similar issues - looping through these unordered maps & writing

...ry address)? It seems unlikely, but I have not checked the map's implementation in details to be sure. David > > >> If you do see case of non-determinism, then we have a bug there which >> should be fixed, but there is no need to change the iteration order of the >> IntrProfWriter. >> > >> >> >>> >>> Generally it's important that the compiler (& I believe related tools) >>> have deterministic output. Is there a reason that wouldn't be the case for >>> llvm-profdata? Or have I misunderstood how the output...