search for: introduce

...iscussions: > > "Note that in cases where none of the atomic intrinsics are used, this > model places only one restriction on IR transformations on top of what > is required for single-threaded execution: introducing a store to a > byte which might not otherwise be stored to can introduce undefined > behavior.... " > > Why is introducing additional loads allowed? For example, in a program > that already contains two unordered stores to a location l, if we > introduced an unordered load to l, then the load cannot see more than > one stores, it must return undef...

...>> "Note that in cases where none of the atomic intrinsics are used, this >> model places only one restriction on IR transformations on top of what >> is required for single-threaded execution: introducing a store to a >> byte which might not otherwise be stored to can introduce undefined >> behavior.... " >> >> Why is introducing additional loads allowed? For example, in a program >> that already contains two unordered stores to a location l, if we >> introduced an unordered load to l, then the load cannot see more than >> one stor...

On Sun, Mar 1, 2020 at 1:32 PM Michael S. Tsirkin <mst at redhat.com> wrote: > > On Sun, Mar 01, 2020 at 01:07:30PM +0200, Yuri Benditovich wrote: > > This series introduce virtio-net features VIRTIO_NET_F_RSC_EXT, > > VIRTIO_NET_F_RSS and VIRTIO_NET_F_HASH_REPORT. > > > > Changes from v1: > > __virtio -> __le > > maximal -> maximum > > minor style fixes > > > Looks good to me - sent a bit of consmetics. > > But...

...is initialized. The expection is .gem_prime_mmap. There are different > ways of how drivers implement the callback, and moving it to GEM object > functions requires a closer review for each. > > Patch #17 fixes virtgpu to use GEM object functions where possible. The > driver recently introduced a function for one of the deprecated callbacks. > > Patch #20 converts xlnx to CMA helper macros. There's no apparent reason > why the driver does the GEM setup on it's own. Using CMA helper macros > adds GEM object functions implicitly. > > With most of the GEM and PRIME...

I have hit a fairly isolated practical issue deploying the new PM, but it does point to a latent theoretical issues as well. I see various ways to address it, but want feedback from others before moving forward. The issue is that we can introduce out-of-thin-air calls to known library functions (`SimplifyLibCalls`, etc). These can be introduced in function passes (`InstCombine` in particular) and that seems highly desirable. These all look like one of these cases: 1a) Introducing a new call to an LLVM intrinsic 1b) Replacing an existing ca...

...ecause DAGCombiner is introducing an illegal node after the legalizeDAG phase. Basically this is what is going on: 1) During legalization, BR_JT gets expanded introducing a (mul x, 2). 2) After legalization (AfterLegalizeDAG), that (mul x, 2) is converted to an (shl x, 1). However, that shl node introduced is illegal, and since my custom lowering code won't run after this phase it gets into the instruction selector. I would like to know if this is really a bug or it has to be handled by the target code. I guess I could add a custom dagcombine hook for this node and revert it in my target, but I...

...is initialized. The expection is .gem_prime_mmap. > There are different ways of how drivers implement the callback, and moving > it to GEM object functions requires a closer review for each. > > Patch #18 fixes virtgpu to use GEM object functions where possible. The > driver recently introduced a function for one of the deprecated callbacks. > > Patches #7 and #20 convert i.MX's dcss and xlnx to CMA helper macros. There's > no apparent reason why the drivers do the GEM setup on their's own. Using CMA > helper macros adds GEM object functions implicitly. > >...

...> > and I agree entirely, see the following " 2 x 2 " comparison : > > > N <- 5000000000000 * 8^-(0:7) > > as.integer(N) > [1] NA NA NA NA 1220703125 152587890 19073486 2384185 > Warning message: > NAs introduced by coercion > > as.integer(-N) > [1] NA NA NA NA -1220703125 -152587890 -19073486 > [8] -2384185 > Warning message: > NAs introduced by coercion > > as.integer(as.character(N)) > [1] 2147483647 2147483647 214...

...nds with the following discussions: "Note that in cases where none of the atomic intrinsics are used, this model places only one restriction on IR transformations on top of what is required for single-threaded execution: introducing a store to a byte which might not otherwise be stored to can introduce undefined behavior.... " Why is introducing additional loads allowed? For example, in a program that already contains two unordered stores to a location l, if we introduced an unordered load to l, then the load cannot see more than one stores, it must return undef. The question is whether th...

Hi. Im exploring `opt -reg2mem` output for a simple C program (actually, that is this snippet: http://rosettacode.org/wiki/Dining_philosophers#C - compiled with clang -O1) and got two questions regarding this pass. 1. How would I tell which memory locations were introduced by the pass, and which memory locations were present in the original program? After a brief diffing of .ll files, I'd suppose that introduced "alloca"s would put their result in a variable named "somename.reg2mem". But is the ".reg2mem" suffix a reliable way to id...

...s relatively > chaotic. For example, the processing of XDP actions has two copies of similar > code. Such as page, xdp_page processing, etc. > > The purpose of this patch set is to refactor these code. Reduce the difficulty > of subsequent maintenance. Subsequent developers will not introduce new bugs > because of some complex logical relationships. > > In addition, the supporting to AF_XDP that I want to submit later will also need > to reuse the logic of XDP, such as the processing of actions, I don't want to > introduce a new similar code. In this way, I can reuse...

On Wed, Feb 05, 2020 at 03:50:14PM +0800, Jason Wang wrote: > > On 2020/2/5 ??3:15, Shahaf Shuler wrote: > > Wednesday, February 5, 2020 4:03 AM, Tiwei Bie: > > > Subject: Re: [PATCH] vhost: introduce vDPA based backend > > > > > > On Tue, Feb 04, 2020 at 11:30:11AM +0800, Jason Wang wrote: > > > > On 2020/1/31 ??11:36, Tiwei Bie wrote: > > > > > This patch introduces a vDPA based vhost backend. This backend is > > > > > built on top o...

...depth stencil view flags. Aurimas Fi?eras (1): po: Update Lithuanian translation. Brendan Shanks (2): winevulkan: Create JSON manifest and registry entry used by official Vulkan loader. winevulkan: Enable VK_KHR_get_surface_capabilities2. Charles Davis (46): ddraw/tests: Introduce compare_uint(). d3d8/tests: Introduce compare_uint(). d3d8/tests: Avoid abs() on unsigned values in compare_mode(). ddraw: Introduce a helper to convert ddraw render states to wined3d states. ddraw: Introduce a helper to convert ddraw transform states to wined3d states....

...the processing of XDP actions has two copies of similar > > > code. Such as page, xdp_page processing, etc. > > > > > > The purpose of this patch set is to refactor these code. Reduce the difficulty > > > of subsequent maintenance. Subsequent developers will not introduce new bugs > > > because of some complex logical relationships. > > > > > > In addition, the supporting to AF_XDP that I want to submit later will also need > > > to reuse the logic of XDP, such as the processing of actions, I don't want to > > > intro...

...haotic. For example, the processing of XDP actions has two copies of similar > > code. Such as page, xdp_page processing, etc. > > > > The purpose of this patch set is to refactor these code. Reduce the difficulty > > of subsequent maintenance. Subsequent developers will not introduce new bugs > > because of some complex logical relationships. > > > > In addition, the supporting to AF_XDP that I want to submit later will also need > > to reuse the logic of XDP, such as the processing of actions, I don't want to > > introduce a new similar code....

...> Looks sane to me. I plan to review and apply next week. > Hi Michael, I realize you just got back and have tons of things to do... Do you still plan to apply shortly ? Would you also have time to comment the QEMU part ? Thanks. -- Greg > > Greg Kurz (8): > > virtio: introduce virtio_is_little_endian() helper > > tun: add tun_is_little_endian() helper > > macvtap: introduce macvtap_is_little_endian() helper > > vringh: introduce vringh_is_little_endian() helper > > vhost: introduce vhost_is_little_endian() helper > >...

...> Looks sane to me. I plan to review and apply next week. > Hi Michael, I realize you just got back and have tons of things to do... Do you still plan to apply shortly ? Would you also have time to comment the QEMU part ? Thanks. -- Greg > > Greg Kurz (8): > > virtio: introduce virtio_is_little_endian() helper > > tun: add tun_is_little_endian() helper > > macvtap: introduce macvtap_is_little_endian() helper > > vringh: introduce vringh_is_little_endian() helper > > vhost: introduce vhost_is_little_endian() helper > >...

...2 x 2 " comparison : >>> >>> > N <- 5000000000000 * 8^-(0:7) >>> > as.integer(N) >>> [1] NA NA NA NA 1220703125 152587890 19073486 2384185 >>> Warning message: >>> NAs introduced by coercion >>> > as.integer(-N) >>> [1] NA NA NA NA -1220703125 -152587890 -19073486 >>> [8] -2384185 >>> Warning message: >>> NAs introduced by coercion >>> > as.integer(...

...will have a lot of changes in clang tests. *Replacing Undef with Poison* --------------------------- Since undef is known to be the source of many optimizations due to its complexity, we'd like to suggest gradually moving towards using poison only. To make it, (1) `poison` constant should be introduced into LLVM IR first, and (2) transformations that introduce `undef` should be updated to introduce `poison` instead. For the step (2), we need an experimental result showing that it does not cause performance degradation. This relies on better support for freeze (the no-undef/poison analysis patch...

This series introduce virtio-net features VIRTIO_NET_F_RSC_EXT, VIRTIO_NET_F_RSS and VIRTIO_NET_F_HASH_REPORT. Changes from v1: __virtio -> __le maximal -> maximum minor style fixes Yuri Benditovich (3): virtio-net: Introduce extended RSC feature virtio-net: Introduce RSS receive steering feature virtio-ne...