search for: internal_avail

On Thu, Nov 05, 2015 at 04:56:43PM +0100, Pino Toscano wrote: > Refactor the internal_feature_available to return the result for just > one group, so it is easier to know on the library side what was the > actual error, and which group refers to; drop internal_available, as no > more needed after this. > > On the library side, implement in available and feature_available the > real logic to iterate through the requested group, and error out or > return whether the groups are available. This also introduces caching > for the features, so each...

...e.c +++ b/daemon/available.c @@ -67,13 +67,13 @@ available (char *const *groups, int error_on_unavailable) } int -do_feature_available (char *const *groups) +do_internal_feature_available (char *const *groups) { return available (groups, 0); } int -do_available (char *const *groups) +do_internal_available (char *const *groups) { if (available (groups, 1) == -1) return -1; diff --git a/generator/actions.ml b/generator/actions.ml index 7ecd384..6348c88 100644 --- a/generator/actions.ml +++ b/generator/actions.ml @@ -3412,6 +3412,92 @@ C<guestfs_get_identifier>." }; longdes...

Refactor the internal_feature_available to return the result for just one group, so it is easier to know on the library side what was the actual error, and which group refers to; drop internal_available, as no more needed after this. On the library side, implement in available and feature_available the real logic to iterate through the requested group, and error out or return whether the groups are available. This also introduces caching for the features, so each needs to be queried just once...