Displaying 7 results from an estimated 7 matches for "int_is_l".
Did you mean:
int_is_le
2017 Jan 27
2
[BUG/RFC] vhost: net: big endian viring access despite virtio 1
...e(vq, VIRTIO_F_VERSION_1))
vq->is_le = true;
}
is a very strange initializer (makes assumptions about the state
to be initialized).
I agree, setting native endianness there sounds very reasonable.
I have a question regarding readability. IMHO the relationship
of reset_is_le and int_is_le is a bit confusing, and I'm afraid
it could become even more confusing with using reset in one of
the init_is_le's.
How about we do the following?
static void vhost_init_is_le(struct vhost_virtqueue *vq)
{
if (vhost_has_feature(vq, VIRTIO_F_VERSION_1))
vq->is_l...
2017 Jan 27
2
[BUG/RFC] vhost: net: big endian viring access despite virtio 1
...e(vq, VIRTIO_F_VERSION_1))
vq->is_le = true;
}
is a very strange initializer (makes assumptions about the state
to be initialized).
I agree, setting native endianness there sounds very reasonable.
I have a question regarding readability. IMHO the relationship
of reset_is_le and int_is_le is a bit confusing, and I'm afraid
it could become even more confusing with using reset in one of
the init_is_le's.
How about we do the following?
static void vhost_init_is_le(struct vhost_virtqueue *vq)
{
if (vhost_has_feature(vq, VIRTIO_F_VERSION_1))
vq->is_l...
2017 Jan 29
1
[BUG/RFC] vhost: net: big endian viring access despite virtio 1
...> is a very strange initializer (makes assumptions about the state
> > to be initialized).
> >
> > I agree, setting native endianness there sounds very reasonable.
> >
> > I have a question regarding readability. IMHO the relationship
> > of reset_is_le and int_is_le is a bit confusing, and I'm afraid
> > it could become even more confusing with using reset in one of
> > the init_is_le's.
> >
> > How about we do the following?
> >
> > static void vhost_init_is_le(struct vhost_virtqueue *vq)
> > {
> >...
2017 Jan 29
1
[BUG/RFC] vhost: net: big endian viring access despite virtio 1
...> is a very strange initializer (makes assumptions about the state
> > to be initialized).
> >
> > I agree, setting native endianness there sounds very reasonable.
> >
> > I have a question regarding readability. IMHO the relationship
> > of reset_is_le and int_is_le is a bit confusing, and I'm afraid
> > it could become even more confusing with using reset in one of
> > the init_is_le's.
> >
> > How about we do the following?
> >
> > static void vhost_init_is_le(struct vhost_virtqueue *vq)
> > {
> >...
2017 Jan 27
0
[BUG/RFC] vhost: net: big endian viring access despite virtio 1
...vq->is_le = true;
> }
> is a very strange initializer (makes assumptions about the state
> to be initialized).
>
> I agree, setting native endianness there sounds very reasonable.
>
> I have a question regarding readability. IMHO the relationship
> of reset_is_le and int_is_le is a bit confusing, and I'm afraid
> it could become even more confusing with using reset in one of
> the init_is_le's.
>
> How about we do the following?
>
> static void vhost_init_is_le(struct vhost_virtqueue *vq)
> {
> if (vhost_has_feature(vq, VIRTIO_F...
2017 Jan 26
2
[BUG/RFC] vhost: net: big endian viring access despite virtio 1
Hi!
Recently I have been investigating some strange migration problems on
s390x.
It turned out under certain circumstances vhost_net corrupts avail.idx by
using wrong endianness.
I managed to track the problem down (I'm pretty sure). It boils down to
the following.
When stopping vhost userspace (QEMU) calls vhost_net_set_backend with
the fd argument set to -1, this leads to is_le being
2017 Jan 26
2
[BUG/RFC] vhost: net: big endian viring access despite virtio 1
Hi!
Recently I have been investigating some strange migration problems on
s390x.
It turned out under certain circumstances vhost_net corrupts avail.idx by
using wrong endianness.
I managed to track the problem down (I'm pretty sure). It boils down to
the following.
When stopping vhost userspace (QEMU) calls vhost_net_set_backend with
the fd argument set to -1, this leads to is_le being