search for: instr

Zooming into the command-line option bike-shed: > On 2016-May-24, at 15:41, Vedant Kumar via llvm-dev <llvm-dev at lists.llvm.org> wrote: > > At its core I don't think -fprofile-instr-generate *implies* FE-based instrumentation. So, I'd like to see the driver do this (on all platforms): > > * -fprofile-instr-generate: IR instrumentation > * -fprofile-instr-generate=IR: IR instrumentation > * -fprofile-instr-generate=FE: FE instrumentation > * -fprofile-in...

...50 PM, Duncan P. N. Exon Smith < dexonsmith at apple.com> wrote: > Zooming into the command-line option bike-shed: > > > On 2016-May-24, at 15:41, Vedant Kumar via llvm-dev < > llvm-dev at lists.llvm.org> wrote: > > > > At its core I don't think -fprofile-instr-generate *implies* FE-based > instrumentation. So, I'd like to see the driver do this (on all platforms): > > > > * -fprofile-instr-generate: IR instrumentation > > * -fprofile-instr-generate=IR: IR instrumentation > > * -fprofile-instr-generate=FE: FE instrumentat...

...: ubuntu 14.04 Here is simple snippets test1.c: NOT OK ================== #include <stdio.h> static int foo() { return 42; } int main() { return 0; } ================== cp src/test1.c src/test.c; rm -fr default.profraw test.profdata ; clang -c -o obj/test.o src/test.c -I -g -O0 -fprofile-instr-generate -fcoverage-mapping; clang -o bin/test obj/test.o -I -g -O0 -fprofile-instr-generate -fcoverage-mapping; ./bin/test ; llvm-profdata merge -o test.profdata default.profraw; llvm-cov show ./bin/test -instr-profile=test.profdata error: Failed to load coverage: Malformed profile data test2....

...vm-dev < > llvm-dev at lists.llvm.org> wrote: > >> >> Sounds fine to me, though I am not a fan of using unstable in the option. >> I think a more meaningful way (that capture the essence of the difference) >> is the following naming: >> 1) FEPGO: -fprofile-instr-generate=source or >> -fprofile-instr-generate=region >> 2) IR: -fprofile-instr-generate=cfg or -fprofile-instr-generate=graph >> >> Also since -fprofile-instr-generate= form is already used to specify raw >> profile path, we may need a different driver option. Alterna...

> On Jun 2, 2016, at 5:30 PM, Sean Silva <chisophugis at gmail.com> wrote: > > This also means that if the consensus is that -fprofile-instr-generate should really change its meaning to mean IRPGO, I’m open to having this internal patch on our side. > > Yeah, it sounds like someone is going to have to keep a "private patch" to change the default. At that point doing a switch on the triple in upstream seems preferable t...

Hi, I have a question regarding PGO. I collected profile data with the instrumentation build (-fprofile-instr-generate) and provided for PGO optimization in the second build (with -fprofile-instr-use=xxx.profdata). This works fine. Then I tried to provide the profile data to opt using the option -pgo-instr-use, but this causes an error with the message: "Not an IR lev...

...eBasicBlock *LLVMBasicBlockRef; > typedef struct LLVMOpaqueBuilder *LLVMBuilderRef; > > + > /* Used to provide a module to JIT or interpreter. > * See the llvm::ModuleProvider class. > */ ? :) > @@ -441,6 +459,9 @@ > /* Operations on call sites */ > void LLVMSetInstructionCallConv(LLVMValueRef Instr, unsigned CC); > unsigned LLVMGetInstructionCallConv(LLVMValueRef Instr); > +void LLVMInstrAddParamAttr(LLVMValueRef Instr, unsigned index, > LLVMParamAttr); > +void LLVMInstrRemoveParamAttr(LLVMValueRef Instr, unsigned index, > LLVMParamAttr); &...

...; > Sean, thanks for the write up. It matches very well with what we think as well. + 1 > - Driver changes > > We'd like to make IRPGO the default on PS4. We also think that it would be beneficial to make IRPGO the default PGO on all platforms (coverage would continue to use FE instr as it does currently, of course). In previous conversations (e.g. http://reviews.llvm.org/D15829) it has come up that Apple have requirements that would prevent them from moving to IRPGO as the default PGO, at least without a deprecation period of one or two releases. Sean pointed out the problema...

...ide the appliance + * all i18n databases are deleted. For the same reason we cannot + * use functions like hivex_value_string, as they also use iconv + * internally. + * + * https://en.wikipedia.org/wiki/UTF-16 + * Also inspired by functions in glib's glib/gutf8.c + *) +let rec utf16le_to_utf8 instr = + (* If the length is odd and the last character is ASCII NUL, just + * drop that. (If it's not ASCII NUL, then there's an error) + *) + let len = String.length instr in + let instr = + if len mod 1 = 1 then ( + if instr.[len-1] = '\000' then String.sub instr 0 (le...

On Mon, Jun 27, 2016 at 2:53 PM Xinliang David Li <davidxl at google.com> wrote: > There is some misunderstanding about the intention of this flag. The > purpose of the flag is not to turn on profile instrumentation (which > already has -fprofile-instr-generate or -fprofile-generate for it), but to > select which instrumentors to use for PGO (IR or FE). I prefer fewer flags > too, but sharing flags for completely different purpose does not seem like > the right thing to do. > > Ah,...

...gt;>> > - Driver changes >>>>> > >>>>> > We'd like to make IRPGO the default on PS4. We also think that it >>>>> would be beneficial to make IRPGO the default PGO on all platforms >>>>> (coverage would continue to use FE instr as it does currently, of course). >>>>> In previous conversations (e.g. http://reviews.llvm.org/D15829) it >>>>> has come up that Apple have requirements that would prevent them from >>>>> moving to IRPGO as the default PGO, at least without a deprecatio...

...t; > @@ -69,6 +69,8 @@ > > typedef struct LLVMOpaqueBasicBlock *LLVMBasicBlockRef; > > typedef struct LLVMOpaqueBuilder *LLVMBuilderRef; > > > > +typedef struct LLVMOpaqueParamAttrs *LLVMParamAttrs; > > Please delete this, as it is unused. > > > +void LLVMInstrAddParamAttr(LLVMValueRef, unsigned index, > > LLVMParamAttr); > > +void LLVMInstrSetAlignment(LLVMValueRef, unsigned index, unsigned > > align); > > +void LLVMInstrRemoveParamAttr(LLVMValueRef, unsigned index, > > LLVMParamAttr); > > +void LLVMAddParamAttr(LLVMVa...

There is some misunderstanding about the intention of this flag. The purpose of the flag is not to turn on profile instrumentation (which already has -fprofile-instr-generate or -fprofile-generate for it), but to select which instrumentors to use for PGO (IR or FE). I prefer fewer flags too, but sharing flags for completely different purpose does not seem like the right thing to do. David On Sun, Jun 26, 2016 at...

I have a function with the follow signare: apply.strategy(instr, strat) where instr and strat are both objects of classes instrument and strategy respectively. I want to apply this function to a list that holds objects of the class instrument. Currently I am doing this by explicit looping: for(i in length(instr.list) ) { apply.strategy(instr.list[[i]],...

...s >>>>>>> > >>>>>>> > We'd like to make IRPGO the default on PS4. We also think that it >>>>>>> would be beneficial to make IRPGO the default PGO on all platforms >>>>>>> (coverage would continue to use FE instr as it does currently, of course). >>>>>>> In previous conversations (e.g. http://reviews.llvm.org/D15829) it >>>>>>> has come up that Apple have requirements that would prevent them from >>>>>>> moving to IRPGO as the default PGO, at le...

...- Driver changes >>>>>> > >>>>>> > We'd like to make IRPGO the default on PS4. We also think that it >>>>>> would be beneficial to make IRPGO the default PGO on all platforms >>>>>> (coverage would continue to use FE instr as it does currently, of course). >>>>>> In previous conversations (e.g. http://reviews.llvm.org/D15829) it >>>>>> has come up that Apple have requirements that would prevent them from >>>>>> moving to IRPGO as the default PGO, at least without...

...t;>> >>> + 1 >>> >>> >>> > - Driver changes >>> > >>> > We'd like to make IRPGO the default on PS4. We also think that it would be beneficial to make IRPGO the default PGO on all platforms (coverage would continue to use FE instr as it does currently, of course). In previous conversations (e.g. http://reviews.llvm.org/D15829 <http://reviews.llvm.org/D15829>) it has come up that Apple have requirements that would prevent them from moving to IRPGO as the default PGO, at least without a deprecation period of one or two r...

Hi, I often use the mod() and instring() functions that are available in the clim.pact package. This package has a lot of dependencies, including installation of netCDF, and I haven't yet been able to get library(clim.pact) to work on a Mac OS 10.4.6. A previous request for help with the Mac problem yielded no results, so now I...

...eBuilder *LLVMBuilderRef; > > > > + > > > > /* Used to provide a module to JIT or interpreter. > > * See the llvm::ModuleProvider class. > > */ > > ? :) > > > @@ -441,6 +459,9 @@ > > /* Operations on call sites */ > > void LLVMSetInstructionCallConv(LLVMValueRef Instr, unsigned CC); > > unsigned LLVMGetInstructionCallConv(LLVMValueRef Instr); > > +void LLVMInstrAddParamAttr(LLVMValueRef Instr, unsigned index, > > LLVMParamAttr); > > +void LLVMInstrRemoveParamAttr(LLVMValueRef Instr, unsigned index, > &...

...Michael Berris <dberris at google.com> wrote: > > > On Mon, Jun 27, 2016 at 2:53 PM Xinliang David Li <davidxl at google.com> > wrote: > >> There is some misunderstanding about the intention of this flag. The >> purpose of the flag is not to turn on profile instrumentation (which >> already has -fprofile-instr-generate or -fprofile-generate for it), but to >> select which instrumentors to use for PGO (IR or FE). I prefer fewer flags >> too, but sharing flags for completely different purpose does not seem like >> the right thing to d...