search for: installcheck

This is my proposed alternative to the complicated test framework (https://www.redhat.com/archives/libguestfs/2015-August/msg00022.html). In this patch, when we want to run tests on installed packages we just copy in the installed binaries over the source directory, and run the test suite as normal. This is basically the same as the current (not used) contrib/make-check-on-installed.pl script,

...n doc make[1]: Entering directory '/tmp/tinc-1.0.25/doc' make[1]: Nothing to be done for 'check'. make[1]: Leaving directory '/tmp/tinc-1.0.25/doc' make[1]: Entering directory '/tmp/tinc-1.0.25' make[1]: Leaving directory '/tmp/tinc-1.0.25' make install make installcheck #Making installcheck in m4 make[1]: Entering directory '/tmp/tinc-1.0.25/m4' make[1]: Nothing to be done for 'installcheck'. make[1]: Leaving directory '/tmp/tinc-1.0.25/m4' Making installcheck in src make[1]: Entering directory '/tmp/tinc-1.0.25/src' bad=0; pid=$$;...

...[chmod +x,-w appliance/libguestfs-make-fixed-appliance]) AC_CONFIG_FILES([inspector/test-xmllint.sh], [chmod +x,-w inspector/test-xmllint.sh]) +AC_CONFIG_FILES([inspector/test-virt-inspector.sh], + [chmod +x,-w inspector/test-virt-inspector.sh]) AC_CONFIG_FILES([installcheck.sh], [chmod +x,-w installcheck.sh]) AC_CONFIG_FILES([p2v/virt-p2v-make-disk], diff --git a/inspector/test-virt-inspector.sh b/inspector/test-virt-inspector.sh.in similarity index 92% rename from inspector/test-virt-inspector.sh rename to inspector/test-virt-inspector.sh.in index 2...

...ignore +++ b/.gitignore @@ -309,9 +309,6 @@ Makefile.in /haskell/Guestfs.hs /inspector/actual-*.xml /inspector/stamp-virt-inspector.pod -/inspector/test-virt-inspector.sh -/inspector/test-virt-inspector-luks.sh -/inspector/test-xmllint.sh /inspector/virt-inspector /inspector/virt-inspector.1 /installcheck.sh diff --git a/config.sh.in b/config.sh.in index 061871a3c..c777f096c 100644 --- a/config.sh.in +++ b/config.sh.in @@ -18,3 +18,5 @@ # This shell script contains the results of some configure checks, # mostly used in other shell scripts. + +export XMLLINT="@XMLLINT@" diff --git a/con...

On Thursday, 12 March 2020 23:46:57 CET Richard W.M. Jones wrote: > Unfortunately only tests the ./run version rather than the real one. > --- Is it worth it though? The new pkg-config file won't be deployed to users, and it should (hopefully) not break if the locations of the sources are not changed. Otherwise a small hint: rename it to e.g. local-pkg-config.sh to > diff --git

...hat happen during the Fedora (Koji) build, except for the basic kernel/qemu/libvirt/appliance sanity check. Instead, testing will now happen after the package has been built. Initially that'll just happen by me downloading the built package to my Rawhide test machine, and running the 'make installcheck' tests. But eventually I want to create some kind of infrastructure for this, triggered automatically when a Koji build completes. One upshot of this is that libguestfs will take a lot less time to build in Koji, with build times expected to go down from ~2 hours to ~20 minutes. If you want t...

Add a single shell script to hold results of configure. Pino Toscano (2): build: add an empty config.sh tests: switch to config.sh for xmllint .gitignore | 4 +--- config.sh.in | 22 +++++++++++++++++++ configure.ac | 7 +----- ...luks.sh.in => test-virt-inspector-luks.sh} | 2 +-

On Thu, Aug 03, 2017 at 06:08:24PM +0200, Pino Toscano wrote: > But I guess I have no chance to change the current patch (even adding > a test using asserts, instead of oUnit, for which I still did not get > a reason why a new test using it would be unacceptable), so ... Fewer dependencies make the code easier for others to consume, and that's especially true when (like oUnit) those

...ckage. (Personally I think it counts as bloat for both the diff and deb.) I don't understand the Debian test framework as well as I would like. You've probably seen an effort to build a test suite of our own. If it makes sense, I would like for the Debian test stuff to just do "make installcheck" (or "make check"), and for Debian people to contribute patches as necessary to make the testsuite work well. We need to be able to test on all kinds of platforms. If the two don't merge straightaway it's OK, but it would be a good medium term goal. I strongly prefer to in...

...test-virt-builder-repository.sh | 98 +++++ builder/utils.ml | 4 + builder/utils.mli | 3 + builder/virt-builder-repository.pod | 213 +++++++++++ builder/virt-builder.pod | 4 + fish/guestfish.pod | 1 + installcheck.sh.in | 1 + lib/guestfs.pod | 1 + 12 files changed, 1037 insertions(+), 2 deletions(-) create mode 100644 builder/repository_main.ml create mode 100755 builder/test-virt-builder-repository.sh create mode 100644 builder/virt-builder-repository.po...

...are tried and tested and work well on lots of platforms + supports automatically creating a distribution (dist target) + supports automatically testing a distribution (distcheck target) + fast/standard install/uninstall targets + handles install/uninstall of scripts, headers, data, etc. + handles installcheck (checking programs after installation) + supports automated testing via dejagnu + completely groks libtool for building shared libs on lots of platforms + autoconf flags can determine nature of the build + supports C, C++, Fortran, Java, Obj-C, Lex, Yacc, Python + knows how to build texinfo &...

...12,7 @@ Makefile.in /make-fs/virt-make-fs.1 /missing /ocaml-dep.sh +/ocaml-link.sh /ocaml/bindtests.bc /ocaml/bindtests.opt /ocaml/bindtests.ml diff --git a/configure.ac b/configure.ac index 2021fb522..4542d6faf 100644 --- a/configure.ac +++ b/configure.ac @@ -203,6 +203,8 @@ AC_CONFIG_FILES([installcheck.sh], [chmod +x,-w installcheck.sh]) AC_CONFIG_FILES([ocaml-dep.sh], [chmod +x,-w ocaml-dep.sh]) +AC_CONFIG_FILES([ocaml-link.sh], + [chmod +x,-w ocaml-link.sh]) AC_CONFIG_FILES([p2v/virt-p2v-make-disk], [chmod +x,-w p2v/virt-p2v-ma...

...full test suite. [Although it's incidental to this, I should say that in Fedora the full test suite is enabled, it's just run in two different places (not Koji because of the complexity and time involved running it in Koji). ‘make check-release’ is run when the tarball is built, and ‘make installcheck’ is run manually by me after the package has been built.] > Regarding the availability: oUnit2 is available in the latest stable > versions of all the major distros, even in older versions. > > > A simpler test framework which didn't use an external dependency > > wouldn&...

...st-virt-builder-repository.sh | 100 ++++++ builder/utils.ml | 4 + builder/utils.mli | 3 + builder/virt-builder-repository.pod | 213 ++++++++++++ builder/virt-builder.pod | 4 + fish/guestfish.pod | 1 + installcheck.sh.in | 1 + lib/guestfs.pod | 1 + 22 files changed, 1091 insertions(+), 29 deletions(-) create mode 100644 builder/repository_main.ml create mode 100755 builder/test-virt-builder-repository.sh create mode 100644 builder/virt-builder-repository.p...

...work well on lots of platforms > + supports automatically creating a distribution (dist target) > + supports automatically testing a distribution (distcheck target) > + fast/standard install/uninstall targets > + handles install/uninstall of scripts, headers, data, etc. > + handles installcheck (checking programs after installation) > + supports automated testing via dejagnu > + completely groks libtool for building shared libs on lots of platforms > + autoconf flags can determine nature of the build > + supports C, C++, Fortran, Java, Obj-C, Lex, Yacc, Python > + knows ho...

...; $(srcdir)/runtests.sh + POSIXLY_CORRECT=1 TOOLDIR=`pwd` rsync_bin=`pwd`/$(RSYNC_EXE) srcdir="$(srcdir)" $(srcdir)/runtests.sh # This does *not* depend on building or installing: you can use it to # check a version installed from a binary or some other source tree, # if you want. installcheck: $(CHECK_PROGS) - POSIXLY_CORRECT=1 TOOLDIR=`pwd` rsync_bin="$(bindir)/rsync$(EXEEXT)" srcdir="$(srcdir)" $(srcdir)/runtests.sh + POSIXLY_CORRECT=1 TOOLDIR=`pwd` rsync_bin="$(bindir)/$(RSYNC_EXE)" srcdir="$(srcdir)" $(srcdir)/runtests.sh # TODO: Add 'd...

...39;s just run in two different places (not > Koji because of the complexity and time involved running it in Koji). OK, but still Fedora falls into the "has oUnit" category, and it's even maintained by you. > ‘make check-release’ is run when the tarball is built, and ‘make > installcheck’ is run manually by me after the package has been built.] Both operations are run by whoever does the release, which is you (using Fedora, and thus with oUnit available). > > Regarding the availability: oUnit2 is available in the latest stable > > versions of all the major distros, ev...

v2: - Changes as suggested by Pino in previous review.

[This email is either empty or too large to be displayed at this time]

...test-virt-builder-repository.sh | 98 +++++ builder/utils.ml | 4 + builder/utils.mli | 3 + builder/virt-builder-repository.pod | 213 +++++++++++ builder/virt-builder.pod | 4 + fish/guestfish.pod | 1 + installcheck.sh.in | 1 + lib/guestfs.pod | 1 + 22 files changed, 1121 insertions(+), 27 deletions(-) create mode 100644 builder/repository_main.ml create mode 100755 builder/test-virt-builder-repository.sh create mode 100644 builder/virt-builder-repository.p...