search for: inspect_source

I'm going to push this because it's a test blocker, but FYI. Rich.

...lete output: virt-v2v -v -x [...] And secondly it would tell you to run virt-v2v -v -x even if you were running with verbose messages. Further fix for https://bugzilla.redhat.com/show_bug.cgi?id=1167623 which updates commit ab7197476de1cb3c8727caf4da429f6293ca4227. Thanks: Kun Wei. --- v2v/inspect_source.ml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/v2v/inspect_source.ml b/v2v/inspect_source.ml index 2b422e003..6f02fb20e 100644 --- a/v2v/inspect_source.ml +++ b/v2v/inspect_source.ml @@ -108,7 +108,7 @@ let rec inspect_source root_choice g = and choose_root root_choic...

...to the root filesystem, so these will inevitably fail later on with a strange error message. Test the root filesystem is writable by creating and deleting a temporary file, and if the creation fails then give better diagnostics. Reported-by: Piotr Kliczewski --- generator/OCaml.ml | 1 + v2v/inspect_source.ml | 37 +++++++++++++++++++++++++++---------- 2 files changed, 28 insertions(+), 10 deletions(-) diff --git a/generator/OCaml.ml b/generator/OCaml.ml index e58f387cc..467a1f0d8 100644 --- a/generator/OCaml.ml +++ b/generator/OCaml.ml @@ -40,6 +40,7 @@ let ocaml_errnos = [ "EPERM";...

...02PM +0300, Pavel Butsykin wrote: > Store the list of EFI system partitions on the inspect object in order to be > able to tune their contents later in the process. > > Signed-off-by: Pavel Butsykin <pbutsykin@virtuozzo.com> > --- > v2v/convert_linux.ml | 2 +- > v2v/inspect_source.ml | 29 +++++++++++++++++++++-------- > v2v/types.ml | 4 ++-- > v2v/types.mli | 3 ++- > v2v/v2v.ml | 2 +- > v2v/v2v_unit_tests.ml | 2 +- > 6 files changed, 28 insertions(+), 14 deletions(-) > > diff --git a/v2v/convert_linux.ml b/v2v/conver...

...disks. In the following discussion remember that "source" == "metadata". * let overlays = create_overlays source.s_disks in let g = Guestfs.guestfs () in populate_overlays g overlays The overlays are created and added as disks to a guestfs handle * let inspect = Inspect_source.inspect_source g in let guestcaps = do_convert g inspect output in This does inspection + conversion. (The real do_convert function takes the source struct as parameter, but it is not really used.) * let targets = output#prepare_targets overlays in copy_targets targets input output...

See: http://caml.inria.fr/pub/docs/manual-ocaml/comp.html#s:comp-warnings --- builder/index_parser.ml | 8 ++++---- generator/tests_c_api.ml | 4 ++-- mllib/common_utils.ml | 2 +- v2v/inspect_source.ml | 2 +- v2v/linux.ml | 2 +- v2v/xpath_helpers.ml | 2 +- 6 files changed, 10 insertions(+), 10 deletions(-) diff --git a/builder/index_parser.ml b/builder/index_parser.ml index e5e4c6c..a3cae7d 100644 --- a/builder/index_parser.ml +++ b/builder/index_parser.ml @@ -113,7 +113...

...++++++++++++++++------------------------- 1 file changed, 28 insertions(+), 25 deletions(-) diff --git a/v2v/v2v.ml b/v2v/v2v.ml index 4257b8d..a2b6f52 100644 --- a/v2v/v2v.ml +++ b/v2v/v2v.ml @@ -80,32 +80,9 @@ let rec main () = message (f_"Inspecting the overlay"); let inspect = inspect_source g root_choice in - (* The guest free disk space check and the target free space - * estimation both require statvfs information from mountpoints, so - * get that information first. - *) - let mpstats = List.map ( - fun (dev, path) -> - let statvfs = g#statvfs path in - let...

...Opening the source VM and amending the properties in its internal > representation in accordance with command-line options fit nicely into > two isolated functions. Better to write this as: let rec main () = ... and open_source ... = ... and amend_source ... = ... and inspect_source ... = ... so it's consistent with how all the other sub-functions are done in the same file. 'let rec .. and ..' defines mutually recursive functions that can call each other. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my program...

This patch is just for discussion. There are still a couple of issues that I'm trying to fix. One is that all of the test guests I have, even ones with static IPs, have multiple interfaces, some using DHCP, so the conditions for adding the Powershell script don't kick in. This makes testing very awkward. However a bigger issue is that I think the premise is wrong. In some registries

On Thu, Oct 10, 2019 at 03:33:25PM +0100, Richard W.M. Jones wrote: >On Wed, Oct 09, 2019 at 02:19:46PM +0200, Martin Kletzander wrote: >> Even though this option is not to be used according to the manual, it: >> >> a) still might be useful even for machine-readable logs >> >> b) should not break the machine-readable output > >I'm a bit confused what

v1 was here with much discussion: https://www.redhat.com/archives/libguestfs/2018-December/msg00048.html v2: - Fix the case where there are multiple interfaces. Note this does not preserve order correctly (see patch for comment on why that is a hard problem). - Preserve name servers. This patch is still for discussion only. I'd like to see what might be done to get this upstream

I'm interested to hear opinions on whether this makes the code clearer, or not. This is virt-v2v, but many other virt-* tools work the same way, and analogous changes could be made. Currently when command line argument parsing is done in 'cmdline.ml' the list of parsed parameters is passed to the main program in a very long tuple. Each parameter is strongly typed, but not named (so

...estimated_size = None; - target_actual_size = None; - target_overlay = ov } - ) overlays in - let targets = output#prepare_targets source targets in - (* Inspection - this also mounts up the filesystems. *) message (f_"Inspecting the overlay"); let inspect = inspect_source g root_choice in @@ -453,6 +417,45 @@ and create_overlays src_disks = ov_virtual_size = vsize; ov_source = source } ) src_disks +and init_targets overlays source output output_format = + (* Work out where we will write the final output. Do this early + * just so we can display err...

...scussion remember that "source" == "metadata". > >* let overlays = create_overlays source.s_disks in > let g = Guestfs.guestfs () in > populate_overlays g overlays > > The overlays are created and added as disks to a guestfs handle > >* let inspect = Inspect_source.inspect_source g in > let guestcaps = do_convert g inspect output in > > This does inspection + conversion. (The real do_convert function > takes the source struct as parameter, but it is not really used.) > >* let targets = output#prepare_targets overlays in > copy_ta...

A very miscellaneous set of cleanups to how we handle the Windows registry in virt-v2v, firstboot, and inspection code. This should all be straightforward non-controversial refactoring. Some highlights: - Add a new mllib Registry module containing various utility functions that are currently scattered all around. - Only compute the software/system hive paths once during inspection, and

...+ (* Populate guestfs handle with qcow2 overlays. *) + List.iter ( + fun ({ov_overlay_file = overlay_file}) -> + g#add_drive_opts overlay_file + ~format:"qcow2" ~cachemode:"unsafe" ~discard:"besteffort" + ~copyonread:true + ) overlays + and inspect_source g root_choice = let roots = g#inspect_os () in let roots = Array.to_list roots in -- 2.4.3

...lsewhere, convert in place, create metadata -- > > is a very different flow. It could look something like this: > > > > * let overlays = create_overlays source.s_disks in > > let g = Guestfs.guestfs () in > > populate_overlays g overlays > > let inspect = Inspect_source.inspect_source g in > > let guestcaps = do_convert g inspect output in > > let targets = output#prepare_targets overlays in > > for each overlay: qemu-img commit it > > output#create_metadata source targets guestcaps inspect > > FWIW our scenarios look somewha...

v1 was here: https://www.redhat.com/archives/libguestfs/2017-October/msg00183.html v2: - Adds back the Debian test, but simplified. - Adds tests on Fedora & Debian. Rich.

...copy_to_local.ml | 23 +++++++---------- v2v/input_libvirt_other.ml | 2 +- v2v/input_libvirt_vcenter_https.ml | 16 +++++------- v2v/input_libvirt_xen_ssh.ml | 8 +++--- v2v/input_libvirtxml.ml | 3 +-- v2v/input_ova.ml | 10 +++----- v2v/inspect_source.ml | 4 +-- v2v/linux.ml | 4 +-- v2v/output_glance.ml | 4 +-- v2v/output_libvirt.ml | 10 ++++---- v2v/output_rhev.ml | 16 ++++-------- v2v/v2v.ml | 52 ++++++++++++++++----------------------...

This series is a second attempt to add a mode of virt-v2v operation where it leaves the config and disk image conversion, rollback on errors, registering with the destination hypervisor, etc. to a third-party toolset, and performs only tuning of the guest OS to run in the KVM-based hypervisor. The first 14 patches are just refactoring and rearrangement of the code, factoring the implementation