search for: inspect_get_minor_version

...tomize/password.ml @@ -162,6 +162,9 @@ and default_crypto g root = | "ubuntu", v when v >= 10 -> `SHA512 | "ubuntu", _ -> `MD5 + | "opensuse", v when v >= 11 -> `SHA512 + | "opensuse", _ -> `MD5 + | _, _ -> let minor = g#inspect_get_minor_version root in warning (f_"password: using insecure md5 password encryption for guest of type %s version %d.%d. -- 2.1.0

...se"|"sles"), v when v >= 11 -> `SHA512 | ("opensuse"|"sles"), _ -> `MD5 + (* Rolling distributions, which hopefully should be updated enough. *) + | ("archlinux"|"voidlinux"), _ -> `SHA512 + | _, _ -> let minor = g#inspect_get_minor_version root in warning (f_"password: using insecure md5 password encryption for guest of type %s version %d.%d. -- 2.7.4

Hi Richard I've noticed this snippet in import-to-ovirt.pl my $minor_version = $g->inspect_get_major_version ($root); I guess you meant here my $minor_version = $g->inspect_get_minor_version ($root); Emmanuel

...stro($root); + $desc{distro} = $g->inspect_get_distro($root) + if $desc{os} eq 'linux'; $desc{product_name} = $g->inspect_get_product_name($root); $desc{major_version} = $g->inspect_get_major_version($root); $desc{minor_version} = $g->inspect_get_minor_version($root); -- 1.7.4.4

...uot;, _ -> `MD5 > > | _, _ -> > - warning (f_"password: using insecure md5 password encryption for > -guest of type %s version %d.\nIf this is incorrect, use --password-crypto option and file a bug.") distro major; > + let verstr = > + let minor = g#inspect_get_minor_version root in > + match major, minor with > + | x, _ when x > 0 -> string_of_int x > + | 0, 0 -> "0" > + | x, y -> "0." ^ string_of_int y in > + warning (f_"password: using insecure md5 password encryption for guest of type %s ver...

*** BLURB HERE *** Pino Toscano (3): python: modernize inspect_vm example perl: silence usage of add_cdrom in test python: silence usage of add_cdrom in test perl/t/060-handle-properties.t | 7 +++++-- python/examples/inspect_vm.py | 26 ++++++++++++-------------- python/t/test050HandleProperties.py | 5 ++++- 3 files changed, 21 insertions(+), 17 deletions(-) -- 2.20.1

CirrOS has its random-seed file in /etc. --- customize/random_seed.ml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/customize/random_seed.ml b/customize/random_seed.ml index 34a7af7..5a15ad9 100644 --- a/customize/random_seed.ml +++ b/customize/random_seed.ml @@ -30,6 +30,7 @@ let rec set_random_seed (g : Guestfs.guestfs) root = "/var/lib/systemd/random-seed"; (* Fedora

...d return the enhanced descriptor. Inspection APIS: All take a root filesystem as an argument, which may not be a block device. inspect_get_arch inspect_get_distro inspect_get_drive_mappings inspect_get_filesystems inspect_get_format inspect_get_hostname inspect_get_icon inspect_get_major_version inspect_get_minor_version inspect_get_mountpoints inspect_get_package_format inspect_get_package_management inspect_get_product_name inspect_get_product_variant inspect_get_type inspect_get_windows_current_control_set inspect_get_windows_systemroot inspect_is_live inspect_is_multipart inspect_is_netinst inspect_list_applica...

Read the information from os-release, and make it behave like a Debian distribution (i.e. using dpkg, and apt). --- daemon/inspect_fs.ml | 2 ++ daemon/inspect_fs_unix.ml | 1 + daemon/inspect_types.ml | 2 ++ daemon/inspect_types.mli | 1 + generator/actions_inspection.ml | 4 ++++ 5 files changed, 10 insertions(+) diff --git a/daemon/inspect_fs.ml

...{ - my ($desc, $arch_suffix) = @_; + my ($g, $root, $arch_suffix) = @_; - my $major = $desc->{major_version}; - my $minor = $desc->{minor_version}; - my $product = $desc->{product_name}; + my $major = $g->inspect_get_major_version($root); + my $minor = $g->inspect_get_minor_version($root); + my $product = $g->inspect_get_product_name($root); if ($major == 5) { if ($minor == 1 || @@ -847,7 +848,7 @@ sub _get_os_type_windows } if ($major == 6 && $minor == 1) { - if ($desc->{product_variant} eq 'Client') { + if (...

...o g root = | "ubuntu", _ -> `MD5 | _, _ -> - warning (f_"password: using insecure md5 password encryption for -guest of type %s version %d.\nIf this is incorrect, use --password-crypto option and file a bug.") distro major; + let verstr = + let minor = g#inspect_get_minor_version root in + match major, minor with + | x, _ when x > 0 -> string_of_int x + | 0, 0 -> "0" + | x, y -> "0." ^ string_of_int y in + warning (f_"password: using insecure md5 password encryption for guest of type %s version %s. +If this is inco...

.../customize/password.ml @@ -165,6 +165,9 @@ and default_crypto g root = | "opensuse", v when v >= 11 -> `SHA512 | "opensuse", _ -> `MD5 + | "sles", v when v >= 11 -> `SHA512 + | "sles", _ -> `MD5 + | _, _ -> let minor = g#inspect_get_minor_version root in warning (f_"password: using insecure md5 password encryption for guest of type %s version %d.%d. -- 2.1.4

On Sat, Dec 24, 2016 at 02:28:18PM +0100, Emmanuel Kasper wrote: > Hi Richard > > I've noticed this snippet in import-to-ovirt.pl > > my $minor_version = $g->inspect_get_major_version ($root); > > I guess you meant here > > my $minor_version = $g->inspect_get_minor_version ($root); Indeed I did, and that also means that some of the metadata in imported guests would have been broken. All fixed now, thanks! http://git.annexia.org/?p=import-to-ovirt.git;a=commitdiff;h=0b4fd1e614b2101c3b6afe688ce09272b7eb3357 Rich. -- Richard Jones, Virtualization Group, Red Hat ht...

...po index interactive let root = Array.get roots 0 in let inspected_arch = g#inspect_get_arch root in let product = g#inspect_get_product_name root in - let distro = g#inspect_get_distro root in - let version_major = g#inspect_get_major_version root in - let version_minor = g#inspect_get_minor_version root in + let shortid = g#inspect_get_osinfo root in let lvs = g#lvs () in let filesystems = g#inspect_get_filesystems root in - let shortid = compute_short_id distro version_major version_minor in - g#close (); let id = -- 2.14.3

...ot;sles"), _ -> `MD5 (* Rolling distributions, which hopefully should be updated enough. *) - | ("archlinux"|"voidlinux"), _ -> `SHA512 + | ("archlinux"|"voidlinux"|"kalilinux"), _ -> `SHA512 | _, _ -> let minor = g#inspect_get_minor_version root in diff --git a/customize/random_seed.ml b/customize/random_seed.ml index 90001a728..7aea6851e 100644 --- a/customize/random_seed.ml +++ b/customize/random_seed.ml @@ -49,7 +49,7 @@ let rec set_random_seed (g : Guestfs.guestfs) root = match typ, distro with | "linux", (...

...dows" libguestfs: trace: inspect_get_product_name "/dev/sda1" libguestfs: trace: inspect_get_product_name = "Microsoft Windows Server 2003" libguestfs: trace: inspect_get_major_version "/dev/sda1" libguestfs: trace: inspect_get_major_version = 5 libguestfs: trace: inspect_get_minor_version "/dev/sda1" libguestfs: trace: inspect_get_minor_version = 2 libguestfs: trace: inspect_get_arch "/dev/sda1" libguestfs: trace: inspect_get_arch = "i386" libguestfs: trace: exists "/transferZcKAPK//usr/share/virtio-win/drivers/i386/Wi n2003" libguestfs: send_...

...L; + CLEANUP_FREE char *distro = NULL; + int major, minor; + + type = guestfs_inspect_get_type (g, root); + if (!type) + return NULL; + distro = guestfs_inspect_get_distro (g, root); + if (!distro) + return NULL; + major = guestfs_inspect_get_major_version (g, root); + minor = guestfs_inspect_get_minor_version (g, root); + + if (STREQ (type, "linux")) { + if (STREQ (distro, "centos")) { + if (major >= 7) + return safe_asprintf (g, "%s%d.0", distro, major); + else if (major == 6) + return safe_asprintf (g, "%s%d.%d", distro, major, min...

This is the (incomplete) patch which reimplements inspection APIs in the daemon. All ‘XXX’s in this patch indicate areas which are not yet implemented or need further work. Rich.

Hi, I tried to rewrite virt-rescue from C to OCaml. Goals were feature parity with C implementation, smaller codebase and hopefully better maintainability. I still don't know if I've covered everything right. So, please check it out. PS: my git send-email seems to be broken, so I'm sending it from thunderbird Thanks! maros

...-val inspect_get_package_format : Mountable.t -> string -val inspect_get_package_management : Mountable.t -> string -val inspect_get_product_name : Mountable.t -> string -val inspect_get_product_variant : Mountable.t -> string -val inspect_get_major_version : Mountable.t -> int -val inspect_get_minor_version : Mountable.t -> int -val inspect_get_arch : Mountable.t -> string -val inspect_get_hostname : Mountable.t -> string -val inspect_get_windows_systemroot : Mountable.t -> string -val inspect_get_windows_software_hive : Mountable.t -> string -val inspect_get_windows_system_hive : Mount...