search for: insertdi

...pe || issubprogram" check should probably be pulled out into >> a separate function, something like "isShareableAcrossCUs" or something >> like that (please, that's not the best name, let's discuss it further >> before we settle on a name) so that getDIE and insertDIE are sure to use >> the same test at all times. >> > Yes, the condition is shared between getDIE and insertDIE. I like > isSharableAcrossCUs, because that is why the map is in DwarfDebug instead > of CompileUnit. > Done in attached patch. > > >> Why does addD...

...check should probably be pulled out >>>> into a separate function, something like "isShareableAcrossCUs" or >>>> something like that (please, that's not the best name, let's discuss it >>>> further before we settle on a name) so that getDIE and insertDIE are sure >>>> to use the same test at all times. >>>> >>> Yes, the condition is shared between getDIE and insertDIE. I like >>> isSharableAcrossCUs, because that is why the map is in DwarfDebug instead >>> of CompileUnit. >>> >> Don...

...nit.cpp: the "istype || issubprogram" check should probably be pulled out into a separate function, something like "isShareableAcrossCUs" or something like that (please, that's not the best name, let's discuss it further before we settle on a name) so that getDIE and insertDIE are sure to use the same test at all times. Why does addDIEEntry take a form? When does the caller get to choose the form rather than the callee deciding between ref4 and ref_addr based on context? I'm still unsure about this worklist thing - do your current tests cover the need for the wo...

...rogram" check should probably be pulled out >>> into a separate function, something like "isShareableAcrossCUs" or >>> something like that (please, that's not the best name, let's discuss it >>> further before we settle on a name) so that getDIE and insertDIE are sure >>> to use the same test at all times. >>> >> Yes, the condition is shared between getDIE and insertDIE. I like >> isSharableAcrossCUs, because that is why the map is in DwarfDebug instead >> of CompileUnit. >> > Done in attached patch. > &g...

...e "istype || issubprogram" check should probably be pulled out into > a separate function, something like "isShareableAcrossCUs" or something > like that (please, that's not the best name, let's discuss it further > before we settle on a name) so that getDIE and insertDIE are sure to use > the same test at all times. > Yes, the condition is shared between getDIE and insertDIE. I like isSharableAcrossCUs, because that is why the map is in DwarfDebug instead of CompileUnit. > Why does addDIEEntry take a form? When does the caller get to choose the > f...

...it is from r176882, but instead of always using an integer for ref_addr, we use label + offset for relocation on non-darwin platforms. The second patch is a modified version of r191792. The main change is to use a single map instead of 3 maps in DwarfDebug and instead of calling DwarfDebug::getDIE|insertDIE directly, we delegate the function calls to DwarfDebug from CompileUnit. No testing case is added in the 1st patch, since the compiler does not use ref_addr yet. For the 2nd patch, testing cases are updated to make sure we remove duplicated DIEs and use ref_addr to refer to the type DIE. A testi...

...check should probably be pulled out >>>> into a separate function, something like "isShareableAcrossCUs" or >>>> something like that (please, that's not the best name, let's discuss it >>>> further before we settle on a name) so that getDIE and insertDIE are sure >>>> to use the same test at all times. >>>> >>> Yes, the condition is shared between getDIE and insertDIE. I like >>> isSharableAcrossCUs, because that is why the map is in DwarfDebug instead >>> of CompileUnit. >>> >> Don...

...rogram" check should probably be pulled out >>> into a separate function, something like "isShareableAcrossCUs" or >>> something like that (please, that's not the best name, let's discuss it >>> further before we settle on a name) so that getDIE and insertDIE are sure >>> to use the same test at all times. >>> >> Yes, the condition is shared between getDIE and insertDIE. I like >> isSharableAcrossCUs, because that is why the map is in DwarfDebug instead >> of CompileUnit. >> > Done in attached patch. > &g...

...e pulled out >>>>>> into a separate function, something like "isShareableAcrossCUs" or >>>>>> something like that (please, that's not the best name, let's discuss it >>>>>> further before we settle on a name) so that getDIE and insertDIE are sure >>>>>> to use the same test at all times. >>>>>> >>>>> Yes, the condition is shared between getDIE and insertDIE. I like >>>>> isSharableAcrossCUs, because that is why the map is in DwarfDebug instead >>>>> o...

...instead of always using an integer for > ref_addr, we use label + offset for relocation on non-darwin platforms. > > The second patch is a modified version of r191792. > The main change is to use a single map instead of 3 maps in DwarfDebug and > instead of calling DwarfDebug::getDIE|insertDIE directly, we delegate the > function calls to DwarfDebug from CompileUnit. > > No testing case is added in the 1st patch, since the compiler does not use > ref_addr yet. > > For the 2nd patch, testing cases are updated to make sure we remove > duplicated DIEs and use ref_addr...

...d probably be pulled out >>>>> into a separate function, something like "isShareableAcrossCUs" or >>>>> something like that (please, that's not the best name, let's discuss it >>>>> further before we settle on a name) so that getDIE and insertDIE are sure >>>>> to use the same test at all times. >>>>> >>>> Yes, the condition is shared between getDIE and insertDIE. I like >>>> isSharableAcrossCUs, because that is why the map is in DwarfDebug instead >>>> of CompileUnit. >&...

...>>>>>>> into a separate function, something like "isShareableAcrossCUs" or >>>>>>> something like that (please, that's not the best name, let's discuss it >>>>>>> further before we settle on a name) so that getDIE and insertDIE are sure >>>>>>> to use the same test at all times. >>>>>>> >>>>>> Yes, the condition is shared between getDIE and insertDIE. I like >>>>>> isSharableAcrossCUs, because that is why the map is in DwarfDebug instead >&g...

...;>>>>> into a separate function, something like "isShareableAcrossCUs" or something >>>>>>>> like that (please, that's not the best name, let's discuss it further before >>>>>>>> we settle on a name) so that getDIE and insertDIE are sure to use the same >>>>>>>> test at all times. >>>>>>> >>>>>>> Yes, the condition is shared between getDIE and insertDIE. I like >>>>>>> isSharableAcrossCUs, because that is why the map is in DwarfDebug in...

...ORM_ref4, AbsSPDIE); SPCU->addDie(SPDie); } … } The compile unit DIE where AbsSPDIE belongs to is different from the compile unit DIE SPCU->getCUDie(). So it is not legal to use a FORM_ref4 here. Why do we create these subprogram DIEs here? They are added to SPCU, but not inserted via insertDIE, so they are not in the MDNodeToDieMap of the CU. Another question is how to fix this if we need to create these subprograms. Should we use FORM_ref_addr here? FORM_ref_addr is not supported yet, I am wondering whether that will break any debugger. Another fix seems to be copying the attributes o...

...>>>>>>> into a separate function, something like "isShareableAcrossCUs" or >>>>>>> something like that (please, that's not the best name, let's discuss it >>>>>>> further before we settle on a name) so that getDIE and insertDIE are sure >>>>>>> to use the same test at all times. >>>>>>> >>>>>> Yes, the condition is shared between getDIE and insertDIE. I like >>>>>> isSharableAcrossCUs, because that is why the map is in DwarfDebug instead >&g...

...;>>>> out into a separate function, something like "isShareableAcrossCUs" or >>>>>>>> something like that (please, that's not the best name, let's discuss it >>>>>>>> further before we settle on a name) so that getDIE and insertDIE are sure >>>>>>>> to use the same test at all times. >>>>>>>> >>>>>>> Yes, the condition is shared between getDIE and insertDIE. I like >>>>>>> isSharableAcrossCUs, because that is why the map is in DwarfDebu...

...;>> out into a separate function, something like "isShareableAcrossCUs" or >>>>>>>>> something like that (please, that's not the best name, let's discuss it >>>>>>>>> further before we settle on a name) so that getDIE and insertDIE are sure >>>>>>>>> to use the same test at all times. >>>>>>>>> >>>>>>>> Yes, the condition is shared between getDIE and insertDIE. I like >>>>>>>> isSharableAcrossCUs, because that is why the map...

...; out into a separate function, something like "isShareableAcrossCUs" or >>>>>>>>>> something like that (please, that's not the best name, let's discuss it >>>>>>>>>> further before we settle on a name) so that getDIE and insertDIE are sure >>>>>>>>>> to use the same test at all times. >>>>>>>>>> >>>>>>>>> Yes, the condition is shared between getDIE and insertDIE. I like >>>>>>>>> isSharableAcrossCUs, because tha...

...to a separate function, something like "isShareableAcrossCUs" or >>>>>>>>>>> something like that (please, that's not the best name, let's discuss it >>>>>>>>>>> further before we settle on a name) so that getDIE and insertDIE are sure >>>>>>>>>>> to use the same test at all times. >>>>>>>>>>> >>>>>>>>>> Yes, the condition is shared between getDIE and insertDIE. I like >>>>>>>>>> isSharableAcross...

...to a separate function, something like "isShareableAcrossCUs" or >>>>>>>>>>> something like that (please, that's not the best name, let's discuss it >>>>>>>>>>> further before we settle on a name) so that getDIE and insertDIE are sure >>>>>>>>>>> to use the same test at all times. >>>>>>>>>>> >>>>>>>>>> Yes, the condition is shared between getDIE and insertDIE. I like >>>>>>>>>> isSharableAcross...