search for: insert_inline_ext

...de.c | 5 ++++- 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c index cd51968..46d8732 100644 --- a/fs/btrfs/inode.c +++ b/fs/btrfs/inode.c @@ -257,10 +257,13 @@ static noinline int cow_file_range_inline(struct btrfs_trans_handle *trans, ret = insert_inline_extent(trans, root, inode, start, inline_len, compressed_size, compress_type, compressed_pages); - if (ret) { + if (ret && ret != -ENOSPC) { btrfs_abort_transaction(trans, root, ret); return ret; + } else if (ret == -ENOSPC) { + return 1; } + btrfs_delalloc_release_me...

...info ffff880303a0a000, task ffff8803046cad80) Stack: ffff880280e63cc0 ffff8802fd10ad26 0000000000000001 ffff880303a0a000 ffffea000a75ba30 0000000000000fb2 00000000000008f7 00000000000002da ffff880303a0bcb0 ffffffffa00c5bb0 0000002e00000001 0000000000000000 Call Trace: [<ffffffffa00c5bb0>] insert_inline_extent+0x330/0x350 [btrfs] [<ffffffffa00c5cf6>] cow_file_range_inline+0x126/0x160 [btrfs] [<ffffffffa00c68f0>] compress_file_range+0x3b0/0x580 [btrfs] [<ffffffffa00c6af5>] async_cow_start+0x35/0x50 [btrfs] [<ffffffffa00eac0c>] worker_loop+0xac/0x260 [btrfs] [<ffffffffa00...

Hi, this shown up today. I had to do a hard reboot as graceful hanged on sync(). ------------[ cut here ]------------ kernel BUG at fs/btrfs/delayed-inode.c:1466! invalid opcode: 0000 [#1] SMP CPU 10 Modules linked in: btrfs zlib_deflate lzo_compress ipmi_devintf autofs4 be2iscsi iscsi_boot_sysfs ib_iser rdma_cm ib_cm iw_cm ib_sa ib_mad ib_addr iscsi_tcp bnx2i cnic uio ipv6 cxgb3i libcxgbi

If we have particularly full nodes, we could call btrfs_node_blockptr up to 32 times, which is 32 pairs of kmap/kunmap, which _sucks_. So go ahead and map the extent buffer while we look for readahead targets. Thanks, Signed-off-by: Josef Bacik <josef@redhat.com> --- fs/btrfs/ctree.c | 23 +++++++++++++++++++++-- 1 files changed, 21 insertions(+), 2 deletions(-) diff --git

...inned[1]); - BUG_ON(ret); + btrfs_fixable_bug_on(ret); wait_on_page_locked(pinned[1]); } else { unlock_page(pinned[1]); diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c index c038644..ad15e7b 100644 --- a/fs/btrfs/inode.c +++ b/fs/btrfs/inode.c @@ -144,7 +144,7 @@ static noinline int insert_inline_extent(struct btrfs_trans_handle *trans, inode_add_bytes(inode, size); ret = btrfs_insert_empty_item(trans, root, path, &key, datasize); - BUG_ON(ret); + btrfs_fixable_bug_on(ret); if (ret) { err = ret; goto fail; @@ -244,14 +244,14 @@ static noinline int cow_file_range_inlin...

...t = btrfs_search_slot_for_inode(trans, root, inode, &key, + path, -1, 1); if (ret > 0) { ret = -ENOENT; goto out; diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c index 6de67a5..3e7394f 100644 --- a/fs/btrfs/inode.c +++ b/fs/btrfs/inode.c @@ -148,8 +148,8 @@ static noinline int insert_inline_extent(struct btrfs_trans_handle *trans, datasize = btrfs_file_extent_calc_inline_size(cur_size); inode_add_bytes(inode, size); - ret = btrfs_insert_empty_item(trans, root, path, &key, - datasize); + ret = btrfs_insert_empty_item_for_inode(trans, root, inode, path, &key, + d...