search for: inputtotran

Committed in r159281. -Anshu On 6/26/2012 3:04 AM, Ivan Llopard wrote: > Hi Anshu, > > I don't have commit access. It applies correctly on trunk, I've just > checked it. Could you please commit it? > > Ivan > > On 26/06/2012 04:44, adasgupt at codeaurora.org wrote: >> Hi Ivan, >> >> Sorry, I should have been more explicit in my last email. The

Hi Anshu, I don't have commit access. It applies correctly on trunk, I've just checked it. Could you please commit it? Ivan On 26/06/2012 04:44, adasgupt at codeaurora.org wrote: > Hi Ivan, > > Sorry, I should have been more explicit in my last email. The patch looks > good to me. Please check that it applies on trunk and go ahead and commit. > > Thanks > -Anshu

...évision 159340) +++ DFAPacketizerEmitter.cpp (copie de travail) @@ -76,15 +76,19 @@ // // namespace { +struct Transition; + class State { public: static int currentStateNum; int stateNum; bool isInitial; std::set<unsigned> stateInfo; + std::map<unsigned, Transition *> inputToTrans; State(); State(const State &S); + ~State(); // // canAddInsnClass - Returns true if an instruction of type InsnClass is a @@ -100,6 +104,15 @@ // which are possible from this state (PossibleStates). // void AddInsnClass(unsigned InsnClass, std::set<unsigned> &a...

...e the maximum value, i.e. 2^(n-1), but valid inputs are just a small subset of [0, LargestInput]. But then please remove the > Transition mechanism for the DFA class (stateTransitions). Done! > > For transitions being folded into State: > > std::map<unsigned, Transition *> inputToTrans; > > We don't need a map to Transition* here; we can directly map from input > to stateNum. You should be able to use a LLVM data structure. In that case, (1) Should I completely remove Transition and create a map structure in State (input, state) to replace them? (2) Or are you pro...

...both. I am okay with transitions being folded into the State class if it results in significant speedup in DFA generation. But then please remove the Transition mechanism for the DFA class (stateTransitions). For transitions being folded into State: > std::map<unsigned, Transition *> inputToTrans; We don't need a map to Transition* here; we can directly map from input to stateNum. You should be able to use a LLVM data structure. -Anshu

...d > inputs are just a small subset of [0, LargestInput]. > > But then please remove the >> Transition mechanism for the DFA class (stateTransitions). > > Done! > >> >> For transitions being folded into State: >> > std::map<unsigned, Transition *> inputToTrans; >> >> We don't need a map to Transition* here; we can directly map from input >> to stateNum. You should be able to use a LLVM data structure. > > In that case, > (1) Should I completely remove Transition and create a map structure > in State (input, state) to r...

...et of [0, LargestInput]. >> >> But then please remove the >>> Transition mechanism for the DFA class (stateTransitions). >> >> Done! >> >>> >>> For transitions being folded into State: >>> > std::map<unsigned, Transition *> inputToTrans; >>> >>> We don't need a map to Transition* here; we can directly map from input >>> to stateNum. You should be able to use a LLVM data structure. >> >> In that case, >> (1) Should I completely remove Transition and create a map structure >> i...