search for: input_unregister_device

...t a/drivers/virtio/virtio_input.c b/drivers/virtio/virtio_input.c index 60e2a16..6222f9b 100644 --- a/drivers/virtio/virtio_input.c +++ b/drivers/virtio/virtio_input.c @@ -320,6 +320,7 @@ static void virtinput_remove(struct virtio_device *vdev) spin_unlock_irqrestore(&vi->lock, flags); input_unregister_device(vi->idev); + vdev->config->reset(vdev); vdev->config->del_vqs(vdev); kfree(vi); } -- 2.1.4

...t a/drivers/virtio/virtio_input.c b/drivers/virtio/virtio_input.c index 60e2a16..6222f9b 100644 --- a/drivers/virtio/virtio_input.c +++ b/drivers/virtio/virtio_input.c @@ -320,6 +320,7 @@ static void virtinput_remove(struct virtio_device *vdev) spin_unlock_irqrestore(&vi->lock, flags); input_unregister_device(vi->idev); + vdev->config->reset(vdev); vdev->config->del_vqs(vdev); kfree(vi); } -- 2.1.4

.../drivers/virtio/virtio_input.c > index 60e2a16..6222f9b 100644 > --- a/drivers/virtio/virtio_input.c > +++ b/drivers/virtio/virtio_input.c > @@ -320,6 +320,7 @@ static void virtinput_remove(struct virtio_device *vdev) > spin_unlock_irqrestore(&vi->lock, flags); > > input_unregister_device(vi->idev); > + vdev->config->reset(vdev); > vdev->config->del_vqs(vdev); > kfree(vi); > } > -- > 2.1.4

...ut_remove(struct virtio_device *vdev) { struct virtio_input *vi = vdev->priv; + void *buf; unsigned long flags; spin_lock_irqsave(&vi->lock, flags); @@ -320,6 +321,9 @@ static void virtinput_remove(struct virtio_device *vdev) spin_unlock_irqrestore(&vi->lock, flags); input_unregister_device(vi->idev); + vdev->config->reset(vdev); + while ((buf = virtqueue_detach_unused_buf(vi->sts)) != NULL) + kfree(buf); vdev->config->del_vqs(vdev); kfree(vi); } -- 2.1.4

...ENXIO; } @@ -366,8 +360,6 @@ int vmmouse_detect(struct psmouse *psmouse, bool set_properties) psmouse->model = version; } - release_region(VMMOUSE_PROTO_PORT, 4); - return 0; } @@ -386,7 +378,6 @@ static void vmmouse_disconnect(struct psmouse *psmouse) psmouse_reset(psmouse); input_unregister_device(priv->abs_dev); kfree(priv); - release_region(VMMOUSE_PROTO_PORT, 4); } /** @@ -430,15 +421,10 @@ int vmmouse_init(struct psmouse *psmouse) struct input_dev *rel_dev = psmouse->dev, *abs_dev; int error; - if (!request_region(VMMOUSE_PROTO_PORT, 4, "vmmouse")) { - psmous...

...ENXIO; } @@ -366,8 +360,6 @@ int vmmouse_detect(struct psmouse *psmouse, bool set_properties) psmouse->model = version; } - release_region(VMMOUSE_PROTO_PORT, 4); - return 0; } @@ -386,7 +378,6 @@ static void vmmouse_disconnect(struct psmouse *psmouse) psmouse_reset(psmouse); input_unregister_device(priv->abs_dev); kfree(priv); - release_region(VMMOUSE_PROTO_PORT, 4); } /** @@ -430,15 +421,10 @@ int vmmouse_init(struct psmouse *psmouse) struct input_dev *rel_dev = psmouse->dev, *abs_dev; int error; - if (!request_region(VMMOUSE_PROTO_PORT, 4, "vmmouse")) { - psmous...

...ENXIO; } @@ -366,8 +360,6 @@ int vmmouse_detect(struct psmouse *psmouse, bool set_properties) psmouse->model = version; } - release_region(VMMOUSE_PROTO_PORT, 4); - return 0; } @@ -386,7 +378,6 @@ static void vmmouse_disconnect(struct psmouse *psmouse) psmouse_reset(psmouse); input_unregister_device(priv->abs_dev); kfree(priv); - release_region(VMMOUSE_PROTO_PORT, 4); } /** @@ -430,15 +421,10 @@ int vmmouse_init(struct psmouse *psmouse) struct input_dev *rel_dev = psmouse->dev, *abs_dev; int error; - if (!request_region(VMMOUSE_PROTO_PORT, 4, "vmmouse")) { - psmous...

...ut_remove(struct virtio_device *vdev) { struct virtio_input *vi = vdev->priv; + void *buf; unsigned long flags; spin_lock_irqsave(&vi->lock, flags); @@ -320,6 +321,9 @@ static void virtinput_remove(struct virtio_device *vdev) spin_unlock_irqrestore(&vi->lock, flags); input_unregister_device(vi->idev); + vdev->config->reset(vdev); + while ((buf = virtqueue_detach_unused_buf(vi->sts)) != NULL) + kfree(buf); vdev->config->del_vqs(vdev); kfree(vi); } -- 2.1.4

...ENXIO; } @@ -366,8 +360,6 @@ int vmmouse_detect(struct psmouse *psmouse, bool set_properties) psmouse->model = version; } - release_region(VMMOUSE_PROTO_PORT, 4); - return 0; } @@ -386,7 +378,6 @@ static void vmmouse_disconnect(struct psmouse *psmouse) psmouse_reset(psmouse); input_unregister_device(priv->abs_dev); kfree(priv); - release_region(VMMOUSE_PROTO_PORT, 4); } /** @@ -430,15 +421,10 @@ int vmmouse_init(struct psmouse *psmouse) struct input_dev *rel_dev = psmouse->dev, *abs_dev; int error; - if (!request_region(VMMOUSE_PROTO_PORT, 4, "vmmouse")) { - psmous...

...ENXIO; } @@ -366,8 +360,6 @@ int vmmouse_detect(struct psmouse *psmouse, bool set_properties) psmouse->model = version; } - release_region(VMMOUSE_PROTO_PORT, 4); - return 0; } @@ -386,7 +378,6 @@ static void vmmouse_disconnect(struct psmouse *psmouse) psmouse_reset(psmouse); input_unregister_device(priv->abs_dev); kfree(priv); - release_region(VMMOUSE_PROTO_PORT, 4); } /** @@ -430,15 +421,10 @@ int vmmouse_init(struct psmouse *psmouse) struct input_dev *rel_dev = psmouse->dev, *abs_dev; int error; - if (!request_region(VMMOUSE_PROTO_PORT, 4, "vmmouse")) { - psmous...

...eaks or other bugs. Also - can you name labels something sensible pls? out is usually for exiting on success too... E.g. out4 -> err_register etc. > +} > + > +static void virtinput_remove(struct virtio_device *vdev) > +{ > + struct virtio_input *vi = vdev->priv; > + > + input_unregister_device(vi->idev); > + vdev->config->reset(vdev); You don't really need a reset if you just to del_vqs. People do this if they want to prevent interrupts without deleting vqs. > + vdev->config->del_vqs(vdev); > + kfree(vi); free_device seems to be missing? > +} > + &gt...

...eaks or other bugs. Also - can you name labels something sensible pls? out is usually for exiting on success too... E.g. out4 -> err_register etc. > +} > + > +static void virtinput_remove(struct virtio_device *vdev) > +{ > + struct virtio_input *vi = vdev->priv; > + > + input_unregister_device(vi->idev); > + vdev->config->reset(vdev); You don't really need a reset if you just to del_vqs. People do this if they want to prevent interrupts without deleting vqs. > + vdev->config->del_vqs(vdev); > + kfree(vi); free_device seems to be missing? > +} > + &gt...

...you name labels something sensible pls? > out is usually for exiting on success too... > E.g. out4 -> err_register etc. Will fix. > > +static void virtinput_remove(struct virtio_device *vdev) > > +{ > > + struct virtio_input *vi = vdev->priv; > > + > > + input_unregister_device(vi->idev); > > + vdev->config->reset(vdev); > > You don't really need a reset if you just to del_vqs. > People do this if they want to prevent interrupts > without deleting vqs. Ok. > > + vdev->config->del_vqs(vdev); > > + kfree(vi); > > fr...

...you name labels something sensible pls? > out is usually for exiting on success too... > E.g. out4 -> err_register etc. Will fix. > > +static void virtinput_remove(struct virtio_device *vdev) > > +{ > > + struct virtio_input *vi = vdev->priv; > > + > > + input_unregister_device(vi->idev); > > + vdev->config->reset(vdev); > > You don't really need a reset if you just to del_vqs. > People do this if they want to prevent interrupts > without deleting vqs. Ok. > > + vdev->config->del_vqs(vdev); > > + kfree(vi); > > fr...

...out is usually for exiting on success too... > > E.g. out4 -> err_register etc. > > Will fix. > > > > +static void virtinput_remove(struct virtio_device *vdev) > > > +{ > > > + struct virtio_input *vi = vdev->priv; > > > + > > > + input_unregister_device(vi->idev); > > > + vdev->config->reset(vdev); > > > > You don't really need a reset if you just to del_vqs. > > People do this if they want to prevent interrupts > > without deleting vqs. > > Ok. > > > > + vdev->config->del_vq...

...out is usually for exiting on success too... > > E.g. out4 -> err_register etc. > > Will fix. > > > > +static void virtinput_remove(struct virtio_device *vdev) > > > +{ > > > + struct virtio_input *vi = vdev->priv; > > > + > > > + input_unregister_device(vi->idev); > > > + vdev->config->reset(vdev); > > > > You don't really need a reset if you just to del_vqs. > > People do this if they want to prevent interrupts > > without deleting vqs. > > Ok. > > > > + vdev->config->del_vq...

Hi, This patch adds a virtio driver for input devices. Specification: https://www.kraxel.org/cgit/virtio-spec/log/?h=virtio-input https://www.kraxel.org/virtio/virtio-v1.0-csprd03-virtio-input.html#x1-2640007 Qemu patches; https://lists.gnu.org/archive/html/qemu-devel/2015-03/threads.html#03973 Gerd Hoffmann (1): Add virtio-input driver. drivers/virtio/Kconfig | 10 ++

Hi, This patch adds a virtio driver for input devices. Specification: https://www.kraxel.org/cgit/virtio-spec/log/?h=virtio-input https://www.kraxel.org/virtio/virtio-v1.0-csprd03-virtio-input.html#x1-2640007 Qemu patches; https://lists.gnu.org/archive/html/qemu-devel/2015-03/threads.html#03973 Gerd Hoffmann (1): Add virtio-input driver. drivers/virtio/Kconfig | 10 ++

...evice(vi->idev); + if (err) + goto out4; + + return 0; + +out4: + input_free_device(vi->idev); +out3: + vdev->config->del_vqs(vdev); +out2: + kfree(vi); +out1: + return err; +} + +static void virtinput_remove(struct virtio_device *vdev) +{ + struct virtio_input *vi = vdev->priv; + + input_unregister_device(vi->idev); + vdev->config->reset(vdev); + vdev->config->del_vqs(vdev); + kfree(vi); +} + +static unsigned int features[] = { +}; +static struct virtio_device_id id_table[] = { + { VIRTIO_ID_INPUT, VIRTIO_DEV_ANY_ID }, + { 0 }, +}; + +static struct virtio_driver virtio_input_driver =...

...evice(vi->idev); + if (err) + goto out4; + + return 0; + +out4: + input_free_device(vi->idev); +out3: + vdev->config->del_vqs(vdev); +out2: + kfree(vi); +out1: + return err; +} + +static void virtinput_remove(struct virtio_device *vdev) +{ + struct virtio_input *vi = vdev->priv; + + input_unregister_device(vi->idev); + vdev->config->reset(vdev); + vdev->config->del_vqs(vdev); + kfree(vi); +} + +static unsigned int features[] = { +}; +static struct virtio_device_id id_table[] = { + { VIRTIO_ID_INPUT, VIRTIO_DEV_ANY_ID }, + { 0 }, +}; + +static struct virtio_driver virtio_input_driver =...