search for: inlinee

...viour. To solve this problem, work arounds were coded to redirect flow to catch-all regions, that created other problems, etc. Instead of running around in circles, the following rules must be observed when inlining/optimising: - When inlining a dispatch area, the inlined block must resume to the inlinee's dispatch block - If using eh.selector, inlining should append actions to inlinee's selector block - Optimisers should not remove unwind actions nor change their control flow (unless semantics is preserved) - If we allow changes, we need to explicitly describe the semantics or have one...

...#39;t repurpose containsIndirectBr because I felt what I'm looking for > is sufficiently different (indirectbr inhibits inlining, whereas > noduplicate does not, if there is one call site). I'm pretty sure that it's fine to inline indirectbr if there is a single call site and the inlinee is to be deleted. -Chris

Hi, Thanks for the pointers. My patch now calls the attribute "noduplicate", and updates CodeMetrics to have another field: bool notDuplicatable; Which semantically is "containsIndirectBr || containsNoDuplicateInst". I didn't repurpose containsIndirectBr because I felt what I'm looking for is sufficiently different (indirectbr inhibits inlining, whereas noduplicate

...inline through patchpoints as well. There are two distinct problems to solve before LLVM can inline through statepoints: # Managing data flow for the extra metadata args. LLVM needs some logic to "transfer" the extra live values attached to a statepoint/patchpoint into the body of the inlinee somehow. How this is handled depends on the semantics of the live values (something the frontend knows). There needs to be a clean way for the frontend to communicate this information to LLVM, or we need to devise a convention that is sensible for the kinds of frontends we wish to support. Initi...

In addition to an IR block id or probe Id, we’ll also need to know the inline context of a probe if it comes from an inlinee. The current pseudo probe encoding is based on a DFS walk of the inline tree. A MIR BB may contain probes from different inlinees, and we may need to extend the BB-info format for encode the inline contexts there. I’m happy to work with you on a encoding format that can be used for both Propeller a...

...tainsIndirectBr because I felt what I'm looking for > > is sufficiently different (indirectbr inhibits inlining, whereas > > noduplicate does not, if there is one call site). > > I'm pretty sure that it's fine to inline indirectbr if there is a single call site and the inlinee is to be deleted. > > -Chris > > -- IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it fo...

...insIndirectBr > > because I felt what I'm looking for is sufficiently different > > (indirectbr inhibits inlining, whereas noduplicate does not, if there is one call site). > > I'm pretty sure that it's fine to inline indirectbr if there is a single call site and the inlinee is to be deleted. > > -Chris > > -- IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it fo...

...ell. > > > There are two distinct problems to solve before LLVM can inline through statepoints: > > # Managing data flow for the extra metadata args. > > LLVM needs some logic to "transfer" the extra live values attached to a statepoint/patchpoint into the body of the inlinee somehow. How this is handled depends on the semantics of the live values (something the frontend knows). There needs to be a clean way for the frontend to communicate this information to LLVM, or we need to devise a convention that is sensible for the kinds of frontends we wish to support. Initi...

...> > because I felt what I'm looking for is sufficiently different > > > (indirectbr inhibits inlining, whereas noduplicate does not, if there is one call site). > > > > I'm pretty sure that it's fine to inline indirectbr if there is a single call site and the inlinee is to be deleted. > > > > -Chris > > > > > > > -- IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the conten...

...do justice for profile quality improvements that pseudo-probe brings us. One example is how FDO inliner evaluates call site. It checks callee’s total sample count instead of callee’s entry count. This is less than ideal, but we couldn’t fix it due to profile quality issues – we can’t reliably get inlinee’s entry count with dwarf based approach, see discussion in https://reviews.llvm.org/D60086<https://urldefense.proofpoint.com/v2/url?u=https-3A__reviews.llvm.org_D60086&d=DwMFaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=KfYo542rDdZQGClmgz-RBw&m=IiraiO5pLd86sJtoupX-V4fgITYAQHvv2GN-H_UmDXQ&s=T...

...addition to LBR entries. We use level 2 PEBS to control sampling skid so that the leaf frame from stack sample aligns with leaf frame from LBR. The raw call stack sample describes the calling context for the leaf LBR entry. In addition, by unwinding “call” and “return” (including implicit ones from inlinee) from LBR entries backwards on top of raw stack samples, we can recover the calling context for each of the LBR entries from the sample, thus synthesizing context-sensitive LBR profile. We can then generate context-sensitive sample PGO profile using the context-sensitive LBR profile. In the new pr...

...> > because I felt what I'm looking for is sufficiently different > > > (indirectbr inhibits inlining, whereas noduplicate does not, if there is one call site). > > > > I'm pretty sure that it's fine to inline indirectbr if there is a single call site and the inlinee is to be deleted. > > > > -Chris > > > > > > > -- IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the conten...

...do justice for profile quality improvements that pseudo-probe brings us. One example is how FDO inliner evaluates call site. It checks callee’s total sample count instead of callee’s entry count. This is less than ideal, but we couldn’t fix it due to profile quality issues – we can’t reliably get inlinee’s entry count with dwarf based approach, see discussion in https://reviews.llvm.org/D60086. That problem is solved with pseudo-probe, but until we change the inliner, we won’t see perf win from that particular profile quality improvement. There are other similar cases too, and that’s why we used pr...

...do justice for profile quality improvements that pseudo-probe brings us. One example is how FDO inliner evaluates call site. It checks callee’s total sample count instead of callee’s entry count. This is less than ideal, but we couldn’t fix it due to profile quality issues – we can’t reliably get inlinee’s entry count with dwarf based approach, see discussion in https://reviews.llvm.org/D60086<https://urldefense.proofpoint.com/v2/url?u=https-3A__reviews.llvm.org_D60086&d=DwMFaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=KfYo542rDdZQGClmgz-RBw&m=IiraiO5pLd86sJtoupX-V4fgITYAQHvv2GN-H_UmDXQ&s=T...

...provements that pseudo-probe brings us. > > > > One example is how FDO inliner evaluates call site. It checks callee’s > total sample count instead of callee’s entry count. This is less than > ideal, but we couldn’t fix it due to profile quality issues – we can’t > reliably get inlinee’s entry count with dwarf based approach, see > discussion in https://reviews.llvm.org/D60086 > <https://urldefense.proofpoint.com/v2/url?u=https-3A__reviews.llvm.org_D60086&d=DwMFaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=KfYo542rDdZQGClmgz-RBw&m=IiraiO5pLd86sJtoupX-V4fgITYAQHvv2GN-H_Um...

Hi Bill, there are a couple of things I didn't understand about your proposal, for example how it interacts with inlining, whether it is feasible to do the "turn invoke-of-Unwind_Resume into a branch" optimization and also whether in "resumedest" you still plan to use _Unwind_Resume to continue unwinding up the stack. Could you please show what the LLVM IR would look like

...do justice for profile quality improvements that pseudo-probe brings us. One example is how FDO inliner evaluates call site. It checks callee’s total sample count instead of callee’s entry count. This is less than ideal, but we couldn’t fix it due to profile quality issues – we can’t reliably get inlinee’s entry count with dwarf based approach, see discussion in https://reviews.llvm.org/D60086<https://urldefense.proofpoint.com/v2/url?u=https-3A__reviews.llvm.org_D60086&d=DwMFaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=KfYo542rDdZQGClmgz-RBw&m=IiraiO5pLd86sJtoupX-V4fgITYAQHvv2GN-H_UmDXQ&s=T...

...unwind label %Landing.Pad region(1) personality [i32 (...)* @__gxx_personality_v0] Inlining ======== Inlining regions results in a merging of dispatch instructions. Care must be taken when inlining into the cleanup code of a landing pad. The "resume" of the inlinee may need to point to the "resume" of the inliner region. Future Work =========== This design is meant to be extensible. We don't address augmenting basic blocks as in Chris's note. However, this design allows for that eventuality; it simply doesn't require it. I.e., when th...

This is a revision of the second exception handling proposal I sent out. You can see it here: http://lists.cs.uiuc.edu/pipermail/llvmdev/2010-November/036484.html After much discussion, there are some changes to the proposal – some significant and some minor. One major point, this proposal does not address the issue of catching an exception thrown from a non-invoke instruction. However if done