search for: initglobals

As I wrote the trick here is sneak the initGlobals() into the places where we do pass registration which should get you a big part of the way. For the remaining cases you have to add a few functions and call them from init() like functions which we have all over llvm anyway because of pass registration. - Matthias > On Dec 13, 2016, at 3:46 PM...

...>>> >>>>>>> but I fail to see how that helps Statistic variables which are still global. >>>>>> >>>>>> Admittedly the "static void registerOptions()" part of that patch appears to have the same/similar role than the "initGlobals()" I proposed. >>>>>> >>>>> >>>>> Right, basically there wouldn’t be any global variables, that would apply to statistics as well. The way Chris did it somehow was to use a singleton registry for this. >>>>> You could do the sam...

...t free functions here and there using statistics. Tracking what’s initialized where and when might become hairy. > >> On Dec 13, 2016, at 3:47 PM, Matthias Braun <mbraun at apple.com <mailto:mbraun at apple.com>> wrote: >> >> As I wrote the trick here is sneak the initGlobals() into the places where we do pass registration which should get you a big part of the way. For the remaining cases you have to add a few functions and call them from init() like functions which we have all over llvm anyway because of pass registration. >> >> - Matthias >> >&...

...://reviews.llvm.org/D5389 <http://reviews.llvm.org/D5389> >> >> but I fail to see how that helps Statistic variables which are still global. > > Admittedly the "static void registerOptions()" part of that patch appears to have the same/similar role than the "initGlobals()" I proposed. > Right, basically there wouldn’t be any global variables, that would apply to statistics as well. The way Chris did it somehow was to use a singleton registry for this. You could do the same for statistic and have any component that needs to use a statistic to get a refer...

...> and > http://reviews.llvm.org/D5389 <http://reviews.llvm.org/D5389> > > but I fail to see how that helps Statistic variables which are still global. Admittedly the "static void registerOptions()" part of that patch appears to have the same/similar role than the "initGlobals()" I proposed. - Matthias > > - Matthias > > [1] Please someone please give us an easier time to access old mails when you just have the old link... > > >> >> Mehdi >> >> >> >>> So here comes the strawman: >>> >&g...

...org/D5389 <http://reviews.llvm.org/D5389> >>> >>> but I fail to see how that helps Statistic variables which are still global. >> >> Admittedly the "static void registerOptions()" part of that patch appears to have the same/similar role than the "initGlobals()" I proposed. >> > > Right, basically there wouldn’t be any global variables, that would apply to statistics as well. The way Chris did it somehow was to use a singleton registry for this. > You could do the same for statistic and have any component that needs to use a stati...

...tp://reviews.llvm.org/D5389> >>>> >>>> but I fail to see how that helps Statistic variables which are still global. >>> >>> Admittedly the "static void registerOptions()" part of that patch appears to have the same/similar role than the "initGlobals()" I proposed. >>> >> >> Right, basically there wouldn’t be any global variables, that would apply to statistics as well. The way Chris did it somehow was to use a singleton registry for this. >> You could do the same for statistic and have any component that need...

...m.org/D5389> >>>>> >>>>> but I fail to see how that helps Statistic variables which are still global. >>>> >>>> Admittedly the "static void registerOptions()" part of that patch appears to have the same/similar role than the "initGlobals()" I proposed. >>>> >>> >>> Right, basically there wouldn’t be any global variables, that would apply to statistics as well. The way Chris did it somehow was to use a singleton registry for this. >>> You could do the same for statistic and have any com...

...>>>>>> >>>>>> but I fail to see how that helps Statistic variables which are still global. >>>>> >>>>> Admittedly the "static void registerOptions()" part of that patch appears to have the same/similar role than the "initGlobals()" I proposed. >>>>> >>>> >>>> Right, basically there wouldn’t be any global variables, that would apply to statistics as well. The way Chris did it somehow was to use a singleton registry for this. >>>> You could do the same for statistic...

> On Dec 13, 2016, at 3:23 PM, Mehdi Amini <mehdi.amini at apple.com> wrote: > >> >> On Dec 13, 2016, at 1:22 PM, Matthias Braun via llvm-dev <llvm-dev at lists.llvm.org> wrote: >> >> >>> On Dec 13, 2016, at 12:56 PM, Reid Kleckner <rnk at google.com> wrote: >>> >>> Given that LLVM has so many auto-registration systems