search for: initex

...ng.h> #include <unistd.h> #include <dlfcn.h> +#include <fcntl.h> #define NBDKIT_API_VERSION 2 @@ -72,7 +73,8 @@ int vddk_debug_extents; #define VDDK_MINOR 1 static void *dl = NULL; /* dlopen handle */ -static int init_called = 0; /* was InitEx called */ +static bool init_called = false; /* was InitEx called */ +static char *reexeced = false; /* did libdir require reexec */ static char *config = NULL; /* config */ static const char *cookie = NULL; /* cookie */ @@ -162,6 +164,8 @@ vddk_unloa...

...east VDDK 5.5.5 (2015) * which is the earliest version of VDDK that we support. */ diff --git a/plugins/vddk/vddk.c b/plugins/vddk/vddk.c index e2c0bf7d..87c0d146 100644 --- a/plugins/vddk/vddk.c +++ b/plugins/vddk/vddk.c @@ -70,7 +70,7 @@ int vddk_debug_datapath = 1; /* Parameters passed to InitEx. */ #define VDDK_MAJOR 5 -#define VDDK_MINOR 1 +#define VDDK_MINOR 5 static void *dl; /* dlopen handle */ static bool init_called; /* was InitEx called */ @@ -363,14 +363,14 @@ load_library (void) static const char *sonames[] = { /* Prefer the...

We had a query yesterday about the VDDK plugin and making it actually obey the weird "Multithreading Considerations" rules in the VDDK documentation (https://vdc-download.vmware.com/vmwb-repository/dcr-public/8f96698a-0e7b-4d67-bb6c-d18a1d101540/ef536a47-27cd-481a-90ef-76b38e75353c/vsphere-vddk-671-programming-guide.pdf) This patch is my attempt to implement this. The idea is that the

I couldn't get this to work in the end. This is the latest non-working version. This email documents what doesn't work for the permanent record. The central problem is that VDDK InitEx() appears to dlopen() various of its own plugins. Although I wasn't able to capture exactly what dlopen() command it is running, the plugins cannot be loaded because they rely on the recompiled system libraries (libcrypto.so.X etc) and it cannot find those because $LD_LIBRARY_PATH is not set....

...s. It has been tested with all versions up to 6.7 (but should work with future versions). diff --git a/plugins/vddk/vddk.c b/plugins/vddk/vddk.c index 1beecabc..4bfcdea7 100644 --- a/plugins/vddk/vddk.c +++ b/plugins/vddk/vddk.c @@ -71,7 +71,7 @@ int vddk_debug_extents; /* Parameters passed to InitEx. */ #define VDDK_MAJOR 5 -#define VDDK_MINOR 1 +#define VDDK_MINOR 5 static void *dl; /* dlopen handle */ static bool init_called; /* was InitEx called */ @@ -361,14 +361,14 @@ load_library (void) static const char *sonames[] = { /* Prefer the...

...<dlfcn.h> > +#include <fcntl.h> > > #define NBDKIT_API_VERSION 2 > > @@ -72,7 +73,8 @@ int vddk_debug_extents; > #define VDDK_MINOR 1 > > static void *dl = NULL; /* dlopen handle */ > -static int init_called = 0; /* was InitEx called */ > +static bool init_called = false; /* was InitEx called */ > +static char *reexeced = false; /* did libdir require reexec */ I guess this works, but is "NULL" better than "false"? > + /* If load_library caused a re-execution with an e...

This is my second attempt at this. The first version (also not working) was here: https://www.redhat.com/archives/libguestfs/2019-October/msg00062.html In part 1/2 I introduce a new .ready_to_serve plugin method which is called after forking and just before accepting any client connection. The idea would be that plugins could start background threads here. However this doesn't work well in

...har *buf); +static VixError (*VixDiskLib_QueryAllocatedBlocks) (VixDiskLibHandle diskHandle, uint64_t start_sector, uint64_t nr_sectors, uint64_t chunk_size, VixDiskLibBlockList **block_list); +static VixError (*VixDiskLib_FreeBlockList) (VixDiskLibBlockList *block_list); /* Parameters passed to InitEx. */ #define VDDK_MAJOR 5 @@ -174,6 +178,11 @@ vddk_load (void) VixDiskLib_FreeInfo = dlsym (dl, "VixDiskLib_FreeInfo"); VixDiskLib_Read = dlsym (dl, "VixDiskLib_Read"); VixDiskLib_Write = dlsym (dl, "VixDiskLib_Write"); + + /* Added in VDDK 6.7, these will b...

...h> +#include <pthread.h> + #define NBDKIT_API_VERSION 2 - #include <nbdkit-plugin.h> #include "cleanup.h" @@ -76,6 +77,7 @@ int vddk_debug_datapath = 1; static void *dl; /* dlopen handle */ static bool init_called; /* was InitEx called */ static char *reexeced; /* orig LD_LIBRARY_PATH on reexec */ +static pthread_key_t error_suppression; /* threadlocal error suppression */ static char *config; /* config */ static const char *cookie; /* cookie */ @@ -108,6 +1...

In v7: everything should work now! The re-exec code is slightly simplified, with Rich's suggestion to pass the original LD_LIBRARY_PATH rather than just the prefix being added, and I've now finished wiring up the initial dlopen() check into code that correctly computes the right prefix dir to add to LD_LIBRARY_PATH. Eric Blake (1): vddk: Add re-exec with altered environment Richard

...15 (TeX Live 2014) (preloaded format=pdflatex) restricted \write18 enabled. kpathsea: Running mktexfmt pdflatex.fmt fmtutil: running `pdftex -ini -jobname=pdflatex -progname=pdflatex -translate-file=cp227.tcx *pdflatex.ini' ... This is pdfTeX, Version 3.14159265-2.6-1.40.15 (TeX Live 2014) (INITEX) restricted \write18 enabled. (/home/travis/R-bin/texlive/texmf-dist/web2c/cp227.tcx) entering extended mode (/home/travis/R-bin/texlive/texmf-dist/tex/latex/latexconfig/pdflatex.ini (/home/travis/R-bin/texlive/texmf-config/tex/generic/config/pdftexconfig.tex) (/home/travis/R-bin/texlive/texmf-di...

...spencerg D:\spencerg>cd statmtds D:\spencerg\statmtds>cd R D:\spencerg\statmtds\R>cd Rnews D:\spencerg\statmtds\R\Rnews>pdflatex wrapper.tex This is pdfTeX, Version 3.1415926-1.40.9 (MiKTeX 2.7) Running pdftex... This is pdfTeX, Version 3.1415926-1.40.9 (MiKTeX 2.7) (INITEX) entering extended mode ("d:\Program Files\MiKTeX 2.7\tex\latex\config\pdflatex.ini" ("C:\Documents and Settings\All Users\Application Data\MiKTeX\2.7\tex\generic\c onfig\pdftexconfig.tex") ("d:\Program Files\MiKTeX 2.7\tex\latex\base\latex.ltx" ("d:\Progra...

...ding.h" -#include "vector.h" +#include "vddk.h" #include "vddk-structs.h" /* Debug flags. */ @@ -76,13 +75,12 @@ int vddk_debug_datapath = 1; static void *dl; /* dlopen handle */ static bool init_called; /* was InitEx called */ -static char *reexeced; /* orig LD_LIBRARY_PATH on reexec */ static pthread_key_t error_suppression; /* threadlocal error suppression */ static char *config; /* config */ static const char *cookie; /* cookie */ static cons...

...x) > restricted \write18 enabled. > kpathsea: Running mktexfmt pdflatex.fmt > fmtutil: running `pdftex -ini -jobname=pdflatex -progname=pdflatex > -translate-file=cp227.tcx *pdflatex.ini' ... > This is pdfTeX, Version 3.14159265-2.6-1.40.15 (TeX Live 2014) (INITEX) > restricted \write18 enabled. > (/home/travis/R-bin/texlive/texmf-dist/web2c/cp227.tcx) > entering extended mode > (/home/travis/R-bin/texlive/texmf-dist/tex/latex/latexconfig/pdflatex.ini > (/home/travis/R-bin/texlive/texmf-config/tex/generic/config/pdftexconfi...

...; #define VDDK_MAJOR 5 #define VDDK_MINOR 1 -static void *dl = NULL; /* dlopen handle */ +static void *shimdl = NULL; /* shim dlopen handle */ +static void *dl = NULL; /* vddk dlopen handle */ static int init_called = 0; /* was InitEx called */ static char *config = NULL; /* config */ @@ -153,6 +156,8 @@ vddk_unload (void) } if (dl) dlclose (dl); + if (shimdl) + dlclose (shimdl); free (config); free (libdir); free (password); @@ -248,17 +253,67 @@ load_library (void) { static const ch...

Probably needs a bit of cleanup, but seems like it is generally the right direction. One thing I've noticed is that the expect test randomly (but rarely) hangs :-( I guess something is racey but I don't know what at the moment. Rich.

Not sure what version we're up to, but this reimplements extents using the new simpler structure described in this thread: https://www.redhat.com/archives/libguestfs/2019-March/msg00077.html I also fixed most of the things that Eric pointed out in the previous review, although I need to go back over his replies and check I've got everything. This needs a bit more testing. However the

I'm not sure exactly which version we're up to, but let's say it's version 4. I'm a lot happier with this version: - all filters have been reviewed and changed where I think that's necessary - can_extents is properly defined and implemented now - NBD protocol is followed - I believe it addresses all previous review points where possible The "only" thing

I want to post this but mainly for discussion and early review. It's not safe for these patches to all go upstream yet (because not all filters have been checked/adjusted), but if any patches were to go upstream then probably 1 & 2 only are safe. File, VDDK, memory and data plugins all work, although I have only done minimal testing on them. The current tests, such as they are, all

This has already been pushed upstream. I am simply posting these here so we have a reference in the mailing list in case we find bugs later (as I'm sure we will - it's a complex patch series). Great thanks to Eric Blake for tireless review on this one. It also seems to have identified a few minor bugs in qemu along the way. Rich.