search for: infer_attribute

...e OK to add auto-hide in this case (maybe it would already happen)? Can we use the new local_unnamed_addr that was added (by pcc or Rafael I don't remember)? I think this attribute matches exactly the `auto-hide` semantic. Wasn't the idea that this could be added any time by a module-level `infer_attribute` pass? -- Mehdi 2018-02-07 11:36 GMT-08:00 Steven Wu via llvm-dev <llvm-dev at lists.llvm.org>: > I didn't realize that that WeakDefCanBeHiddenDirective is only available > on Darwin. So if we are doing it for #2, it should be a Darwin only fix as > well. > > Steven &g...

...to add auto-hide in this case (maybe it would already happen)? > Can we use the new local_unnamed_addr that was added (by pcc or Rafael I don't remember)? I think this attribute matches exactly the `auto-hide` semantic. Wasn't the idea that this could be added any time by a module-level `infer_attribute` pass? > > -- > Mehdi > > > 2018-02-07 11:36 GMT-08:00 Steven Wu via llvm-dev <llvm-dev at lists.llvm.org <mailto:llvm-dev at lists.llvm.org>>: > I didn't realize that that WeakDefCanBeHiddenDirective is only available on Darwin. So if we are doing it for #2...

...; in this case (maybe it would already happen)? > Can we use the new local_unnamed_addr that was added (by pcc or Rafael I > don't remember)? I think this attribute matches exactly the `auto-hide` > semantic. Wasn't the idea that this could be added any time by a > module-level `infer_attribute` pass? > > -- > Mehdi > > > 2018-02-07 11:36 GMT-08:00 Steven Wu via llvm-dev <llvm-dev at lists.llvm.org > >: > >> I didn't realize that that WeakDefCanBeHiddenDirective is only available >> on Darwin. So if we are doing it for #2, it should be a Darwi...

...maybe it would already happen)? >> Can we use the new local_unnamed_addr that was added (by pcc or Rafael I >> don't remember)? I think this attribute matches exactly the `auto-hide` >> semantic. Wasn't the idea that this could be added any time by a >> module-level `infer_attribute` pass? >> >> -- >> Mehdi >> >> >> 2018-02-07 11:36 GMT-08:00 Steven Wu via llvm-dev < >> llvm-dev at lists.llvm.org>: >> >>> I didn't realize that that WeakDefCanBeHiddenDirective is only available >>> on Darwin. So if we a...

...dd auto-hide in this case (maybe it would already happen)? >> Can we use the new local_unnamed_addr that was added (by pcc or Rafael I don't remember)? I think this attribute matches exactly the `auto-hide` semantic. Wasn't the idea that this could be added any time by a module-level `infer_attribute` pass? >> >> -- >> Mehdi >> >> >> 2018-02-07 11:36 GMT-08:00 Steven Wu via llvm-dev <llvm-dev at lists.llvm.org <mailto:llvm-dev at lists.llvm.org>>: >> I didn't realize that that WeakDefCanBeHiddenDirective is only available on Darwin....

...lready happen)? >>> Can we use the new local_unnamed_addr that was added (by pcc or Rafael I >>> don't remember)? I think this attribute matches exactly the `auto-hide` >>> semantic. Wasn't the idea that this could be added any time by a >>> module-level `infer_attribute` pass? >>> >>> -- >>> Mehdi >>> >>> >>> 2018-02-07 11:36 GMT-08:00 Steven Wu via llvm-dev < >>> llvm-dev at lists.llvm.org>: >>> >>>> I didn't realize that that WeakDefCanBeHiddenDirective is only >>...

...uto-hide in this case (maybe it would already happen)? >>> Can we use the new local_unnamed_addr that was added (by pcc or Rafael I don't remember)? I think this attribute matches exactly the `auto-hide` semantic. Wasn't the idea that this could be added any time by a module-level `infer_attribute` pass? >>> >>> -- >>> Mehdi >>> >>> >>> 2018-02-07 11:36 GMT-08:00 Steven Wu via llvm-dev <llvm-dev at lists.llvm.org <mailto:llvm-dev at lists.llvm.org>>: >>> I didn't realize that that WeakDefCanBeHiddenDirective i...

...hide in this case (maybe it would already happen)? >>>> Can we use the new local_unnamed_addr that was added (by pcc or Rafael I don't remember)? I think this attribute matches exactly the `auto-hide` semantic. Wasn't the idea that this could be added any time by a module-level `infer_attribute` pass? >>>> >>>> -- >>>> Mehdi >>>> >>>> >>>> 2018-02-07 11:36 GMT-08:00 Steven Wu via llvm-dev <llvm-dev at lists.llvm.org <mailto:llvm-dev at lists.llvm.org>>: >>>> I didn't realize that that W...

...>>>> Can we use the new local_unnamed_addr that was added (by pcc or Rafael >>>> I don't remember)? I think this attribute matches exactly the `auto-hide` >>>> semantic. Wasn't the idea that this could be added any time by a >>>> module-level `infer_attribute` pass? >>>> >>>> -- >>>> Mehdi >>>> >>>> >>>> 2018-02-07 11:36 GMT-08:00 Steven Wu via llvm-dev <llvm-dev at lists.llvm. >>>> org>: >>>> >>>>> I didn't realize that that WeakDefC...

...> Can we use the new local_unnamed_addr that was added (by pcc or Rafael >>>>> I don't remember)? I think this attribute matches exactly the `auto-hide` >>>>> semantic. Wasn't the idea that this could be added any time by a >>>>> module-level `infer_attribute` pass? >>>>> >>>>> -- >>>>> Mehdi >>>>> >>>>> >>>>> 2018-02-07 11:36 GMT-08:00 Steven Wu via llvm-dev < >>>>> llvm-dev at lists.llvm.org>: >>>>> >>>>>> I d...

...in this case (maybe it would already happen)? >>>>> Can we use the new local_unnamed_addr that was added (by pcc or Rafael I don't remember)? I think this attribute matches exactly the `auto-hide` semantic. Wasn't the idea that this could be added any time by a module-level `infer_attribute` pass? >>>>> >>>>> -- >>>>> Mehdi >>>>> >>>>> >>>>> 2018-02-07 11:36 GMT-08:00 Steven Wu via llvm-dev <llvm-dev at lists.llvm.org <mailto:llvm-dev at lists.llvm.org>>: >>>>> I di...

...>>>> Can we use the new local_unnamed_addr that was added (by pcc or Rafael >>>> I don't remember)? I think this attribute matches exactly the `auto-hide` >>>> semantic. Wasn't the idea that this could be added any time by a >>>> module-level `infer_attribute` pass? >>>> >>>> -- >>>> Mehdi >>>> >>>> >>>> 2018-02-07 11:36 GMT-08:00 Steven Wu via llvm-dev <llvm-dev at lists.llvm. >>>> org>: >>>> >>>>> I didn't realize that that WeakDefC...

...this case (maybe it would already happen)? >>>>>> Can we use the new local_unnamed_addr that was added (by pcc or Rafael I don't remember)? I think this attribute matches exactly the `auto-hide` semantic. Wasn't the idea that this could be added any time by a module-level `infer_attribute` pass? >>>>>> >>>>>> -- >>>>>> Mehdi >>>>>> >>>>>> >>>>>> 2018-02-07 11:36 GMT-08:00 Steven Wu via llvm-dev <llvm-dev at lists.llvm.org <mailto:llvm-dev at lists.llvm.org>>: &...

I didn't realize that that WeakDefCanBeHiddenDirective is only available on Darwin. So if we are doing it for #2, it should be a Darwin only fix as well. Steven > On Feb 7, 2018, at 11:29 AM, Reid Kleckner <rnk at google.com> wrote: > > I agree with Teresa, we should probably do #2 to preserve behavior for now. > > On Wed, Feb 7, 2018 at 9:34 AM, Teresa Johnson via

...use the new local_unnamed_addr that was added (by pcc or >>>>>> Rafael I don't remember)? I think this attribute matches exactly the >>>>>> `auto-hide` semantic. Wasn't the idea that this could be added any time by >>>>>> a module-level `infer_attribute` pass? >>>>>> >>>>>> -- >>>>>> Mehdi >>>>>> >>>>>> >>>>>> 2018-02-07 11:36 GMT-08:00 Steven Wu via llvm-dev < >>>>>> llvm-dev at lists.llvm.org>: >>>>>&...

...case (maybe it would already happen)? >>>>>>> Can we use the new local_unnamed_addr that was added (by pcc or Rafael I don't remember)? I think this attribute matches exactly the `auto-hide` semantic. Wasn't the idea that this could be added any time by a module-level `infer_attribute` pass? >>>>>>> >>>>>>> -- >>>>>>> Mehdi >>>>>>> >>>>>>> >>>>>>> 2018-02-07 11:36 GMT-08:00 Steven Wu via llvm-dev <llvm-dev at lists.llvm.org <mailto:llvm-dev at l...

I agree with Teresa, we should probably do #2 to preserve behavior for now. On Wed, Feb 7, 2018 at 9:34 AM, Teresa Johnson via llvm-dev < llvm-dev at lists.llvm.org> wrote: > Hi Steven, > > I'd prefer not to inhibit importing. I am also concerned about putting > these symbols in the llvm.compiler_used (I don't recall earlier discussion > around this, but it seems