search for: indisk

...&& machine_readable then ( printf "virt-sparsify\n"; printf "linux-swap\n"; printf "zero\n"; @@ -126,23 +127,19 @@ read the man page virt-sparsify(1). exit 0 ); - (* Verify we got exactly 1 or 2 disks, depending on the mode. *) - let indisk, outdisk = - match in_place, List.rev !disks with - | false, [indisk; outdisk] -> indisk, outdisk - | true, [disk] -> disk, "" - | _ -> - error "usage is: %s [--options] indisk outdisk OR %s --in-place disk" - prog prog in + let indisk, mode = +...

...mdline.ml b/sparsify/cmdline.ml index 3eb0d5b..523d612 100644 --- a/sparsify/cmdline.ml +++ b/sparsify/cmdline.ml @@ -142,11 +142,7 @@ read the man page virt-sparsify(1). (* The input disk must be an absolute path, so we can store the name * in the overlay disk. *) - let indisk = - if not (Filename.is_relative indisk) then - indisk - else - Sys.getcwd () // indisk in + let indisk = absolute_path indisk in (* Check the output is not a char special (RHBZ#1056290). *) if is_char_device outdisk then diff --git a/v2v/input_d...

...cmdline.ml b/sparsify/cmdline.ml index 868456f..8f2b721 100644 --- a/sparsify/cmdline.ml +++ b/sparsify/cmdline.ml @@ -25,9 +25,18 @@ open Common_utils open Utils -type mode_t = -| Mode_copying of string * check_t * bool * string option * string option * - string option +type cmdline = { + indisk : string; + format : string option; + ignores : string list; + machine_readable : bool; + zeroes : string list; + mode : mode_t; +} + +and mode_t = +| Mode_copying of + string * check_t * bool * string option * string option * string option | Mode_in_place and check_t = [`Ignore|`Continue...

...g#add_drive "/dev/null"; g#launch (); if g#feature_available [| "ntfsprogs"; "ntfs3g" |] then diff --git a/sparsify/copying.ml b/sparsify/copying.ml index ef196f6..bef0664 100644 --- a/sparsify/copying.ml +++ b/sparsify/copying.ml @@ -60,7 +60,7 @@ let run indisk outdisk check_tmpdir compress convert | Some fmt -> fmt (* user specified input format, use that *) | None -> (* Don't know, so we must autodetect. *) - match (new G.guestfs ())#disk_format indisk with + match (open_guestfs ())#disk_format indisk...

This still isn't working at the moment. See: http://marc.info/?t=139457409300003&r=1&w=2 This set of patches: - Adds new APIs to support discard in libguestfs. - Adds discard support to virt-format. - Adds discard support to virt-sysprep. - Implements virt-sparsify --in-place. Rich.

The first patch is just some simple refactoring. See the second patch for a description of the new virt-sparsify --tmp option. I tested this using a loopback device as my temporary block device, and it seems to work fine for me. Federico .. this needs a BZ :-) Rich.

...gt; Pino Toscano Thanks, Pino. Attached is the requested log. A few other observations: In most directories, I can run the command successfully whether a file of the same name is present or not. Looking at the verbose output, it appears that a randomly-generated name in /var/tmp is used for the indisk. Example: virt-resize --verbose --format raw --output-format raw --expand /dev/sda3 --unknown-filesystems error /var/tmp/vbaf3053.img test.img For directories where it fails, both the indisk and outdisk are the same: virt-resize --verbose --format raw --output-format raw --expand /dev/sda3 --unk...

...s.set_up_progress_bar ~machine_readable:(machine_readable ()) g; g#launch (); g (* Return new handle. *) diff --git a/sparsify/cmdline.ml b/sparsify/cmdline.ml index 3e21428c2..b0af053ac 100644 --- a/sparsify/cmdline.ml +++ b/sparsify/cmdline.ml @@ -31,7 +31,6 @@ type cmdline = { indisk : string; format : string option; ignores : string list; - machine_readable : bool; zeroes : string list; mode : mode_t; } @@ -60,7 +59,6 @@ let parse_cmdline () = let format = ref "" in let ignores = ref [] in let in_place = ref false in - let machine_readable = r...

This set of patches: - Adds new APIs to support discard in libguestfs. - Adds discard support to virt-format. - Adds discard support to virt-sysprep. - Implements virt-sparsify --in-place. This is now working, after fixing the rather stupid bug in fstrim. I've pushed the ones which were ACKed previously + the fstrim fix. Rich.

Store the machine-readable flag globally, just like done for verbose/debug/etc, and enhance create_standard_options to provide --machine-readable automatically. --- common/mlstdutils/std_utils.ml | 4 ++++ common/mlstdutils/std_utils.mli | 7 +++++-- common/mltools/tools_utils.ml | 7 ++++++- common/mltools/tools_utils.mli | 5 ++++- 4 files changed, 19 insertions(+), 4 deletions(-) diff

...str -> Some str in - let debug_gc = !debug_gc in let format = match !format with "" -> None | str -> Some str in let ignores = List.rev !ignores in let in_place = !in_place in @@ -188,4 +186,4 @@ read the man page virt-sparsify(1). else Mode_in_place in - indisk, debug_gc, format, ignores, machine_readable, zeroes, mode + indisk, format, ignores, machine_readable, zeroes, mode diff --git a/sparsify/sparsify.ml b/sparsify/sparsify.ml index 1f631d8..30e3020 100644 --- a/sparsify/sparsify.ml +++ b/sparsify/sparsify.ml @@ -30,7 +30,7 @@ module G = Guestfs le...

...o. Attached is the requested log. A few other observations: > > In most directories, I can run the command successfully whether a file of > the same name is present or not. > > Looking at the verbose output, it appears that a randomly-generated name in > /var/tmp is used for the indisk. Example: > > virt-resize --verbose --format raw --output-format raw --expand /dev/sda3 > --unknown-filesystems error /var/tmp/vbaf3053.img test.img > > For directories where it fails, both the indisk and outdisk are the same: > > virt-resize --verbose --format raw --output-...

Hi, I was trying out virt-builder and noticed that in some directories I receive an error when the image is resized. For example, if I run the following command from my home directory it works fine: virt-builder rhel-7.4 --size 10G --output test.img If I run the same command from /tmp or /vms (my default libvirt pool), I see the following in my verbose output: virt-resize '--verbose'

...>> > >> We are trying not to start a appliance guest when issuing a libguestfs > >> command, such as virt-resize. > > > > There may be some confusion here. Virt-resize doesn't run the guest. > When i issue virt-resize, i exactly saw one guest is started, indisk > and outdisk are attached to this guest.... > > Do you mean that in the latest upstream, virt-resize doesn't run the guest? OK so you mean the libguestfs appliance. > > TBH I'm not exactly sure what your concerns are. > > We are afraid that if a guest is started whe...

A lot of code runs 'qemu-img create' or 'truncate' to create blank disk images. In the past I resisted adding an API to do this, since it essentially duplicates what you can already do using other tools (ie. qemu-img). However this does simplify calling code quite a lot since qemu-img is somewhat error-prone to use (eg: don't try to create a disk called "foo:bar")

...nd the output disk. -The output disk is the one created in the previous step. +virt-resize takes two mandatory parameters, the input disk and the +output disk (both can be e.g. a device, a file, or a URI to a remote +disk). The output disk is the one created in the previous step. # virt-resize indisk outdisk -- 2.7.4

On Fri, Oct 10, 2014 at 04:03:26PM +0800, Zhi Yong Wu wrote: > On Fri, Oct 10, 2014 at 3:39 PM, Richard W.M. Jones <rjones@redhat.com> wrote: > > On Fri, Oct 10, 2014 at 11:40:03AM +0800, Zhi Yong Wu wrote: > >> HI, Richard > >> > >> Is there any plan to make daemon to directly run on the hypervisor, > >> not starting a guest? e.g. directly export

...nd the output disk. -The output disk is the one created in the previous step. +virt-resize takes two mandatory parameters, the input disk and the +output disk (both can be e.g. a device, a file, or a URI to a remote +disk). The output disk is the one created in the previous step. # virt-resize indisk outdisk -- 2.9.3

...p with "" -> None | str -> Some str in - let verbose = !verbose in - let trace = !trace in let zeroes = List.rev !zeroes in (* No arguments and machine-readable mode? Print out some facts @@ -195,4 +191,4 @@ read the man page virt-sparsify(1). Mode_in_place in indisk, debug_gc, format, ignores, machine_readable, - quiet, verbose, trace, zeroes, mode + quiet, zeroes, mode diff --git a/sparsify/copying.ml b/sparsify/copying.ml index 9f788b9..9f20fa3 100644 --- a/sparsify/copying.ml +++ b/sparsify/copying.ml @@ -39,7 +39,7 @@ type tmp_place = let run indi...

Version 1 of the patch, for discussion, but not to be applied. It does work, but needs a lot more testing. This removes all the psychopathic gettextify cruft, and replaces it with a 99 line Makefile.am. A large win, I think. The third patch implements gettext support in the OCaml tools. The fourth patch is just for illustration. It shows the consequent changes to libguestfs.pot and the po