search for: incsecure

...X? > > > > > >ovirt-imageio authentication is based on the assumption that the > >secret random url is passed from engine  to the user via https. > >if this access engine using clear text then yes it is bad :-) > > > >Ondra, can you explain the semantics of incsecure=True? > > I can see you are using 'ca_file' attribute. So you should use > insecure=True, only when user don't pass ca_file. If you pass > insecure=True we don't validate certificate, but https still can be > used. Preferred is of course using ca_file to validate cer...

...insecure = True,        # XXX? > > > ovirt-imageio authentication is based on the assumption that the > secret random url is passed from engine  to the user via https. > if this access engine using clear text then yes it is bad :-) > > Ondra, can you explain the semantics of incsecure=True? I can see you are using 'ca_file' attribute. So you should use insecure=True, only when user don't pass ca_file. If you pass insecure=True we don't validate certificate, but https still can be used. Preferred is of course using ca_file to validate certificates. > >...

...logging.getLogger(), > + insecure = True, # XXX? > ovirt-imageio authentication is based on the assumption that the secret random url is passed from engine to the user via https. if this access engine using clear text then yes it is bad :-) Ondra, can you explain the semantics of incsecure=True? > +) > + > +system_service = connection.system_service() > + > +# Get the storage domain UUID and substitute it into the OVF doc. > +sds_service = system_service.storage_domains_service() > +sd = sds_service.list(search=("name=%s" % params['output_storage&...

Mainly minor fixes and code cleanups over the v4 patch. There are still several problems with this patch, but it is in a reviewable state, especially the Python code. Rich.