search for: immutablephase

...get clarification from the community on the > use of multiple inheritance for the case of Phases like > AllDisjointAddrspaces. From what I can gather, the use of multiple > inheritance is to separate the interface (TargetAddrSpace) to access data > from the interface of the phase (ImmutablePhase). In this case, will we > ever create a concrete class from TargetAddrSpace that doesn't also derive > from ImmutablePass? If not, I don't think is worth using multiple > inheritance in this case. I think you are right here, changing the inheritance in this way also works fine....

...I just want to get clarification from the community on the use of multiple inheritance for the case of Phases like AllDisjointAddrspaces. From what I can gather, the use of multiple inheritance is to separate the interface (TargetAddrSpace) to access data from the interface of the phase (ImmutablePhase). In this case, will we ever create a concrete class from TargetAddrSpace that doesn't also derive from ImmutablePass? If not, I don't think is worth using multiple inheritance in this case. >> [Deleted text] >>> The last part of this patch is an addition to InstCombi...

Hi Mon Ping, > I don't have a problem having another class, TargetAddrSpace, to store this > information. However, I don't think it make sense being a standalone pass. > Address spaces seems to part of the TargetData and it seems more natural > to ask the TargetData to return the TargetAddrSpace object (similar to > struct layout) to describe the relationships