search for: imagetransferphase

...ISHED_FAILURE. + # If the transfer was paused, we need to cancel it to remove the disk, + # otherwise the system will remove the disk and transfer shortly after. + endt = time.time() + timeout while True: - transfer = transfer_service.get() - if transfer.phase != types.ImageTransferPhase.INITIALIZING: + time.sleep(1) + try: + transfer = transfer_service.get() + except sdk.NotFoundError: + # The system has removed the disk and the transfer. + raise RuntimeError("transfer %s was removed" % transfer.id) + + if tran...

After invoking transfer_service.finalize, check operation status by examining ImageTransferPhase and DiskStatus. This is done instead of failing after a predefined timeout regardless the status. * not verified * Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1680361 --- v2v/rhv-upload-plugin.py | 26 +++++++++++++++++++++----- 1 file changed, 21 insertions(+), 5 deletions(-) diff --g...

...ransfer was paused, we need to cancel it to remove the disk, > + # otherwise the system will remove the disk and transfer shortly after. > + > endt = time.time() + timeout > while True: > - transfer = transfer_service.get() > - if transfer.phase != types.ImageTransferPhase.INITIALIZING: > + time.sleep(1) > + try: > + transfer = transfer_service.get() > + except sdk.NotFoundError: > + # The system has removed the disk and the transfer. > + raise RuntimeError("transfer %s was removed" % t...

...4/types.py index 9b3f557ee..60ba541cd 100644 --- a/v2v/test-v2v-o-rhv-upload-module/ovirtsdk4/types.py +++ b/v2v/test-v2v-o-rhv-upload-module/ovirtsdk4/types.py @@ -73,7 +73,7 @@ class Disk(object): ): pass - id = 123 + id = "123" status = DiskStatus.OK class ImageTransferPhase(Enum): @@ -104,7 +104,7 @@ class ImageTransfer(object): ): pass - id = 456 + id = "456" phase = ImageTransferPhase.TRANSFERRING transfer_url = "http://localhost:" + str(imageio_port) + "/" -- 2.21.0

...cancel it to remove the disk, > > + # otherwise the system will remove the disk and transfer shortly after. > > + > > endt = time.time() + timeout > > while True: > > - transfer = transfer_service.get() > > - if transfer.phase != types.ImageTransferPhase.INITIALIZING: > > + time.sleep(1) > > + try: > > + transfer = transfer_service.get() > > + except sdk.NotFoundError: > > + # The system has removed the disk and the transfer. > > + raise RuntimeError("tra...

On Sun, Mar 17, 2019 at 2:07 PM Daniel Erez <derez@redhat.com> wrote: > After invoking transfer_service.finalize, check operation > status by examining ImageTransferPhase and DiskStatus. > This is done instead of failing after a predefined timeout > regardless the status. > > * not verified * > > Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1680361 > --- > v2v/rhv-upload-plugin.py | 26 +++++++++++++++++++++----- > 1 file changed,...

...ug("cannot find a running host with hw_id=%r, " + "that belongs to datacenter '%s', " "using any host" % (vdsm_id, datacenter.name)) return None @@ -193,15 +193,15 @@ def open(readonly): if transfer.phase != types.ImageTransferPhase.INITIALIZING: break if time.time() > endt: - raise RuntimeError("timed out waiting for transfer status " + + raise RuntimeError("timed out waiting for transfer status " "!= INITIALIZING")...

...+Subproject commit 646a44e1b190c4a7f6a9f32c63230c619e38d251 diff --git a/v2v/rhv-upload-plugin.py b/v2v/rhv-upload-plugin.py index 1a217b6dc..3272c3ce3 100644 --- a/v2v/rhv-upload-plugin.py +++ b/v2v/rhv-upload-plugin.py @@ -193,41 +193,41 @@ def open(readonly): if transfer.phase != types.ImageTransferPhase.INITIALIZING: break if time.time() > endt: raise RuntimeError("timed out waiting for transfer status " "!= INITIALIZING") # Now we have permission to start the transfer. if params['rhv_direct...

On Sun, Mar 17, 2019 at 2:59 PM Nir Soffer <nsoffer@redhat.com> wrote: > > On Sun, Mar 17, 2019 at 2:07 PM Daniel Erez <derez@redhat.com> wrote: >> >> After invoking transfer_service.finalize, check operation >> status by examining ImageTransferPhase and DiskStatus. >> This is done instead of failing after a predefined timeout >> regardless the status. >> >> * not verified * >> >> Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1680361 >> --- >> v2v/rhv-upload-plugin.py | 26 ++++++++++++++++...

...+ b/v2v/rhv-upload-plugin.py @@ -188,7 +188,6 @@ def open(readonly): # actual transfer can start when its status is "Transferring". endt = time.time() + timeout while True: - time.sleep(5) transfer = transfer_service.get() if transfer.phase != types.ImageTransferPhase.INITIALIZING: break @@ -196,6 +195,7 @@ def open(readonly): transfer_service.cancel() raise RuntimeError("timed out waiting for transfer status " "!= INITIALIZING") + time.sleep(5) # Now we have...

...-upload-plugin.py | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/v2v/rhv-upload-plugin.py b/v2v/rhv-upload-plugin.py index 57e90484f..51a7f381a 100644 --- a/v2v/rhv-upload-plugin.py +++ b/v2v/rhv-upload-plugin.py @@ -193,12 +193,14 @@ def open(readonly): if transfer.phase != types.ImageTransferPhase.INITIALIZING: break if time.time() > endt: + transfer_service.cancel() raise RuntimeError("timed out waiting for transfer status " "!= INITIALIZING") # Now we have permission to start the tra...

...ass + class ConfigurationType(Enum): OVA = 'ova' OVF = 'ovf' @@ -71,9 +72,8 @@ class Disk(object): sparse = False, storage_domains = None ): - pass + self.id = id - id = "123" status = DiskStatus.OK class ImageTransferPhase(Enum): @@ -104,7 +104,7 @@ class ImageTransfer(object): ): pass - id = "456" + id = "e26ac8ab-7090-4d5e-95ad-e707b511a359" phase = ImageTransferPhase.TRANSFERRING transfer_url = "http://localhost:" + str(imageio_port) + "/" @...

...+ name = None, + description = None, + format = None, + initial_size = None, + provisioned_size = None, + sparse = False, + storage_domains = None + ): + pass + + id = 123 + status = DiskStatus.OK + +class ImageTransferPhase(Enum): + CANCELLED = 'cancelled' + FINALIZING_FAILURE = 'finalizing_failure' + FINALIZING_SUCCESS = 'finalizing_success' + FINISHED_FAILURE = 'finished_failure' + FINISHED_SUCCESS = 'finished_success' + INITIALIZING = 'initializing'...

v1 was here: https://www.redhat.com/archives/libguestfs/2018-September/msg00121.html v2: - Rewrote patch 2 from scratch so it incorporates Nir's suggestions. - Add fake module to EXTRA_DIST. - Retested. Unfortunately I am no longer able to test the ordinary conversion path because ovirtsdk4 is incompatible with Fedora 29 / Python 3.7:

Fixes the majority of the pycodestyle issues in the Python scripts, and fix the existing test-v2v-python-syntax.sh to use pycodestyle to actually perform style checks. Pino Toscano (6): PEP 8: adapt whitespaces in lines PEP 8: move imports at the top PEP 8: adapt empty lines tests: find all the Python scripts for syntax checks -o rhv-upload: remove unused Python imports Revamp check

...host with hw_id=%r, " > + "that belongs to datacenter '%s', " > "using any host" % (vdsm_id, datacenter.name)) > return None > > @@ -193,15 +193,15 @@ def open(readonly): > if transfer.phase != types.ImageTransferPhase.INITIALIZING: > break > if time.time() > endt: > - raise RuntimeError("timed out waiting for transfer status " + > + raise RuntimeError("timed out waiting for transfer status " > "...

...90c4a7f6a9f32c63230c619e38d251 > diff --git a/v2v/rhv-upload-plugin.py b/v2v/rhv-upload-plugin.py > index 1a217b6dc..3272c3ce3 100644 > --- a/v2v/rhv-upload-plugin.py > +++ b/v2v/rhv-upload-plugin.py > @@ -193,41 +193,41 @@ def open(readonly): > if transfer.phase != types.ImageTransferPhase.INITIALIZING: > break > if time.time() > endt: > raise RuntimeError("timed out waiting for transfer status " > "!= INITIALIZING") > > # Now we have permission to start the transfer. &g...

This adds a test of -o rhv-upload. Obviously for an upstream test we cannot require a working oVirt server. This test works by faking the ovirtsdk4 Python module, setting PYTHONPATH so that the fake module is picked up instead of the real module (if installed). However it's more complex than that because the nbdkit plugin also expects to talk to a working imageio HTTPS server. Therefore

...> > diff --git a/v2v/rhv-upload-plugin.py b/v2v/rhv-upload-plugin.py > > index 1a217b6dc..3272c3ce3 100644 > > --- a/v2v/rhv-upload-plugin.py > > +++ b/v2v/rhv-upload-plugin.py > > @@ -193,41 +193,41 @@ def open(readonly): > > if transfer.phase != types.ImageTransferPhase.INITIALIZING: > > break > > if time.time() > endt: > > raise RuntimeError("timed out waiting for transfer status " > > "!= INITIALIZING") > > > > # Now we have permissi...

...> + format = None, > + initial_size = None, > + provisioned_size = None, > + sparse = False, > + storage_domains = None > + ): > + pass > + > + id = 123 > + status = DiskStatus.OK > + > +class ImageTransferPhase(Enum): > + CANCELLED = 'cancelled' > + FINALIZING_FAILURE = 'finalizing_failure' > + FINALIZING_SUCCESS = 'finalizing_success' > + FINISHED_FAILURE = 'finished_failure' > + FINISHED_SUCCESS = 'finished_success' > + INITIALI...