search for: imagetransf

...ions(-) diff --git a/v2v/rhv-upload-plugin.py b/v2v/rhv-upload-plugin.py index c3de7d555..44972de21 100644 --- a/v2v/rhv-upload-plugin.py +++ b/v2v/rhv-upload-plugin.py @@ -123,9 +123,8 @@ def open(readonly): # Create a new image transfer. transfer = transfers_service.add( types.ImageTransfer( - image = types.Image( - id = disk.id - ) + disk = types.Disk(id = disk.id), + inactivity_timeout = 0, ) ) debug("transfer.id = %r" % transfer.id) -- 2.16.2

...ecific target code. Here is how rhv-upload can work using NBD: 1. rhv-upload plugin separated to pre and post scripts - pre - prepare disk and start image transfer - post - finialize image transfer, create vm, etc. 2. rhr-upload-pre plugin create a transfer with transport="nbd" POST /imagetransfers <image_transfer> <disk id="123"/> <direction>upload</direction> <format>raw</format> <transport>nbd</transport> </image_transfer> Engine does not implement <transport> yet, but this should be an easy change....

...n, disk, host): system_service = connection.system_service() transfers_service = system_service.image_transfers_service() + extra = {} + if transfer_supports_format(): + extra["format"] = types.DiskFormat.RAW + transfer = transfers_service.add( types.ImageTransfer( disk = types.Disk(id = disk.id), host = host, inactivity_timeout = 3600, + **extra, ) ) @@ -591,6 +599,17 @@ def finalize_transfer(connection, transfer, disk_id): "timed out waiting for transfer %s to finaliz...

...4/types.py index 9b3f557ee..60ba541cd 100644 --- a/v2v/test-v2v-o-rhv-upload-module/ovirtsdk4/types.py +++ b/v2v/test-v2v-o-rhv-upload-module/ovirtsdk4/types.py @@ -73,7 +73,7 @@ class Disk(object): ): pass - id = 123 + id = "123" status = DiskStatus.OK class ImageTransferPhase(Enum): @@ -104,7 +104,7 @@ class ImageTransfer(object): ): pass - id = 456 + id = "456" phase = ImageTransferPhase.TRANSFERRING transfer_url = "http://localhost:" + str(imageio_port) + "/" -- 2.21.0

...e.image_transfers_service() - # Create a new image transfer. - host = find_host(connection) + # Create a new image transfer, using the local host is possible. + host = find_host(connection) if params['rhv_direct'] else None transfer = transfers_service.add( types.ImageTransfer( disk = types.Disk(id = disk.id), -- 2.17.1

...n, disk, host): system_service = connection.system_service() transfers_service = system_service.image_transfers_service() + extra = {} + if transfer_supports_format(): + extra["format"] = types.DiskFormat.RAW + transfer = transfers_service.add( types.ImageTransfer( disk = types.Disk(id = disk.id), host = host, inactivity_timeout = 3600, + **extra, ) ) @@ -531,6 +539,17 @@ def create_transfer(connection, disk, host): return transfer +def transfer_supports_format(): + ""&...

Fixes the majority of the pycodestyle issues in the Python scripts, and fix the existing test-v2v-python-syntax.sh to use pycodestyle to actually perform style checks. Pino Toscano (6): PEP 8: adapt whitespaces in lines PEP 8: move imports at the top PEP 8: adapt empty lines tests: find all the Python scripts for syntax checks -o rhv-upload: remove unused Python imports Revamp check

v2 was here: https://www.redhat.com/archives/libguestfs/2018-June/msg00109.html v3: - Added/fixed all suggestions from Nir in previous review. Q: I wasn't sure if we still need the "UnsupportedError" class so I left it in. Q: Does the Unix socket always have the same name? What happens if there's more than one transfer happening? I tested this both ways, and it worked both

...pass + + def system_service(self): + return SystemService() + +class SystemService(object): + def data_centers_service(self): + return DataCentersService() + + def disks_service(self): + return DisksService() + + def image_transfers_service(self): + return ImageTransfersService() + + def storage_domains_service(self): + return StorageDomainsService() + + def vms_service(self): + return VmsService() + +class DataCentersService(object): + def list(self, search=None, case_sensitive=False): + return [] + +class DiskService(object): +...

v1 was here: https://www.redhat.com/archives/libguestfs/2018-September/msg00121.html v2: - Rewrote patch 2 from scratch so it incorporates Nir's suggestions. - Add fake module to EXTRA_DIST. - Retested. Unfortunately I am no longer able to test the ordinary conversion path because ovirtsdk4 is incompatible with Fedora 29 / Python 3.7:

...d-plugin.py b/v2v/rhv-upload-plugin.py > index c3de7d555..44972de21 100644 > --- a/v2v/rhv-upload-plugin.py > +++ b/v2v/rhv-upload-plugin.py > @@ -123,9 +123,8 @@ def open(readonly): > # Create a new image transfer. > transfer = transfers_service.add( > types.ImageTransfer( > - image = types.Image( > - id = disk.id > - ) > + disk = types.Disk(id = disk.id), > + inactivity_timeout = 0, > Using 0 disables the timeout mechanism, did you mean 3600? > ) > ) > debu...

...> - # Create a new image transfer. > - host = find_host(connection) > + # Create a new image transfer, using the local host is possible. > + host = find_host(connection) if params['rhv_direct'] else None > transfer = transfers_service.add( > types.ImageTransfer( > disk = types.Disk(id = disk.id), > -- > 2.17.1 >

...an work using NBD: > > 1. rhv-upload plugin separated to pre and post scripts > > - pre - prepare disk and start image transfer > - post - finialize image transfer, create vm, etc. > > 2. rhr-upload-pre plugin create a transfer with transport="nbd" > > POST /imagetransfers > > <image_transfer> > <disk id="123"/> > <direction>upload</direction> > <format>raw</format> > <transport>nbd</transport> > </image_transfer> > > Engine does not implement <transport...

On Thu, Nov 21, 2019 at 02:17:43PM +0000, Daniel P. Berrangé wrote: > I would define a new 'api_version()' method for your python > plugins. > > Existing plugins don't implement that of course so when your > C code invokes that it'll get an exception, and can assume > the classic API contract for pwrite(). > > If the plugin implements

Hello, I need to do some basic statistics on raster images (tiff or png). I need only an advice where to start, which package is the most appropriate. My search attempts were without success, yet. Many thanks Tomas

...se(params['output_conn']) > @@ -121,9 +144,11 @@ def open(readonly): > transfers_service = system_service.image_transfers_service() > > # Create a new image transfer. > + host = find_host(connection) > transfer = transfers_service.add( > types.ImageTransfer( > disk = types.Disk(id = disk.id), > + host = host, > inactivity_timeout = 3600, > ) > Nice! > ) > @@ -170,6 +195,7 @@ def open(readonly): > can_flush = False > can_trim = False > can_zero = False...

..."could not retrieve host with hw_id=%s" % vdsm_id) + except: + pass + # Get a reference to the transfer service. transfers_service = system_service.image_transfers_service() @@ -124,6 +144,7 @@ def open(readonly): transfer = transfers_service.add( types.ImageTransfer( disk = types.Disk(id = disk.id), + host = types.Host(id = host.id) if host else None, inactivity_timeout = 3600, ) ) @@ -170,6 +191,7 @@ def open(readonly): can_flush = False can_trim = False can_zero = False + unix_socket = No...

Add support for qcow2 disk format, enabled by imageio NBD backend in RHV 4.3. To use this feature manually, you can run virt-v2v with "-of qcow2". Here is example run: Source disk: $ qemu-img info /var/tmp/fedora-30.img image: /var/tmp/fedora-30.img file format: raw virtual size: 6 GiB (6442450944 bytes) disk size: 1.15 GiB virt-v2v: $ ./run virt-v2v \ -v \ -i disk

...ut_conn URL. parsed = urlparse(params['output_conn']) @@ -121,9 +144,11 @@ def open(readonly): transfers_service = system_service.image_transfers_service() # Create a new image transfer. + host = find_host(connection) transfer = transfers_service.add( types.ImageTransfer( disk = types.Disk(id = disk.id), + host = host, inactivity_timeout = 3600, ) ) @@ -170,6 +195,7 @@ def open(readonly): can_flush = False can_trim = False can_zero = False + unix_socket = None http.putrequest("OPTION...

..."could not retrieve host with hw_id=%s" % vdsm_id) + except: + pass + # Get a reference to the transfer service. transfers_service = system_service.image_transfers_service() @@ -124,6 +144,7 @@ def open(readonly): transfer = transfers_service.add( types.ImageTransfer( disk = types.Disk(id = disk.id), + host = types.Host(id = host.id) if host is not None else None, inactivity_timeout = 3600, ) ) @@ -170,6 +191,7 @@ def open(readonly): can_flush = False can_trim = False can_zero = False + unix...