search for: image_scn_mem_writ

...es back as SymbolRef::ST_Data, and the code gets dumped as bytes instead of disassembled. I traced the problem back to COFFObjectFile::getSymbolType() in llvm/lib/Object/COFFObjectFile.cpp : if (Characteristics & COFF::IMAGE_SCN_MEM_READ && ~Characteristics & COFF::IMAGE_SCN_MEM_WRITE) // Read only. Result = SymbolRef::ST_Data; I think it should also check for ~Characteristics & COFF::IMAGE_SCN_MEM_EXECUTE. The symbol, in this case, is READ, EXECUTE, !WRITE. if (Characteristics & COFF::IMAGE_SCN_MEM_READ && ~Characteristics & COFF...

...es back as SymbolRef::ST_Data, and the code gets dumped as bytes instead of disassembled. I traced the problem back to COFFObjectFile::getSymbolType() in llvm/lib/Object/COFFObjectFile.cpp : if (Characteristics & COFF::IMAGE_SCN_MEM_READ && ~Characteristics & COFF::IMAGE_SCN_MEM_WRITE) // Read only. Result = SymbolRef::ST_Data; I think it should also check for ~Characteristics & COFF::IMAGE_SCN_MEM_EXECUTE. The symbol, in this case, is READ, EXECUTE, !WRITE. if (Characteristics & COFF::IMAGE_SCN_MEM_READ && ~Characteristics & COFF...

Hello all! I extended the LDC2 with a pragma to register a funcion in the llvm.global_ctors or llvm.global_dtors list. On Linux, references to these functions are placed in .ctors and .dtors sections and everything runs fine. On Windows, functions from llvm.global_ctors are placed in section .CRT$XCU, which is automatically called by the MS C Runtime. However, functions from

...t;getName().begin(), Symbol->getName().end()); > + > + MCSymbolData *SymbolData = getSymbolData(Symbol); > + > + unsigned Characteristics = > + COFF::IMAGE_SCN_LNK_COMDAT | > + COFF::IMAGE_SCN_CNT_UNINITIALIZED_DATA | > + COFF::IMAGE_SCN_MEM_READ | > + COFF::IMAGE_SCN_MEM_WRITE; > + > + int Selection = COFF::IMAGE_COMDAT_SELECT_LARGEST; > + > + MCSection const *Section = MCStreamer::getContext().getCOFFSection( > + SectionName, Characteristics, Selection, SectionKind::getBSS() > + ); Please spell the type as "const MCSection *". I would...

On Sun, Jul 11, 2010 at 6:10 PM, Chris Lattner <clattner at apple.com> wrote: > This probably needs to be slightly tweaked to work with mainline.  I don't see anything objectionable, but I think Daniel needs to review this one. Updated patch to work with mainline. http://github.com/Bigcheese/llvm-mirror/commit/d19a4c82c18afc4830c09b70f02d162292231c94 - Michael Spencer