search for: ifnotcrossappliance

...iconv handling builder: rename "program_name" into "progname" tests: isolate iso_system_id baseline string Include stdint.h where needed build: use $(SED) instead of sed when possible tests/c-api: add a way to skip test when host and appliance differ actions: mark as IfNotCrossAppliance tests of command and command_lines customize, mllib: use the libvirt CFLAGS tests: switch from get_current_dir_name to getcwd(0, NULL) configure: map also amd64 as host_cpu to x86_64 qemu bootstrap | 2 ++ builder/index-parse.y | 4...

...nk-disk-with-backing.qcow2"]]), []; ]; shortdesc = "return whether disk has a backing file"; longdesc = "\ @@ -4303,67 +4303,67 @@ C<guestfs_is_file>, C<guestfs_is_blockdev> (etc), C<guestfs_is_zero>." }; tests = [ InitScratchFS, IfNotCrossAppliance, TestResultString ( [["mkdir"; "/command"]; - ["upload"; "test-command"; "/command/test-command"]; + ["upload"; "$builddir/test-command"; "/command/test-command"]; ["chmod";...

...match optional with + | Some group -> StringSet.add group acc + | None -> acc in + List.fold_left ( + fun acc test -> + match test with + | (_, IfAvailable group, _, _) -> StringSet.add group acc + | (_, (Always|IfNotCrossAppliance|Disabled), _, _) -> acc + ) acc tests + ) StringSet.empty all_functions in + let features = List.sort compare (StringSet.elements features) in + let nr_features = List.length features in + pr "size_t nr_features = %d;\n" nr_features; + pr "\n"; + pr "struc...

v7: The only changes since v6 are those suggested by Pino in the review of v5.

I should probably start by saying this patch series isn't ready for review yet. This patch series adds a test harness to libguestfs. It allows us to run the tests outside the ordinary 'make check' path in the build tree. In particular, you can use this to run tests when libguestfs has been installed. 'make check' and the other 'make check-*' rules still work. The

Since v3: - A large number of fixes, especially for running the tests on installed libguestfs. - Fixed EXTRA_DIST rules throughout. - Extra patch 17/17 which is a tidy-up of the generated XML listing guests. Rich.

This is a more complete patch to add the test harness. The only parts missing now are the language bindings (except OCaml). The language bindings need a bit more thought. At the moment most language binding tests are done through some sort of shell script like perl/run-perl-tests which either runs each test itself or uses some language-specific machinary to run each test. The problem with that

Since v2: - Add perl tests. - Reworked and fixed the tests for virt-builder. - Some further minor bug fixes.

Split up the huge generator/actions.ml into several smaller files. Rich.

If we want to permit more than 255 drives to be added, then we will have to add the disks to the same virtio-scsi target using different unit (LUN) numbers. Unfortunately SCSI LUN enumeration in the Linux is not deterministic (eg. two disks with target=0, lun=[0,1] can be enumerated as /dev/sda or /dev/sdb randomly). Dealing with that will require some very complex device name translation on the

v1 -> v2: - Fixed everything mentioned in patch review. - Libdir module is removed as a separate commit. Rich.

...generator/tests_c_api.ml @@ -69,7 +69,7 @@ let rec generate_c_api_tests () = let hash : (string, bool) Hashtbl.t = Hashtbl.create 13 in List.iter ( - fun { tests = tests } -> + fun { tests } -> let seqs = filter_map ( function | (_, (Always|IfAvailable _|IfNotCrossAppliance), test, cleanup) -> @@ -81,7 +81,7 @@ let rec generate_c_api_tests () = ) actions; List.iter ( - fun { name = name } -> + fun { name } -> if not (Hashtbl.mem hash name) then pr " \"%s\",\n" name ) (actions |> sort); @@ -98,7 +98,7...

...ure. - *) | Disabled - - (* Run the test only if 'string' is available in the daemon. *) | IfAvailable of string - - (* Run the test when the appliance and the OS differ - for example, - * when using a fixed appliance created in a different OS/distribution. - *) | IfNotCrossAppliance (* Some initial scenarios for testing. *) and c_api_test_init = - (* Do nothing, block devices could contain random stuff including - * LVM PVs, and some filesystems might be mounted. This is usually - * a bad idea. - *) | InitNone - - (* Block devices are empty and no fil...

This is a follow-up to the other generator changes in: https://www.redhat.com/archives/libguestfs/2017-February/msg00217.html Rich.

This works reliably for me ... Rich.

v2 -> v3: - Renamed List.assoc_ -> List.assoc_lbl. - Rebased on top of current master branch. Rich.

Per my previous email: https://www.redhat.com/archives/libguestfs/2017-September/msg00203.html I'd like to talk about requiring a more modern version of the OCaml compiler. These commits show some of the code changes which would be possible with OCaml >= 3.12 [which it turns out we already require by accident] and also with OCaml >= 4.02. The latter is my favoured option. Rich.

In Std_utils we already extend Char and String. These commits take it a little further by extending List and adding a new Option submodule. All basically simple refactoring. Rich.

This time including the first commit ...

...name = "command"; added = (1, 9, 1); - style = RString "output", [StringList "arguments"], []; + style = RString "output", [StringList (PlainString, "arguments")], []; protocol_limit_warning = true; tests = [ InitScratchFS, IfNotCrossAppliance, TestResultString ( @@ -2457,7 +2457,7 @@ locations." }; { defaults with name = "command_lines"; added = (1, 9, 1); - style = RStringList "lines", [StringList "arguments"], []; + style = RStringList "lines", [StringList (PlainString, &quo...