search for: idx2mbbcompare

Hola LLVMers, We saw a problem with some code in LiveIntervalAnalysis.h/.c which we've fixed locally. We'd like to get a patch to the mainline and want to know how you'd like it fixed. A couple of things come together to cause the problem: struct Idx2MBBCompare { bool operator()(const IdxMBBPair &LHS, const IdxMBBPair &RHS) const { return LHS.first < RHS.first; } This comparator function compares the first elements of the IdxMBBPair. This is in contrast to the default comparator for std::pairs, which compares the second ele...

...i]; > } > > -namespace llvm { > - inline bool operator<(unsigned V, const IdxMBBPair &IM) { > - return V < IM.first; > - } > > - inline bool operator<(const IdxMBBPair &IM, unsigned V) { > - return IM.first < V; > - } > - > - struct Idx2MBBCompare { > - bool operator()(const IdxMBBPair &LHS, const IdxMBBPair &RHS) > const { > - return LHS.first < RHS.first; > - } > - }; > -} > - > Index: include/llvm/CodeGen/LiveIntervalAnalysis.h > ==========================================================...

Hi Evan, Here is a patch for the LiveIntervalAnalysis that we discussed. --- Evan Cheng <evan.cheng at apple.com> schrieb: > > 1) What is the easiest way to understand which MBB a given > instruction index belongs to? All the required information is > available in the > > MBB2IdxMap of the LiveIntervalAnalysis class. Would it be useful > to add a small function

...gt; - inline bool operator<(unsigned V, const IdxMBBPair &IM) { > > - return V < IM.first; > > - } > > > > - inline bool operator<(const IdxMBBPair &IM, unsigned V) { > > - return IM.first < V; > > - } > > - > > - struct Idx2MBBCompare { > > - bool operator()(const IdxMBBPair &LHS, const IdxMBBPair &RHS) > > > const { > > - return LHS.first < RHS.first; > > - } > > - }; > > -} > > - > > Index: include/llvm/CodeGen/LiveIntervalAnalysis.h > > ========...

...tor<(unsigned V, const IdxMBBPair &IM) { >>> - return V < IM.first; >>> - } >>> >>> - inline bool operator<(const IdxMBBPair &IM, unsigned V) { >>> - return IM.first < V; >>> - } >>> - >>> - struct Idx2MBBCompare { >>> - bool operator()(const IdxMBBPair &LHS, const IdxMBBPair &RHS) >> >>> const { >>> - return LHS.first < RHS.first; >>> - } >>> - }; >>> -} >>> - >>> Index: include/llvm/CodeGen/LiveIntervalAna...