search for: idfcalculatorbase

...the >> patch size grew a lot because I also "templatized" GraphDiff and all >> related classes to handle clang's CFG. >> >> If the answer to both of these questions is "no", I'd separate out a base >> of IDFCalculator, to a new class called IDFCalculatorBase that wouldn't >> contain either of said functions. >> >> Cheers! >> Kristóf >> >> >> [1] Sreedhar, Vugranam C., and Guang R. Gao. "A linear time algorithm for >> placing ϕ-nodes." Proceedings of the 22nd ACM SIGPLAN-SIGACT symposium on &...

...ar with GraphDiff) > This is used because the CFG used in LLVM changes all the time, right? If so, I don't see this being useful for us, since we don't mess with Clang's CFG much once it's built. > I'd separate out a base of IDFCalculator, to a new class called >> IDFCalculatorBase that wouldn't contain either of said functions. >> > If #2 if a lot of work/code, I'd say that separating it doesn't sound that > bad. It's not that complicated, then I wouldn't split it. > > > On Sun, Jun 16, 2019 at 10:56 AM Kristóf Umann <dkszelethus a...

...ely that we find any use for this? Mind you, the patch size grew a lot because I also "templatized" GraphDiff and all related classes to handle clang's CFG. If the answer to both of these questions is "no", I'd separate out a base of IDFCalculator, to a new class called IDFCalculatorBase that wouldn't contain either of said functions. Cheers! Kristóf [1] Sreedhar, Vugranam C., and Guang R. Gao. "A linear time algorithm for placing ϕ-nodes." Proceedings of the 22nd ACM SIGPLAN-SIGACT symposium on Principles of programming languages. ACM, 1995. [2] [IDF] Teach Iterat...